mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-11-14 21:37:52 -07:00
b470fa5454
Advantages: * Simpler code in general * No extra volume objects created * Now actually notices if the disc or partition gets changed while the core is running * No longer picks up on disc access done by the GUI (it used to do so as long as the core was running) * Gets rid of a Core dependency in DiscIO There are two performance disadvantages: * FileMonitor is now a bit slower when used with VolumeDirectory because FileMonitor now always uses the FileSystemGCWii code for finding filenames instead of VolumeDirectory finding the filename on its own and directly hooking into FileMonitor. But this isn't such a big deal, because it's happening on the DVD thread, and my currently unmerged file system PR will make FileSystemGCWii's file finding code about as fast as VolumeDirectory's. * FileMonitor's creation of the file system object is now done on the CPU thread instead of the DVD thread, and it will be done even if FileMonitor logging is disabled. This will be fixed in the next commit.
36 lines
658 B
C++
36 lines
658 B
C++
// Copyright 2008 Dolphin Emulator Project
|
|
// Licensed under GPLv2+
|
|
// Refer to the license.txt file included.
|
|
|
|
#include "DiscIO/Filesystem.h"
|
|
#include <memory>
|
|
#include "DiscIO/FileSystemGCWii.h"
|
|
|
|
namespace DiscIO
|
|
{
|
|
IFileSystem::IFileSystem(const IVolume* _rVolume) : m_rVolume(_rVolume)
|
|
{
|
|
}
|
|
|
|
IFileSystem::~IFileSystem()
|
|
{
|
|
}
|
|
|
|
std::unique_ptr<IFileSystem> CreateFileSystem(const IVolume* volume)
|
|
{
|
|
if (!volume)
|
|
return nullptr;
|
|
|
|
std::unique_ptr<IFileSystem> filesystem = std::make_unique<CFileSystemGCWii>(volume);
|
|
|
|
if (!filesystem)
|
|
return nullptr;
|
|
|
|
if (!filesystem->IsValid())
|
|
filesystem.reset();
|
|
|
|
return filesystem;
|
|
}
|
|
|
|
} // namespace
|