piwalker/melonDS
1
0
Fork 0
mirror of https://github.com/melonDS-emu/melonDS.git synced 2025-07-24 22:59:58 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix potential overflow in fog density calculation

Browse Source
This commit is contained in:
StapleButter
2017-07-14 00:12:35 +02:00
parent a1401e724c
commit 04172f47de
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/GPU3D_Soft.cpp
View File

@ -1545,15 +1545,19 @@ void ScanlineFinalPass(s32 y)
} }
else else
{ {
z = (z - fogoffset) << fogshift; // technically: Z difference is shifted left by fog shift
densityid = z >> 19; // then bit 0-18 are the fractional part and bit 19-23 are the density index
// things are a little different here to avoid overflow in 32-bit range
z -= fogoffset;
densityid = z >> (19-fogshift);
if (densityid >= 32) if (densityid >= 32)
{ {
densityid = 32; densityid = 32;
densityfrac = 0; densityfrac = 0;
} }
else else
densityfrac = z & 0x7FFFF; densityfrac = (z << fogshift) & 0x7FFFF;
} }
// checkme // checkme