From 0c5dd28b1c5c1d17a2ce87efbd858059a8f9376f Mon Sep 17 00:00:00 2001
From: Nadia Holmquist Pedersen <nadia@nhp.sh>
Date: Thu, 26 Dec 2024 09:17:46 +0100
Subject: [PATCH] just case the string length to int to make std::min happy in
 all cases

---
 src/frontend/qt_sdl/EmuInstance.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/frontend/qt_sdl/EmuInstance.cpp b/src/frontend/qt_sdl/EmuInstance.cpp
index 25ccaa37..75db0018 100644
--- a/src/frontend/qt_sdl/EmuInstance.cpp
+++ b/src/frontend/qt_sdl/EmuInstance.cpp
@@ -1086,7 +1086,7 @@ std::optional<DSi_NAND::NANDImage> EmuInstance::loadNAND(const std::array<u8, DS
 
             // setting up username
             auto username = firmcfg.GetQString("Username");
-            size_t usernameLength = std::min(username.length(), (qsizetype) 10);
+            size_t usernameLength = std::min((int) username.length(), 10);
             memset(&settings.Nickname, 0, sizeof(settings.Nickname));
             memcpy(&settings.Nickname, username.utf16(), usernameLength * sizeof(char16_t));
 
@@ -1102,7 +1102,7 @@ std::optional<DSi_NAND::NANDImage> EmuInstance::loadNAND(const std::array<u8, DS
 
             // setup message
             auto message = firmcfg.GetQString("Message");
-            size_t messageLength = std::min(message.length(), (qsizetype) 26);
+            size_t messageLength = std::min((int) message.length(), 26);
             memset(&settings.Message, 0, sizeof(settings.Message));
             memcpy(&settings.Message, message.utf16(), messageLength * sizeof(char16_t));
 
@@ -1673,7 +1673,7 @@ void EmuInstance::customizeFirmware(Firmware& firmware, bool overridesettings) n
         auto username = firmcfg.GetQString("Username");
         if (!username.isEmpty())
         { // If the frontend defines a username, take it. If not, leave the existing one.
-            size_t usernameLength = std::min(username.length(), (qsizetype) 10);
+            size_t usernameLength = std::min((int) username.length(), 10);
             currentData.NameLength = usernameLength;
             memcpy(currentData.Nickname, username.utf16(), usernameLength * sizeof(char16_t));
         }
@@ -1708,7 +1708,7 @@ void EmuInstance::customizeFirmware(Firmware& firmware, bool overridesettings) n
         auto message = firmcfg.GetQString("Message");
         if (!message.isEmpty())
         {
-            size_t messageLength = std::min(message.length(), (qsizetype) 26);
+            size_t messageLength = std::min((int) message.length(), 26);
             currentData.MessageLength = messageLength;
             memcpy(currentData.Message, message.data(), messageLength * sizeof(char16_t));
         }