piwalker/melonDS
1
0
Fork 0
mirror of https://github.com/melonDS-emu/melonDS.git synced 2025-06-28 09:59:41 -06:00
Code Issues Packages Projects Releases Wiki Activity

ROMManager: initialise filedata to nullptr

Browse Source 
If a user manages to open a file as a ROM that is greater than 1 GiB,
it will cause a segmentation fault (a crash) in LoadROM due to a delete
being called on an uninitialised pointer, which is undefined behaviour.

Initialise filedata to nullptr to prevent this, as deleting a null
pointer is defined as a no-op.
This commit is contained in:
Rayyan Ansari
2023-11-05 20:21:16 +00:00
parent df571078cf
commit 0e4d082361
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/frontend/qt_sdl/ROMManager.cpp
View File

@ -1109,7 +1109,7 @@ bool LoadROM(QStringList filepath, bool reset)
{ {
if (filepath.empty()) return false; if (filepath.empty()) return false;
u8* filedata; u8* filedata = nullptr;
u32 filelen; u32 filelen;
std::string basepath; std::string basepath;