piwalker/melonDS
1
0
Fork 0
mirror of https://github.com/melonDS-emu/melonDS.git synced 2025-07-25 15:19:53 -06:00
Code Issues Packages Projects Releases Wiki Activity

wifi:

Browse Source 
* don't receive packets if the RX buffer is zero-sized
* avoid potential out-of-bound writes
This commit is contained in:
Arisotura
2020-08-19 19:16:09 +02:00
parent c9447935ff
commit 660792d64b
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Wifi.cpp
View File

@ -816,6 +816,9 @@ bool CheckRX(bool block)
if (!(IOPORT(W_RXCnt) & 0x8000)) if (!(IOPORT(W_RXCnt) & 0x8000))
return false; return false;
if (IOPORT(W_RXBufBegin) == IOPORT(W_RXBufEnd))
return false;
u16 framelen; u16 framelen;
u16 framectl; u16 framectl;
u8 txrate; u8 txrate;
@ -1049,7 +1052,7 @@ void USTimer(u32 param)
if (!(RXTime & RXHalfwordTimeMask)) if (!(RXTime & RXHalfwordTimeMask))
{ {
u16 addr = IOPORT(W_RXTXAddr) << 1; u16 addr = IOPORT(W_RXTXAddr) << 1;
*(u16*)&RAM[addr] = *(u16*)&RXBuffer[RXBufferPtr]; if (addr < 0x1FFF) *(u16*)&RAM[addr] = *(u16*)&RXBuffer[RXBufferPtr];
IncrementRXAddr(addr); IncrementRXAddr(addr);
RXBufferPtr += 2; RXBufferPtr += 2;
@ -1146,7 +1149,7 @@ void RFTransfer_Type3()
// TODO: wifi waitstates // TODO: wifi waitstates
u16 Read(u32 addr) u16 Read(u32 addr)
{ {//printf("WIFI READ %08X\n", addr);
if (addr >= 0x04810000) if (addr >= 0x04810000)
return 0; return 0;
@ -1236,7 +1239,7 @@ u16 Read(u32 addr)
} }
void Write(u32 addr, u16 val) void Write(u32 addr, u16 val)
{ {//printf("WIFI WRITE %08X %04X\n", addr, val);
if (addr >= 0x04810000) if (addr >= 0x04810000)
return; return;