piwalker/melonDS
1
0
Fork 0
mirror of https://github.com/melonDS-emu/melonDS.git synced 2025-07-25 23:29:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add some comments in VideoSettingsDialog

Browse Source
This commit is contained in:
Gess1t
2024-10-28 03:19:44 +01:00
parent bdcb7f6d26
commit 7b516d6396
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/frontend/qt_sdl/VideoSettingsDialog.cpp
View File

@ -43,6 +43,7 @@ void VideoSettingsDialog::setEnabled()
int renderer = cfg.GetInt("3D.Renderer"); int renderer = cfg.GetInt("3D.Renderer");
int ogldisplay = cfg.GetBool("Screen.UseGL"); int ogldisplay = cfg.GetBool("Screen.UseGL");
// We will need it to disable specific options where unsupported
int supportedRenderer = getsupportedRenderers(); int supportedRenderer = getsupportedRenderers();
bool base_gl = supportedRenderer > renderer3D_Software; bool base_gl = supportedRenderer > renderer3D_Software;
@ -67,7 +68,7 @@ void VideoSettingsDialog::setEnabled()
bool softwareRenderer = renderer == renderer3D_Software; bool softwareRenderer = renderer == renderer3D_Software;
ui->cbGLDisplay->setEnabled(softwareRenderer && base_gl); ui->cbGLDisplay->setEnabled(softwareRenderer && base_gl);
ui->cbVSync->setEnabled(!softwareRenderer || (softwareRenderer && ogldisplay)); ui->cbVSync->setEnabled(!softwareRenderer || (softwareRenderer && ogldisplay)); // Either an openGL renderer is used or OpenGL Display is enabled
ui->cbSoftwareThreaded->setEnabled(softwareRenderer); ui->cbSoftwareThreaded->setEnabled(softwareRenderer);
ui->cbxGLResolution->setEnabled(!softwareRenderer); ui->cbxGLResolution->setEnabled(!softwareRenderer);
ui->cbBetterPolygons->setEnabled(renderer == renderer3D_OpenGL); ui->cbBetterPolygons->setEnabled(renderer == renderer3D_OpenGL);
@ -98,10 +99,12 @@ int VideoSettingsDialog::getsupportedRenderers()
{ {
int gl_version = 0; int gl_version = 0;
// A proper version string or object isn't provided, so we have to parse it ourselves
if (isdigit(gl_version_str[0]) && isdigit(gl_version_str[2])) if (isdigit(gl_version_str[0]) && isdigit(gl_version_str[2]))
gl_version = (gl_version_str[0] - '0') * 100 + gl_version = (gl_version_str[0] - '0') * 100 +
(gl_version_str[2] - '0') * 10; (gl_version_str[2] - '0') * 10;
// OpenGL 4.3 is required for Compute Shaders while 3.2 is the base requirement
if (gl_version >= 430) if (gl_version >= 430)
renderer = renderer3D_OpenGLCompute; renderer = renderer3D_OpenGLCompute;
else if (gl_version >= 320) else if (gl_version >= 320)