piwalker/melonDS
1
0
Fork 0
mirror of https://github.com/melonDS-emu/melonDS.git synced 2025-07-23 06:10:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

GPU3D soft: prevent out of bounds read

Browse Source
This commit is contained in:
RSDuck
2021-05-24 19:41:24 +02:00
parent f271bdf325
commit 9181ab19c7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/GPU3D_Soft.cpp
View File

@ -1066,7 +1066,7 @@ void SoftRenderer::RenderPolygonScanline(RendererPolygon* rp, s32 y)
// against the pixel underneath // against the pixel underneath
if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr)) if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr))
{ {
if (!(dstattr & 0x3)) continue; if (!(dstattr & 0x3) || pixeladdr >= BufferSize) continue;
pixeladdr += BufferSize; pixeladdr += BufferSize;
dstattr = AttrBuffer[pixeladdr]; dstattr = AttrBuffer[pixeladdr];
@ -1162,7 +1162,7 @@ void SoftRenderer::RenderPolygonScanline(RendererPolygon* rp, s32 y)
// against the pixel underneath // against the pixel underneath
if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr)) if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr))
{ {
if (!(dstattr & 0x3)) continue; if (!(dstattr & 0x3) || pixeladdr >= BufferSize) continue;
pixeladdr += BufferSize; pixeladdr += BufferSize;
dstattr = AttrBuffer[pixeladdr]; dstattr = AttrBuffer[pixeladdr];
@ -1237,7 +1237,7 @@ void SoftRenderer::RenderPolygonScanline(RendererPolygon* rp, s32 y)
// against the pixel underneath // against the pixel underneath
if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr)) if (!fnDepthTest(DepthBuffer[pixeladdr], z, dstattr))
{ {
if (!(dstattr & 0x3)) continue; if (!(dstattr & 0x3) || pixeladdr >= BufferSize) continue;
pixeladdr += BufferSize; pixeladdr += BufferSize;
dstattr = AttrBuffer[pixeladdr]; dstattr = AttrBuffer[pixeladdr];