proof all dialogs against use-after-free when closing main window while a dialog is open

2025-07-25 23:29:55 -06:00 · 2024-10-27 14:24:59 +01:00
parent a61754bb58
commit f2dce621ce
11 changed files with 90 additions and 0 deletions
--- a/src/frontend/qt_sdl/EmuSettingsDialog.cpp
+++ b/src/frontend/qt_sdl/EmuSettingsDialog.cpp
@ -215,6 +215,13 @@ void EmuSettingsDialog::verifyFirmware()

 void EmuSettingsDialog::done(int r)
 {
+    if (!((MainWindow*)parent())->getEmuInstance())
+    {
+        QDialog::done(r);
+        closeDlg();
+        return;
+    }
+
    needsReset = false;

    if (r == QDialog::Accepted)