Merge 47b4df3d63 into 5e8beb3ab7

"Touch input interpolation" here is rather simple: it does a simple linear interpolation against the touch values between the last frame's touch position and the current frame's touch position, using the current frame cycle count. In case the last frame wasn't touching anything, it just touches immediately.

The API presented here was originally intended as a way to try to avoid merge conflicts. It is intended that before RunFrame(), the user would call MoveTouch(), then call TouchScreen() once RunFrame() returns.

Alternatively, TouchScreen() could be solely called before RunFrame() (this would probably be what the libretro port does, maybe some other ports). This however will run into issues for some games which do not like immediate changes to touch input every frame, rather needing touch input to go slowly across the frame, as touch input gets polled multiple times in a frame (see https://github.com/TASEmulators/BizHawk/issues/3397).

melonDS Qt doesn't do this however, instead just calling TouchScreen() within mouse event handlers, i.e. within the UI thread, not the emulator thread. This does end up making it (at least seemingly) avoid issues with games not liking exactly per frame touch changes, but it is just a giant race condition and probably should be changed.

BUILD.md

@@ -47,7 +47,7 @@
      1. Install Qt: `pacman -S <prefix>-{qt6-base,qt6-svg,qt6-multimedia,qt6-svg,qt6-tools}`
      2. Set up the build directory with `cmake -B build`
    * Static builds (without DLLs, standalone executable)
-     1. Install Qt: `pacman -S <prefi>-qt5-static`  
+     1. Install Qt: `pacman -S <prefix>-qt5-static`  
         (Note: As of writing, the `qt6-static` package does not work.)
      2. Set up the build directory with `cmake -B build -DBUILD_STATIC=ON -DUSE_QT6=OFF -DCMAKE_PREFIX_PATH=$MSYSTEM_PREFIX/qt5-static`
 7. Compile: `cmake --build build`

src/DSi_SPI_TSC.cpp

@@ -88,6 +88,8 @@ void DSi_TSC::SetTouchCoords(u16 x, u16 y)
     TouchX = x;
     TouchY = y;
 
+    DeltaX = DeltaY = 0;
+
     u8 oldpress = Bank3Regs[0x0E] & 0x01;
 
     if (y == 0xFFF)
@@ -121,6 +123,22 @@ void DSi_TSC::SetTouchCoords(u16 x, u16 y)
     }
 }
 
+void DSi_TSC::MoveTouchCoords(u16 x, u16 y)
+{
+    if (TSCMode == 0x00) return TSC::MoveTouchCoords(x, y);
+
+    if (Bank3Regs[0x0E] & 0x01)
+    {
+        return SetTouchCoords(x, y);
+    }
+
+    DeltaX = (x << 4) - (TouchX & ~0x8000);
+    DeltaY = (y << 4) - (TouchY & ~0x8000);
+
+    Bank3Regs[0x09] = 0x80;
+    Bank3Regs[0x0E] &= ~0x01;
+}
+
 void DSi_TSC::MicInputFrame(const s16* data, int samples)
 {
     if (TSCMode == 0x00) return TSC::MicInputFrame(data, samples);
@@ -162,8 +180,9 @@ void DSi_TSC::Write(u8 val)
             {
                 // X coordinates
 
-                if (id & 0x01) Data = TouchX >> 8;
+                u16 touchX = TouchX + CreateTouchOffset(DeltaX);
-                else           Data = TouchX & 0xFF;
+                if (id & 0x01) Data = touchX >> 8;
+                else           Data = touchX & 0xFF;
 
                 TouchX &= 0x7FFF;
             }
@@ -171,8 +190,9 @@ void DSi_TSC::Write(u8 val)
             {
                 // Y coordinates
 
-                if (id & 0x01) Data = TouchY >> 8;
+                u16 touchY = TouchY + CreateTouchOffset(DeltaY);
-                else           Data = TouchY & 0xFF;
+                if (id & 0x01) Data = touchY >> 8;
+                else           Data = touchY & 0xFF;
 
                 TouchY &= 0x7FFF; // checkme
             }

src/DSi_SPI_TSC.h

@@ -40,6 +40,7 @@ public:
     void SetMode(u8 mode);
 
     void SetTouchCoords(u16 x, u16 y) override;
+    void MoveTouchCoords(u16 x, u16 y) override;
     void MicInputFrame(const s16* data, int samples) override;
 
     void Write(u8 val) override;

src/NDS.cpp

@@ -1122,6 +1122,11 @@ void NDS::TouchScreen(u16 x, u16 y)
     SPI.GetTSC()->SetTouchCoords(x, y);
 }
 
+void NDS::MoveTouch(u16 x, u16 y)
+{
+    SPI.GetTSC()->MoveTouchCoords(x, y);
+}
+
 void NDS::ReleaseScreen()
 {
     SPI.GetTSC()->SetTouchCoords(0x000, 0xFFF);

src/NDS.h

@@ -392,6 +392,7 @@ public: // TODO: Encapsulate the rest of these members
     bool IsRunning() const noexcept { return Running; }
 
     void TouchScreen(u16 x, u16 y);
+    void MoveTouch(u16 x, u16 y);
     void ReleaseScreen();
 
     void SetKeyMask(u32 mask);

src/SPI.cpp

@@ -352,6 +352,12 @@ void PowerMan::Write(u8 val)
 }
 
 
+s16 TSC::CreateTouchOffset(s16 delta) const
+{
+    // 560190 cycles per frame
+    s64 cyclepos = (s64)NDS.GetSysClockCycles(2);
+    return (cyclepos * delta) / 560190;
+}
 
 TSC::TSC(melonDS::NDS& nds) : SPIDevice(nds)
 {
@@ -392,6 +398,8 @@ void TSC::SetTouchCoords(u16 x, u16 y)
     TouchX = x;
     TouchY = y;
 
+    DeltaX = DeltaY = 0;
+
     if (y == 0xFFF)
     {
         // released
@@ -404,6 +412,17 @@ void TSC::SetTouchCoords(u16 x, u16 y)
     NDS.KeyInput &= ~(1 << (16+6));
 }
 
+void TSC::MoveTouchCoords(u16 x, u16 y)
+{
+    if (NDS.KeyInput & (1 << (16+6)))
+    {
+        return SetTouchCoords(x, y);
+    }
+
+    DeltaX = (x << 4) - TouchX;
+    DeltaY = (y << 4) - TouchY;
+}
+
 void TSC::MicInputFrame(const s16* data, int samples)
 {
     if (!data)
@@ -433,8 +452,8 @@ void TSC::Write(u8 val)
 
         switch (ControlByte & 0x70)
         {
-        case 0x10: ConvResult = TouchY; break;
+        case 0x10: ConvResult = TouchY + CreateTouchOffset(DeltaY); break;
-        case 0x50: ConvResult = TouchX; break;
+        case 0x50: ConvResult = TouchX + CreateTouchOffset(DeltaX); break;
 
         case 0x60:
             {

src/SPI.h

@@ -121,6 +121,7 @@ public:
     virtual void DoSavestate(Savestate* file) override;
 
     virtual void SetTouchCoords(u16 x, u16 y);
+    virtual void MoveTouchCoords(u16 x, u16 y);
     virtual void MicInputFrame(const s16* data, int samples);
 
     virtual void Write(u8 val) override;
@@ -131,9 +132,12 @@ protected:
     u16 ConvResult;
 
     u16 TouchX, TouchY;
+    s16 DeltaX, DeltaY;
 
     s16 MicBuffer[1024];
     int MicBufferLen;
+
+    s16 CreateTouchOffset(s16 delta) const;
 };