piwalker/ryujinx-ryubing
1
0
Fork 0
mirror of https://git.ryujinx.app/ryubing/ryujinx.git synced 2025-07-23 14:19:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

gdb: Add timeout to prevent deadlock in DebugStep

Browse Source 
Deadlock can happen when step at some svc instructions.
This commit is contained in:
Coxxs
2025-06-21 05:26:48 +08:00
parent 4ffe38731b
commit b6f6f8303f
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Ryujinx.HLE/HOS/Kernel/Process/KProcess.cs
View File

@ -1283,7 +1283,12 @@ namespace Ryujinx.HLE.HOS.Kernel.Process
} }
_kernelContext.CriticalSection.Leave(); _kernelContext.CriticalSection.Leave();
StepBarrier.SignalAndWait(); bool stepTimedOut = false;
if (!StepBarrier.SignalAndWait(TimeSpan.FromMilliseconds(2000)))
{
Logger.Warning?.Print(LogClass.Kernel, $"Failed to step thread {target.ThreadUid} in time.");
stepTimedOut = true;
}
_kernelContext.CriticalSection.Enter(); _kernelContext.CriticalSection.Enter();
steppingThread = null; steppingThread = null;
@ -1302,6 +1307,12 @@ namespace Ryujinx.HLE.HOS.Kernel.Process
target.Suspend(ThreadSchedState.ThreadPauseFlag); target.Suspend(ThreadSchedState.ThreadPauseFlag);
} }
_kernelContext.CriticalSection.Leave(); _kernelContext.CriticalSection.Leave();
if (stepTimedOut)
{
return false;
}
StepBarrier.SignalAndWait(); StepBarrier.SignalAndWait();
return true; return true;
} }