piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 13:27:45 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #13126 from jordan-woyak/no-big-banner

Browse Source 
DolphinQt: Restrict size of banner image in game properties info tab.
This commit is contained in:
Tilka 2024-10-12 09:40:20 +01:00 committed by GitHub
commit 2024d9f8ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/DiscIO/WiiSaveBanner.cpp
View File

@ -15,10 +15,6 @@
namespace DiscIO
{
constexpr u32 BANNER_WIDTH = 192;
constexpr u32 BANNER_HEIGHT = 64;
constexpr u32 BANNER_SIZE = BANNER_WIDTH * BANNER_HEIGHT * 2;
constexpr u32 ICON_WIDTH = 48;
constexpr u32 ICON_HEIGHT = 48;
constexpr u32 ICON_SIZE = ICON_WIDTH * ICON_HEIGHT * 2;
@ -31,6 +27,8 @@ WiiSaveBanner::WiiSaveBanner(u64 title_id)
WiiSaveBanner::WiiSaveBanner(const std::string& path) : m_path(path)
{
constexpr u32 BANNER_SIZE = BANNER_WIDTH * BANNER_HEIGHT * 2;
constexpr size_t MINIMUM_SIZE = sizeof(Header) + BANNER_SIZE + ICON_SIZE;
File::IOFile file(path, "rb");
if (!file.ReadArray(&m_header, 1))

3
Source/Core/DiscIO/WiiSaveBanner.h
View File

@ -13,6 +13,9 @@ namespace DiscIO
class WiiSaveBanner
{
public:
static constexpr u32 BANNER_WIDTH = 192;
static constexpr u32 BANNER_HEIGHT = 64;
explicit WiiSaveBanner(u64 title_id);
explicit WiiSaveBanner(const std::string& path);

5
Source/Core/DolphinQt/Config/InfoWidget.cpp
View File

@ -18,6 +18,7 @@
#include "DiscIO/Blob.h"
#include "DiscIO/Enums.h"
#include "DiscIO/Volume.h"
#include "DiscIO/WiiSaveBanner.h"
#include "DolphinQt/QtUtils/DolphinFileDialog.h"
#include "DolphinQt/QtUtils/ImageConverter.h"
@ -179,7 +180,9 @@ QWidget* InfoWidget::CreateBannerGraphic(const QPixmap& image)
QHBoxLayout* layout = new QHBoxLayout();
QLabel* banner = new QLabel();
banner->setPixmap(image);
banner->setPixmap(image.scaled(image.size().boundedTo(
QSize{DiscIO::WiiSaveBanner::BANNER_WIDTH, DiscIO::WiiSaveBanner::BANNER_HEIGHT})));
QPushButton* save = new QPushButton(tr("Save as..."));
connect(save, &QPushButton::clicked, this, &InfoWidget::SaveBanner);