piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 05:47:56 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

x64Emitter: Prefer MOVAPS to MOVAPD

Browse Source 
There is no reason to use MOVAPD over MOVAPS, for two reasons:
* There has never been a microarchitecture with separate single and double domains.
* MOVAPD is one byte longer than MOVAPS
This commit is contained in:
MerryMage 2019-04-27 12:54:43 +01:00
parent 2abe333ce9
commit 2d4dd8cdc1
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Common/x64Emitter.cpp
View File

@ -2180,7 +2180,11 @@ void XEmitter::MOVAPS(X64Reg regOp, const OpArg& arg)
}
void XEmitter::MOVAPD(X64Reg regOp, const OpArg& arg)
{
WriteSSEOp(0x66, sseMOVAPfromRM, regOp, arg);
// Prefer MOVAPS to MOVAPD as there is no reason to use MOVAPD over MOVAPS:
// - They have equivalent functionality.
// - There has never been a microarchitecture with separate single and double domains.
// - MOVAPD is one byte longer than MOVAPS.
MOVAPS(regOp, arg);
}
void XEmitter::MOVAPS(const OpArg& arg, X64Reg regOp)
{
@ -2188,7 +2192,7 @@ void XEmitter::MOVAPS(const OpArg& arg, X64Reg regOp)
}
void XEmitter::MOVAPD(const OpArg& arg, X64Reg regOp)
{
WriteSSEOp(0x66, sseMOVAPtoRM, regOp, arg);
MOVAPS(arg, regOp);
}
void XEmitter::MOVUPS(X64Reg regOp, const OpArg& arg)