Android: Remove nonsense code from double tap setting dialog

The currentValue variable doesn't use InputOverlay.OVERLAY_
constants, it uses NativeLibrary.ButtonType constants.

Sigh, why do enums have to be so bad on Android that Google
recommends against using them :(

Anyway, simply not doing anything is a reasonable option here.
What happens then is that if the currently selected button is
invalid for the current controller, none of the available options
in the dialog will be pre-selected.
This commit is contained in:
JosJuice 2022-04-05 19:08:58 +02:00
parent cdff426d23
commit 4120870628

View File

@ -864,12 +864,6 @@ public final class EmulationActivity extends AppCompatActivity
int buttonList = currentController == InputOverlay.OVERLAY_WIIMOTE_CLASSIC ?
R.array.doubleTapWithClassic : R.array.doubleTap;
if (currentController != InputOverlay.OVERLAY_WIIMOTE_CLASSIC &&
currentValue == InputOverlay.OVERLAY_WIIMOTE_CLASSIC)
{
currentValue = InputOverlay.OVERLAY_WIIMOTE;
}
int checkedItem = -1;
int itemCount = getResources().getStringArray(buttonList).length;
for (int i = 0; i < itemCount; i++)