piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 13:27:45 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

GeneralWidget: Recommend default video backend in tooltip

Browse Source 
Recommend the platform's default video backend in the Backend tooltip
instead of always recommending OpenGL.
This commit is contained in:
Dentomologist 2024-11-03 11:35:47 -08:00
parent 7b8610f4ea
commit 47a86d920f
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp
View File

@ -239,7 +239,7 @@ void GeneralWidget::AddDescriptions()
"recommended. Different games and different GPUs will behave differently on each " "recommended. Different games and different GPUs will behave differently on each "
"backend, so for the best emulation experience it is recommended to try each and " "backend, so for the best emulation experience it is recommended to try each and "
"select the backend that is least problematic.<br><br><dolphin_emphasis>If unsure, " "select the backend that is least problematic.<br><br><dolphin_emphasis>If unsure, "
"select OpenGL.</dolphin_emphasis>"); "select %1.</dolphin_emphasis>");
static const char TR_FULLSCREEN_DESCRIPTION[] = static const char TR_FULLSCREEN_DESCRIPTION[] =
QT_TR_NOOP("Uses the entire screen for rendering.<br><br>If disabled, a " QT_TR_NOOP("Uses the entire screen for rendering.<br><br>If disabled, a "
"render window will be created instead.<br><br><dolphin_emphasis>If " "render window will be created instead.<br><br><dolphin_emphasis>If "
@ -311,7 +311,9 @@ void GeneralWidget::AddDescriptions()
"unsure, leave this unchecked.</dolphin_emphasis>"); "unsure, leave this unchecked.</dolphin_emphasis>");
m_backend_combo->SetTitle(tr("Backend")); m_backend_combo->SetTitle(tr("Backend"));
m_backend_combo->SetDescription(tr(TR_BACKEND_DESCRIPTION)); m_backend_combo->SetDescription(
tr(TR_BACKEND_DESCRIPTION)
.arg(QString::fromStdString(VideoBackendBase::GetDefaultBackendDisplayName())));
m_adapter_combo->SetTitle(tr("Adapter")); m_adapter_combo->SetTitle(tr("Adapter"));

6
Source/Core/VideoCommon/VideoBackendBase.cpp
View File

@ -228,6 +228,12 @@ std::string VideoBackendBase::GetDefaultBackendConfigName()
return default_backend ? default_backend->GetName() : ""; return default_backend ? default_backend->GetName() : "";
} }
std::string VideoBackendBase::GetDefaultBackendDisplayName()
{
auto* const default_backend = GetDefaultVideoBackend();
return default_backend ? default_backend->GetDisplayName() : "";
}
const std::vector<std::unique_ptr<VideoBackendBase>>& VideoBackendBase::GetAvailableBackends() const std::vector<std::unique_ptr<VideoBackendBase>>& VideoBackendBase::GetAvailableBackends()
{ {
static auto s_available_backends = [] { static auto s_available_backends = [] {

1
Source/Core/VideoCommon/VideoBackendBase.h
View File

@ -65,6 +65,7 @@ public:
u16 Video_GetBoundingBox(int index); u16 Video_GetBoundingBox(int index);
static std::string GetDefaultBackendConfigName(); static std::string GetDefaultBackendConfigName();
static std::string GetDefaultBackendDisplayName();
static const std::vector<std::unique_ptr<VideoBackendBase>>& GetAvailableBackends(); static const std::vector<std::unique_ptr<VideoBackendBase>>& GetAvailableBackends();
static void ActivateBackend(const std::string& name); static void ActivateBackend(const std::string& name);