piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

MMU: Remove a bunch of useless swaps

Browse Source 
The swaps are confusing and don't accomplish much.

It was originally written like this:

u32 pte = bswap(*(u32*)&base_mem[pteg_addr]);

then bswap was changed to Common::swap32, and then the array access
was replaced with Memory::Read_U32, leading to the useless swaps.
This commit is contained in:
Léo Lam 2021-04-06 01:41:55 +02:00
parent 960d957f4f
commit 49edd5f482
No known key found for this signature in database
GPG Key ID: 0DF30F9081000741
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Core/PowerPC/MMU.cpp
View File

@ -1113,7 +1113,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe
// hash function no 1 "xor" .360
u32 hash = (VSID ^ page_index);
u32 pte1 = Common::swap32((VSID << 7) | api | PTE1_V);
u32 pte1 = (VSID << 7) | api | PTE1_V;
for (int hash_func = 0; hash_func < 2; hash_func++)
{
@ -1121,7 +1121,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe
if (hash_func == 1)
{
hash = ~hash;
pte1 |= PTE1_H << 24;
pte1 |= PTE1_H;
}
u32 pteg_addr =
@ -1129,7 +1129,7 @@ static TranslateAddressResult TranslatePageAddress(const u32 address, const XChe
for (int i = 0; i < 8; i++, pteg_addr += 8)
{
u32 pteg = Common::swap32(Memory::Read_U32(pteg_addr));
const u32 pteg = Memory::Read_U32(pteg_addr);
if (pte1 == pteg)
{