piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 05:47:56 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

IOS/STM: Reset the event hook at the correct time

Browse Source 
Just re-disassembled STM and found out I have made a mistake when
I changed STM stuff back in 2016.

I accidentally made STM reset the event hook on close when it should
have been done in the destructor (i.e. when IOS gets reset on console).

Verified in IDA that STM just `IOS_ResourceReply(request, IOS_OK)`
without ever resetting the hook.
This commit is contained in:
Léo Lam 2018-04-13 22:25:34 +02:00
parent f31221b3d0
commit 8bae4b7e51
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/Core/IOS/STM/STM.cpp
View File

@ -66,10 +66,9 @@ IPCCommandResult STMImmediate::IOCtl(const IOCtlRequest& request)
return GetDefaultReply(return_value);
}
IPCCommandResult STMEventHook::Close(u32 fd)
STMEventHook::~STMEventHook()
{
s_event_hook_request.reset();
return Device::Close(fd);
}
IPCCommandResult STMEventHook::IOCtl(const IOCtlRequest& request)

2
Source/Core/Core/IOS/STM/STM.h
View File

@ -55,7 +55,7 @@ class STMEventHook final : public Device
{
public:
using Device::Device;
IPCCommandResult Close(u32 fd) override;
~STMEventHook() override;
IPCCommandResult IOCtl(const IOCtlRequest& request) override;
void DoState(PointerWrap& p) override;