piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-28 09:59:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

AchievementManager - Minor cleanup

Browse Source 
Deleting the unused m_game_data and m_is_game_loaded fields.
This commit is contained in:
LillyJadeKatrin
2025-05-29 16:30:54 -04:00
parent 18a78a9bab
commit fd285f6348
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Source/Core/Core/AchievementManager.cpp
View File

@ -598,11 +598,6 @@ rc_client_t* AchievementManager::GetClient()
return m_client; return m_client;
} }
rc_api_fetch_game_data_response_t* AchievementManager::GetGameData()
{
return &m_game_data;
}
const AchievementManager::Badge& AchievementManager::GetGameBadge() const const AchievementManager::Badge& AchievementManager::GetGameBadge() const
{ {
return m_game_badge.data.empty() ? m_default_game_badge : m_game_badge; return m_game_badge.data.empty() ? m_default_game_badge : m_game_badge;
@ -736,12 +731,8 @@ void AchievementManager::CloseGame()
if (Config::Get(Config::RA_DISCORD_PRESENCE_ENABLED)) if (Config::Get(Config::RA_DISCORD_PRESENCE_ENABLED))
Discord::UpdateDiscordPresence(); Discord::UpdateDiscordPresence();
if (rc_client_get_game_info(m_client)) if (rc_client_get_game_info(m_client))
{
rc_api_destroy_fetch_game_data_response(&m_game_data);
rc_client_unload_game(m_client); rc_client_unload_game(m_client);
}
INFO_LOG_FMT(ACHIEVEMENTS, "Game closed."); INFO_LOG_FMT(ACHIEVEMENTS, "Game closed.");
m_game_data = {};
} }
m_update_callback(UpdatedItems{.all = true}); m_update_callback(UpdatedItems{.all = true});

4
Source/Core/Core/AchievementManager.h
View File

@ -160,7 +160,6 @@ public:
const Badge& GetPlayerBadge() const; const Badge& GetPlayerBadge() const;
std::string_view GetGameDisplayName() const; std::string_view GetGameDisplayName() const;
rc_client_t* GetClient(); rc_client_t* GetClient();
rc_api_fetch_game_data_response_t* GetGameData();
const Badge& GetGameBadge() const; const Badge& GetGameBadge() const;
const Badge& GetAchievementBadge(AchievementId id, bool locked) const; const Badge& GetAchievementBadge(AchievementId id, bool locked) const;
const LeaderboardStatus* GetLeaderboardInfo(AchievementId leaderboard_id); const LeaderboardStatus* GetLeaderboardInfo(AchievementId leaderboard_id);
@ -278,9 +277,6 @@ private:
std::atomic_bool m_background_execution_allowed = true; std::atomic_bool m_background_execution_allowed = true;
Badge m_player_badge; Badge m_player_badge;
Hash m_game_hash{}; Hash m_game_hash{};
u32 m_game_id = 0;
rc_api_fetch_game_data_response_t m_game_data{};
bool m_is_game_loaded = false;
Badge m_game_badge; Badge m_game_badge;
bool m_display_welcome_message = false; bool m_display_welcome_message = false;
std::unordered_map<AchievementId, Badge> m_unlocked_badges; std::unordered_map<AchievementId, Badge> m_unlocked_badges;