e37a195192
MainWindow: Fix use-after-free during shutdown
...
Remove ConfigChangedCallback in MainWindow's destructor to prevent the
callback from accessing the destroyed MainWindow afterward.
After MainWindow is destroyed UICommon::Shutdown calls
LogManager::Shutdown which ultimately triggers any remaining callbacks.
This resulted in calling MainWindow::OnHardcoreChanged, which crashed in
debug builds and didn't have any obvious effect in release builds.
2025-04-25 15:29:29 -07:00
9868138c22
UCodes: Remove redundant qualifiers
2025-04-25 13:18:56 +02:00
066408326c
Core/HW/EXI: Remove redundant inline specifiers
2025-04-25 12:03:52 +02:00
50ca32352f
Core/HW/GCMemcard: Make variables constant
2025-04-25 11:35:59 +02:00
805307f432
Merge pull request #13451 from vyuuui/numeric_labels
...
Add numeric label support to assembler
2025-04-25 01:56:43 +01:00
fe307a06c6
Merge pull request #13476 from jordan-woyak/sdl-header
...
InputCommon: Move SDL Device class into its own cpp/h files.
2025-04-25 01:49:52 +01:00
5523b9a01b
Merge pull request #13487 from Dentomologist/performancemetrics_fix_window_arrangement
...
PerformanceMetrics: Fix window arrangement
2025-04-25 01:40:58 +01:00
50026ab795
Merge pull request #13497 from hoogmin/modernize_fs_path
...
Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.
2025-04-25 01:38:35 +01:00
a6290caa2e
DSPHLE: set accelerator gain
2025-04-25 01:09:15 +01:00
8412a7c336
DSPAccelerator: update comment (NFC)
2025-04-25 01:09:15 +01:00
f0bacb826a
DSPAccelerator: rename MMIOPCMHalt to MMIOPCMNoInc
2025-04-25 01:09:15 +01:00
7c7c179b44
DSP tests: update DSP MMIO labels
2025-04-25 00:51:46 +01:00
05381c5b6d
Address Pokechu22's feedback
2025-04-25 00:51:46 +01:00
cd77e682ca
Name gain shift/scaling better
2025-04-25 00:51:46 +01:00
c460cafecf
Update ACDRAW/ACDSAMP reg names in DSPTables and DSPSpy tests
2025-04-25 00:51:46 +01:00
d517fe25f1
Add accelerator input MMIO register, fix MMIO PCM modes
2025-04-25 00:51:45 +01:00
14fadbbe56
ADPCM mode doesn't entirely die with larger accesses, gain is PCM only
2025-04-25 00:51:45 +01:00
c7d8afc5a7
Use correct exceptions for d3 reads/writes
2025-04-25 00:51:45 +01:00
0dd282f626
Fix DSPAcceleratorTest
2025-04-25 00:51:45 +01:00
ac2fdefcb4
Refactor accelerator format as a bitfield, use gain/yn1/yn2 in PCM mode
2025-04-25 00:51:45 +01:00
04c7c1a4a1
Rename accelerator accesses to 'raw' and 'sample'
2025-04-25 00:51:45 +01:00
256d9f8702
Improve ReadD3 emulation
2025-04-25 00:51:45 +01:00
bbc11edd7d
Rework WriteD3 based on hardware testing
2025-04-25 00:51:45 +01:00
4d9dc1e1cd
GekkoDisassembler: standardize SPR names and add missing ones
2025-04-25 00:24:12 +01:00
ef8b9a0dcd
Core/HW/SI: Make variables constant
2025-04-24 17:01:12 +02:00
8fa725d5e4
Merge pull request #13573 from tygyh/DolphinTool-Make-parameter-constant
...
DolphinTool: Make parameter constant
2025-04-24 00:49:10 -04:00
fc0aafca3b
Merge pull request #13577 from tygyh/UCodes-Make-functions-static
...
UCodes: Make functions static
2025-04-24 00:48:46 -04:00
f675048768
Merge pull request #13578 from tygyh/Core/HW-Remove-redundant-empty-lambda-parameter-lists
...
Core/HW: Remove redundant empty lambda parameter lists
2025-04-24 00:48:28 -04:00
1cea31c75a
Merge pull request #13580 from LillyJadeKatrin/retroachievements-de-bug-debug
...
Fix debugger disabled bug
2025-04-23 23:28:19 -05:00
3025cd472c
Merge pull request #13491 from JosJuice/oh0-removed-opened
...
IOS: Remove from m_opened_devices in OH0::OnDeviceChange
2025-04-23 23:25:34 -05:00
022bc3bf8d
Fix debugger disabled bug
...
Fixing an oversight: this was causing the debugger to be disabled if achievements were disabled but hardcore mode was still enabled in the .ini. This fix properly checks for hardcore state via AchievementManager which takes both settings into account.
2025-04-23 22:57:35 -04:00
8bb07bf3c4
LibusbDevice: Send wakeup command to Santroller devices
2025-04-24 12:09:41 +12:00
879a8889aa
Merge pull request #13431 from jordan-woyak/spsc-waiting
...
Common: SPSCQueue cleanups and improvements.
2025-04-23 22:19:15 +02:00
564e7c3320
UCodes: Make functions static
2025-04-23 21:36:13 +02:00
467a568f60
Core/HW: Remove redundant empty lambda parameter lists
2025-04-23 21:32:09 +02:00
03a6fdcd85
DolphinTool: Make variables constant
2025-04-23 20:24:50 +02:00
bda1f379b7
IOS: Remove from m_opened_devices in OH0::OnDeviceChange
...
I've been playing Rock Band 3 recently and have experienced a bug where
sometimes if you disconnect and reconnect a USB microphone, the game
won't pick up on it connecting, not even it you disconnect and reconnect
it again. An investigation into what's going on inside Dolphin shows
that when the game triggers a call to OH0::DeviceOpen after the device
has been reinserted, Dolphin doesn't open the device because it's
already present in m_opened_devices.
Removing the device from m_opened_devices after calling OH0::TriggerHook
in OH0::OnDeviceChange resolves this specific issue in my testing. Doing
this matches us removing the device from m_opened_devices after calling
OH0::TriggerHook in OH0::DeviceClose, but I haven't looked at exactly
what real IOS does.
I have been able to reproduce a much rarer issue that has the same
symptoms on the surface but where OH0::DeviceOpen gets past its
m_opened_devices check. I'm currently not sure what the cause of this
remaining issue is.
2025-04-23 17:19:14 +02:00
fe657b9759
DolphinTool: Make parameter constant
2025-04-23 15:55:48 +02:00
e751235574
DolphinQt: Remove unused variables from AdvancedPane.h
...
Small oversight from #13422 .
2025-04-23 12:32:12 +02:00
bf554edfe0
linter: Add and apply new formatting rules
...
New rules:
`InsertNewlineAtEOF: true`
`RemoveSemicolon: true`
`RequiresClausePosition: WithPreceding`
2025-04-23 11:19:57 +02:00
2c54ee94c1
linter: Apply clang-format 19.1 formatting
...
find ./Source/ -name '*.cpp' -o -name '*.h' | xargs clang-format-19 -i
2025-04-23 11:19:20 +02:00
8f3483fdd4
Merge pull request #13565 from LillyJadeKatrin/retroachievements-end-of-memory-bug
...
Fix memory bounds error in achievements dev
2025-04-23 01:01:47 -04:00
af960651e8
Common: SPSCQueue cleanups and improvements.
2025-04-22 23:49:32 -05:00
116bd3a031
Merge pull request #13382 from JoshuaVandaele/btadapterchoice
...
Add a GUI option to select a bluetooth device
2025-04-22 22:05:30 -05:00
8b610101bc
Fix memory bounds error in achievements dev
...
This particular out of bounds error was causing every memory read at the far end of memory to return all zeroes.
2025-04-22 22:49:55 -04:00
c4f65febf3
Merge pull request #13563 from Tilka/rcheevos
...
Fix building with USE_RETRO_ACHIEVEMENTS=OFF
2025-04-23 03:27:15 +01:00
871073eee2
Merge pull request #13564 from jordan-woyak/triforce_ipl-warning
...
Core/Boot: Fix unused variable warning.
2025-04-23 03:26:48 +01:00
31a3de819d
Merge pull request #13540 from tygyh/DiscIO-Remove-redundant-qualifiers
...
DiscIO: Remove redundant qualifiers
2025-04-22 20:00:03 -05:00
0fd090ce19
Merge pull request #13550 from Tilka/top_warnings
...
IOS/Network: fix some warnings
2025-04-22 19:45:47 -05:00
4773a6f323
Add a GUI option to select a bluetooth device
2025-04-23 02:19:28 +02:00
