Commit Graph

37068 Commits

Author SHA1 Message Date
Pokechu22
087d89225c DSPCodeUtil: Give better output when comparing instructions with large immediates 2022-06-14 12:22:06 -07:00
Pokechu22
cad9801ded DSPDisassembler: Fix out-of-bounds read when the last word is an instruction with a large immediate
For instance, ending with 0x009e (which you can do with CW 0x009e) indicates a LRI $ac0.m instruction, but there is no immediate value to load, so before whatever garbage in memory existed after the end of the file was used.

The bounds-checking also previously assumed that IRAM or IROM was being used, both of which were exactly 0x1000 long.
2022-06-14 12:22:06 -07:00
Pokechu22
dc353ed84d DSPTool: Exit with status 1 if binary comparison fails 2022-06-14 12:22:06 -07:00
Pokechu22
693a29f8ce DSPCodeUtil: Use fmt::print instead of logging in DSP::Compare 2022-06-14 12:22:05 -07:00
Pokechu22
d8803a1298 UnitTests: Use fmt::print in DSPAssemblyTest 2022-06-14 12:22:05 -07:00
Pokechu22
8fac249581 UnitTests: Use fmt::print in PageFaultTest 2022-06-14 12:22:05 -07:00
Pokechu22
dd66dac5c1 UnitTests: Fix typo in DSPAssemblyTest 2022-06-14 12:22:05 -07:00
Pokechu22
3cb0976367 UnitTests: Use hermes.s as part of an actual test
Before, the file just existed as the source code for HermesBinary.cpp, but we can test that things assemble correctly too (compare DSPTestBinary.cpp and DSPTestText.cpp).

A bit of jank is needed due to MSVC limitations (see https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2026?view=msvc-170).
2022-06-14 12:22:05 -07:00
Pokechu22
2193c8964e DSPTool: Remove moved files from VS project file
These were moved into UnitTests in #5449.
2022-06-14 12:22:05 -07:00
JMC47
9315ac7071
Merge pull request #10587 from AdmiralCurtiss/memcard-path-unify
Raw Memory Card Path handling unification and consistency fixes.
2022-06-13 20:18:36 -04:00
JMC47
f96e91119a
Merge pull request #10735 from CasualPokePlayer/audio_dump_volume_fix
Have audio dumps apply volume
2022-06-13 17:09:58 -04:00
JosJuice
82b0098c3b
Merge pull request #10737 from Tilka/alignas
Common: replace std::aligned_storage_t with alignas
2022-06-13 18:11:48 +02:00
Tillmann Karras
59dfc43949 Common: replace std::aligned_storage_t with alignas
C++23 deprecates std::aligned_storage_t while alignas works since C++11.

This fixes issue 12925.
2022-06-13 00:06:19 +01:00
Mai
99f98b2481
Merge pull request #10733 from shuffle2/wsl-lint
lint: use git.exe if the source resides on v9fs
2022-06-12 16:13:57 -04:00
Mai
f1993182f0
Merge pull request #10744 from OatmealDome/ventura-exception
MemTools: Always provide a valid pointer in send_msg for mach_msg_overwrite
2022-06-12 03:44:18 -04:00
OatmealDome
3e5f1a4f99 MemTools: Always provide a valid pointer in send_msg for mach_msg_overwrite
This cannot be nullptr in macOS Ventura and iOS 16.
2022-06-12 00:19:09 -04:00
JMC47
05160d8d2e
Merge pull request #10734 from JMC47/fzerocheatsini
Add F-Zero AX Approximation Gecko Codes to F-Zero GX
2022-06-11 13:46:24 -04:00
JMC47
ef384ca6d3
Merge pull request #10739 from JMC47/monsterhouseini
Disable icache emulation for Monster House
2022-06-11 13:41:04 -04:00
JosJuice
ebd5904b38
Merge pull request #10736 from JMC47/UltiShootColl-INI
Add Medium Texture Cache setting to Ultimate Shooting Collection INI.
2022-06-11 19:40:34 +02:00
CasualPokePlayer
ad892176d0 have audio dumps apply volume (fixes cases of audio dumps being "too loud" and in game audio controls having no effect) 2022-06-10 21:27:10 -07:00
JMC47
1db46fbd8b Disable icache emulation for Monster House
This game has stale icache values in the logs during certain
loadscreens, and after disabling them I was able to play through the
entire game, with one crash that may have been related to savestates and
memory cards since during that loadscreen it said the memory card did
not match.

This does cause invalid reads to be spit out during parts of the game,
but you can safely skip them.  Enabling MMU seems to surpress the
invalid reads without side-effects, but the aforementioned
memcard/savestate crash was with MMU on.
2022-06-10 21:05:29 -04:00
Tilka
aad42de6c9
Merge pull request #10688 from Sage-King/help
Added help information to Contributing.md
2022-06-10 00:14:58 +01:00
JMC47
e4f7994cf9 Add Medium Texture Cache to RKA INI
Ultimate Shooting Collection needs Medium Texture Cache for some text to
render correctly.
2022-06-09 16:30:13 -04:00
JMC47
a59a3631c8 Add F-Zero AX Gecko Codes to F-Zero GX 2022-06-09 01:01:11 -04:00
Shawn Hoffman
a93babb1b3 lint: use git.exe if the source resides on v9fs
speedup for running script under wsl2 when sources are mounted from host
2022-06-08 21:10:31 -07:00
Mai M
0c6b6b74bf
Merge pull request #10726 from OatmealDome/mvk-1.1.10
MoltenVK: Update to version 1.1.10
2022-06-08 22:46:43 -04:00
Pierre Bourdon
d74fb444f4
Merge pull request #10728 from delroth/steamrt-opt-out
cmake: steam runtime builds should be opt-in, not opt-out
2022-06-08 16:46:18 +02:00
Pierre Bourdon
f1b7d9365c
cmake: steam runtime builds should be opt-in, not opt-out 2022-06-08 16:44:14 +02:00
OatmealDome
e1fd741bf5 MoltenVK: Update to version 1.1.10 2022-06-08 02:33:06 -04:00
Mai M
099aaf0037
Merge pull request #10724 from JosJuice/android-manifest-namespace
AndroidManifest.xml: Re-add package="org.dolphinemu.dolphinemu"
2022-06-06 23:59:22 -04:00
JMC47
daf8e3ddde
Merge pull request #10462 from OatmealDome/steam-runtime
DolphinQt: Add support for a Steam Runtime build
2022-06-06 20:18:06 -04:00
JosJuice
dd0485389e AndroidManifest.xml: Re-add package="org.dolphinemu.dolphinemu"
Without this, debug builds of Dolphin fail to launch. The OS tries
to locate org.dolphinemu.dolphinemu.debug.DolphinApplication
but fails to find it because its actual name is
org.dolphinemu.dolphinemu.DolphinApplication.

Partially reverts 6b74907f9d.
2022-06-06 21:57:21 +02:00
Admiral H. Curtiss
86fc13ff86
Merge pull request #10704 from Tilka/minizip
CMake: rename minizip to minizip-ng
2022-06-06 20:37:19 +02:00
Tillmann Karras
79a7bf02eb
CMake: rename minizip to minizip-ng
minizip-ng is the new name used by the upstream project as well as all
distros other than Fedora (but it looks like it will be renamed there).
2022-06-06 14:21:43 +02:00
Admiral H. Curtiss
4fd18cf207
DolphinQt: Unify handling of raw memory card path. 2022-06-05 21:48:13 +02:00
Admiral H. Curtiss
deb9964333
Core: Unify handling of raw memory card path. 2022-06-05 21:43:48 +02:00
Admiral H. Curtiss
b1d1f2aa06
Common/StringUtil: Add convenience function for converting paths to use forward slashes on Windows. 2022-06-05 21:24:45 +02:00
Admiral H. Curtiss
2081e2f2a1
Config: Move ToGameCubeRegion(), GetDirectoryForRegion(), and GetBootROMPath() to new config system namespace. 2022-06-05 21:24:45 +02:00
JMC47
664663e8de
Merge pull request #10604 from Pokechu22/gcadapter-refactor
Refactor GCAdapter, part 1
2022-06-04 16:30:25 -04:00
Admiral H. Curtiss
96f9d1000d
Merge pull request #10721 from Dentomologist/fix_warnings_on_generic_builder
Fix warnings on generic builder
2022-06-04 21:51:58 +02:00
Dentomologist
92af703f29 DSPAssembler: Fix -Wswitch warning 2022-06-04 12:08:09 -07:00
Tilka
d7cda67462
Merge pull request #10716 from Pokechu22/dsp-lle-loop-saturation
DSP LLE: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m
2022-06-04 15:30:06 +01:00
Dentomologist
2999cca41b UnitTests: Fix -Wrange-loop-construct warnings
Don't use reference variable bound to a temporary value
2022-06-03 22:28:17 -07:00
Sage King
978f4cb947 Added help information to Contributing.md 2022-06-03 15:41:17 -06:00
Admiral H. Curtiss
9fb17b5a48
Merge pull request #10718 from shuffle2/hotkeys
qt: unregister Settings' DevicesChanged callback during shutdown
2022-06-03 13:48:28 +02:00
Admiral H. Curtiss
8265ca4f3b
Merge pull request #10719 from shuffle2/wiipane
qt: fix wiipane usb list layout
2022-06-03 13:46:56 +02:00
Shawn Hoffman
b16711f2af qt: fix wiipane usb list layout 2022-06-02 23:58:13 -07:00
Shawn Hoffman
27dd2c4aa4 qt: unregister Settings' DevicesChanged callback during shutdown
fixes a crash on close
2022-06-02 23:32:21 -07:00
Pokechu22
6823b4d7a0 GCAdapter: Use LibusbUtils::ErrorWrap in log messages 2022-06-02 19:39:36 -07:00
Pokechu22
457fcbaf5e LibusbUtils: Create ErrorWrap 2022-06-02 19:39:36 -07:00