41076 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Tilka	198a53e7df	Merge pull request #12397 from lioncash/asset ... CustomAssetLibrary: Remove unused GetAssetSize() function	2023-12-12 20:02:44 +00:00
Tilka	87b44a2fb8	Merge pull request #12400 from lioncash/expparse ... ExpressionParser: Get rid of some redundant copies	2023-12-12 19:17:29 +00:00
Lioncash	ded2d55438	ExpressionParser: Avoid some miscellaneous copies ... Just some trivial copies that can be eliminated or turned into moves.	2023-12-12 14:03:41 -05:00
Lioncash	a5bbeb721a	ExpressionParser: Mark constructors explicit where applicable ... Makes for consistency with the surrounding code.	2023-12-12 14:00:27 -05:00
Lioncash	ea71a76ea9	ExpressionParser: Pass control qualifiers by const reference ... These aren't necessarily cheap to copy, since a control qualifier will have around 3 std::strings inside of it, so passing by value can churn allocations a little bit.	2023-12-12 13:50:46 -05:00
Lioncash	4c7a4831cb	CustomAssetLibrary: Remove unused GetAssetSize() function ... There's a direct analogue of this function within DirectFilesystemAssetLibrary that *is* used, however, so we can get rid of this one.	2023-12-11 22:00:52 -05:00
Admiral H. Curtiss	2c6bf2d224	Merge pull request #12394 from lioncash/compare ... General: Resolve -Wsign-compare warnings	2023-12-12 03:43:12 +01:00
Admiral H. Curtiss	9326186d2c	Merge pull request #12396 from lioncash/opeq ... Core/SyncIdentifier: Default operator==	2023-12-12 03:42:18 +01:00
Lioncash	e011c3b383	Core/SyncIdentifier: Default operator== ... Lets us remove a bunch of code and a dependency on the <tuple> header.	2023-12-11 19:39:55 -05:00
Tilka	6699acf10c	Merge pull request #12386 from lioncash/setting ... Common/SettingsHandler: Minor convenience changes	2023-12-12 00:02:21 +00:00
Admiral H. Curtiss	f04d834e8f	Merge pull request #12393 from lioncash/tls ... DolphinQT/Host: Remove unused TLS variable tls_is_host_thread	2023-12-12 00:29:21 +01:00
Lioncash	0e51c0f8fc	JitArm64_RegCache: Resolve -Wsign-compare warning	2023-12-11 18:15:50 -05:00
Lioncash	4c3a5eb1c5	JitArm64_SystemRegisters: Resolve -Wsign-compare warning	2023-12-11 18:11:34 -05:00
Lioncash	017b9a0af7	FloatUtilsTest: Resolve -Wsign-compare warning	2023-12-11 18:08:52 -05:00
Lioncash	4bef3b93b4	AndroidCommon: Resolve -Wsign-compare warning	2023-12-11 18:06:40 -05:00
Lioncash	f97316a1e6	TraversalClient: Resolve -Wsign-compare warning	2023-12-11 18:01:29 -05:00
Lioncash	49f44c1334	VertexManagerBase: Resolve -Wsign-compare warning	2023-12-11 18:00:34 -05:00
Admiral H. Curtiss	b48af86148	Merge pull request #12390 from lioncash/string ... GraphicsModListWidget: Add string specifier to By and Description fields	2023-12-11 23:47:53 +01:00
Admiral H. Curtiss	4f02f526b8	Merge pull request #12392 from lioncash/decl ... General: Resolve -Wmissing-declaration warnings	2023-12-11 23:39:23 +01:00
Admiral H. Curtiss	54301d709a	Merge pull request #12389 from lioncash/cheeve ... AchievementManager: Make GetInstance() and GetLock() return a reference	2023-12-11 23:37:29 +01:00
Lioncash	f490b990f5	DolphinQT/Host: Remove unimplemented prototypes ... Remnants of prior existing code.	2023-12-11 17:30:56 -05:00
Lioncash	d705c31d1a	DolphinQT/Host: Remove unused TLS variable tls_is_host_thread ... This is never accessed or read from.	2023-12-11 17:27:57 -05:00
Admiral H. Curtiss	16ba56a34b	Merge pull request #12388 from lioncash/compare ... GameFile: Default GameBanner operator==	2023-12-11 23:25:27 +01:00
Tilka	c6a10b5740	Merge pull request #12391 from lioncash/reorder ... General: Resolve -Wreorder warnings	2023-12-11 22:09:48 +00:00
Lioncash	e8b4796273	PostProcessing: Mark helper functions as static ... These didn't have any prototypes and were generating -Wmissing-declaration warnings.	2023-12-11 17:07:59 -05:00
Lioncash	abb5cc3a3a	ShaderAsset: Mark ParseShaderProperties() as static ... This had no function prototype, so this can be internally linked. Resolves a -Wmissing-declaration warning.	2023-12-11 17:05:06 -05:00
Lioncash	b4b624b97b	WC24PatchEngine: Mark LoadPatches() as static ... Resolves a -Wmissing-declaration warning, since no prototype existed for the function.	2023-12-11 17:02:15 -05:00
Lioncash	2b2ee61e79	CustomShaderCache: Resolve -Wreorder warnings ... Lays out the initializer lists to be in the same order that initialization would occur in.	2023-12-11 16:59:03 -05:00
Lioncash	9472da788d	ConfigFloatSlider: Resolve -Wreorder warnings ... Orders the initializer list the way that the members would actually be initialized in. Resolves some -Wreorder warnings	2023-12-11 16:15:48 -05:00
Admiral H. Curtiss	dd0ac7d53c	Merge pull request #12387 from lioncash/cache ... GameFileCache: Pass std::function by reference rather than by value	2023-12-11 21:46:59 +01:00
Lioncash	5d1514418e	GraphicsModListWidget: Add string specifier to By and Description fields ... Translators should always know where text is going to be appended and have the ability to move things around to fit the language better.	2023-12-11 15:43:41 -05:00
Lioncash	d90537cc18	AchievementManager: Return by reference from GetLock() ... This makes the API a little nicer to use, since you don't need to do a mandatory dereference when passing the lock into any kind of scope guard.	2023-12-11 13:51:50 -05:00
Lioncash	3c7fa0738c	AchievementsWindow: Add missing override specifier	2023-12-11 13:47:59 -05:00
Lioncash	dbf28df64c	DolphinQT: Remove unnecessary includes from achievement files ... Reduces the amount of dependencies being pulled in on both local and external headers.	2023-12-11 13:40:55 -05:00
Lioncash	e55f9ed102	AchievementManager: Make GetInstance() return a reference ... The internal static member will always have a valid lifetime. Makes this consistent with other instance based objects in our code.	2023-12-11 13:36:39 -05:00
JosJuice	f87a4f0385	Merge pull request #12383 from iwubcode/android_new_sdk_for_cpp20 ... Android: update NDK to 26.1.10909125 in order to pick up new compiler features	2023-12-11 19:16:32 +01:00
Lioncash	cdf8849e17	GameFile: Default GameBanner operator== ... Same behavior, but less code.	2023-12-11 11:36:35 -05:00
Lioncash	ff38362216	GameFileCache: Use std::span with Update() ... All we're really doing is iterating over a sequence of strings, so we don't need to tie this specifically to std::vector.	2023-12-11 11:12:09 -05:00
Lioncash	2ca80adeb2	GameFileCache: Pass std::function by reference rather than by value ... std::function is internally allowed to allocate, and these functions aren't being stored anywhere (only called), so we can freely get rid of some minor overhead here by passing by reference. This change also creates aliases for the functions, so that there isn't a lot of visual noise when reading the function signatures.	2023-12-11 11:09:18 -05:00
Lioncash	88a973131c	Common/SettingsHandler: Use std::string_view more ... We don't need to enforce the use of std::string instances with AddSetting(). We can accept views and only construct one string, rather than three temporaries.	2023-12-11 07:54:43 -05:00
Lioncash	04b9f6c28d	Common/SettingsHandler: Use std::erase in Decrypt() ... Same behavior, way less verbose code.	2023-12-11 07:49:43 -05:00
Mai	d84ed054ee	Merge pull request #12374 from iwubcode/custom_texture_potential_crash_fix ... VideoCommon: prevent a potential custom texture crash	2023-12-11 07:42:48 -05:00
Mai	6e0bc2a4db	Merge pull request #12384 from AdmiralCurtiss/font-load-offset ... HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().	2023-12-10 20:53:22 -05:00
Admiral H. Curtiss	694b3b4ea1	HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().	2023-12-11 02:22:06 +01:00
Mai	c2b642d0b7	Merge pull request #12381 from AdmiralCurtiss/re-enable-achievement-nag ... AchievementManager: Only nag user about disabled achievements when they were actually enabled before.	2023-12-10 20:16:24 -05:00
Mai	bdd28f1f26	Merge pull request #12378 from JosJuice/jitarm64-a-early-discard ... JitArm64: Add additional condition for lmw/stmw a discard	2023-12-10 20:15:57 -05:00
iwubcode	b27cf432eb	Android: update NDK to 26.1.10909125 in order to pick up new compiler with more C++20 features	2023-12-10 19:14:29 -06:00
Admiral H. Curtiss	003872d7dd	Merge pull request #12380 from JosJuice/large-entry-points-map ... Add "large entry points map" setting	2023-12-10 21:56:09 +01:00
Admiral H. Curtiss	70cd0040a3	AchievementManager: Only nag user about disabled achievements when they were actually enabled before.	2023-12-10 21:10:49 +01:00
JosJuice	c55f21729f	Add "large entry points map" setting ... To aid in debugging, this makes it possible to disable the recently added 32/64 GiB region which hasn't had a proper name so far.	2023-12-10 21:07:27 +01:00