2b568566ac
Merge pull request #13535 from m-brodschi/mihaib/fix-shutdown-crash
...
Core, VideoCommon: Fix crash at shutdown due to destructor order
2025-05-01 21:29:02 -04:00
539a3ed021
Merge pull request #13464 from jordan-woyak/dont-toggle-skip-frames
...
DolphinQt: Don't auto toggle GFX_HACK_SKIP_DUPLICATE_XFBS.
2025-05-01 21:28:13 -04:00
7222779e21
Merge pull request #13448 from Dentomologist/fix_unresponsive_hotkeys_when_moving_overlay_during_framestep
...
DolphinQt: Fix unresponsive hotkeys when clicking overlay during a framestep
2025-05-01 21:27:30 -04:00
1bd2570d97
Merge pull request #13239 from JosJuice/jitarm64-rlwimix-imm-mask
...
JitArm64: Use AArch64 imm masks in rlwimix slow case
2025-05-01 21:26:27 -04:00
e4525ca7ee
Merge pull request #13499 from jordan-woyak/frame-pacing-better-math
...
CoreTiming: Cleanups to avoid drift from cumulative rounding errors.
2025-05-01 15:58:33 -05:00
6c9138e5a6
Merge pull request #13592 from SuperSamus/kfp-single-core
...
GameINI: Enable Single Core for Kung Fu Panda and Shrek Forever After
2025-05-01 15:30:15 -04:00
0ce929220d
Merge pull request #13553 from tygyh/Core/PowerPC/JitArm64-Replace-zeroes-in-boolean-context-with-false
...
JitArm64: Replace zeroes in boolean context with `false`
2025-05-01 10:11:44 +02:00
0987c03693
Merge pull request #13453 from tygyh/Use-underlying-method
...
DolphinQt/FIFO/FIFOAnalyzer: Use Common::ToUnderlying
2025-04-30 22:18:02 -05:00
e3f7486ca7
Merge pull request #13567 from tygyh/UnitTests-Rename-lambda-parameters-which-hide-previous-declarations
...
UnitTests: Rename lambda parameters which hide previous declarations
2025-04-30 22:07:35 -05:00
2e20e24136
Merge pull request #13587 from jordan-woyak/manual-value
...
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
2025-04-30 23:45:33 +02:00
cae82b62f8
Merge pull request #13610 from AdmiralCurtiss/zstd-asm-fix
...
Externals/zstd: Disable ASM for MSVC compiler in CMake
2025-04-30 23:31:55 +02:00
8e64a02a42
Merge pull request #13579 from jordan-woyak/work-queue-thread-cleanup
...
WorkQueueThread: Implement in terms of WaitableSPSCQueue. Add unit tests.
2025-04-30 16:10:28 -05:00
43e4e8f182
Merge pull request #13581 from jordan-woyak/dvd-WorkQueueThread
...
DVDThread: Implement with WorkQueueThread and WaitableSPSCQueue.
2025-04-30 16:09:36 -05:00
b5dd545b8e
Merge pull request #13504 from Filoppi/patch-23
...
Improve gamma corrected resampling by acknowledging the perceptual luminance
2025-04-30 16:09:08 -05:00
2049896cab
Improve gamma corrected resampling by acknowledging the perceptual luminance
2025-04-30 15:22:06 -05:00
4899913446
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
2025-04-30 14:56:07 -05:00
e8b63fe090
UnitTests: Add tests for WorkQueueThread.
2025-04-30 14:31:51 -05:00
a149b9d62d
WorkQueueThread: Cleanups. Implement in terms of WaitableSPSCQueue. Add single producer WorkQueueThreadSP.
2025-04-30 14:31:51 -05:00
2d9a61bd0e
Externals/zstd: Disable ASM for MSVC compiler in CMake
...
Results in a "MSVC_RUNTIME_LIBRARY value 'MultiThreadedDLL' not known for this ASM compiler" otherwise, and zstd doesn't support the relevant ASM code for MSVC anyway.
2025-04-30 20:32:01 +02:00
852bd6df1a
Merge pull request #13598 from AdmiralCurtiss/zstd157
...
Externals: Update zstd from 1.4.4 to 1.5.7
2025-04-30 19:06:52 +02:00
0b0151770a
Merge pull request #13436 from JoshuaVandaele/clang-format-19
...
Update clang-format to version 19
2025-04-30 01:17:31 -04:00
23a5ea3504
Merge pull request #13604 from fox8091/nstrike
...
GameINI: Disable Dual Core for NERF N-Strike
2025-04-29 14:56:32 -04:00
b49711fefb
Merge pull request #13600 from JoshuaVandaele/nixfix
...
CMake: Explicitely link udev if LIBUDEV_FOUND is set
2025-04-29 14:55:50 -04:00
d591e3b4e3
GameINI: Enable Single Core for Kung Fu Panda and Shrek Forever After
...
These games (both are made with the Lux Engine) randomly freeze with Dual Core.
2025-04-29 11:35:09 +02:00
26ae66297d
GameINI: Disable Dual Core for NERF N-Strike
2025-04-28 13:11:50 -05:00
bad78cfed4
Core, VideoCommon: Fix crash at shutdown due to destructor ordering
...
Previously, PerformanceTracker registered a callback to be updated on
emulation state changes. PerformanceTrackers live in a global variable
(g_perf_metrics) within libvideocommon. The callback was stored in a
global variable in libcore. This created a race condition at shutdown
between these libraries, when the PerfTracker's destructor tried to
unregister the callback.
Notify the PerfTracker directly from libcore, without callbacks, since
Core.cpp already references g_perf_metrics explicitly. Also rename
Core::CallOnStateChangedCallbacks to NotifyStateChanged to better
reflect what it's doing.
2025-04-28 07:11:53 +03:00
97e696e524
CMake: Explicitely link udev if LIBUDEV_FOUND is set
2025-04-27 22:03:15 +02:00
2e6e7eddd1
DVDThread: Implement with WorkQueueThread and WaitableSPSCQueue.
2025-04-27 04:16:27 -05:00
891833d1a1
Externals: Update zstd from 1.4.4 to 1.5.7 and convert to submodule
2025-04-26 22:07:59 +02:00
8ee64a84c7
Merge pull request #13590 from tygyh/UCodes-Remove-redundant-qualifiers
...
UCodes: Remove redundant qualifiers
2025-04-26 16:23:27 +01:00
741ffc3114
Merge pull request #13514 from LillyJadeKatrin/retroachievements-failed-load-bug
...
Call AchievementManager CloseGame on load failures
2025-04-26 10:36:09 +02:00
3e5286c1a4
Merge pull request #13593 from Dentomologist/mainwindow_fix_use_after_free_during_dolphin_shutdown
...
MainWindow: Fix use-after-free during Dolphin shutdown
2025-04-26 09:06:06 +02:00
3a883f28d6
Config: Add [[nodiscard]] to AddConfigChangedCallback
...
Require callers of Config::AddConfigChangedCallback and
CPUThreadConfigCallback::AddConfigChangedCallback to handle the returned
ConfigChangedCallbackIDs to hopefully prevent future issues with
callbacks getting called after their associated objects have been
destroyed.
2025-04-25 16:04:12 -07:00
45b9def42c
VideoConfig: Remove ConfigChangedCallback on shutdown
2025-04-25 16:00:43 -07:00
d0dc8ae5e1
FreeLook: Remove ConfigChangedCallback on shutdown
2025-04-25 16:00:43 -07:00
9db4067957
UICommon: Merge ConfigChangedCallbacks
...
Use a single lambda as a callback which calls InitCustomPaths and
RefreshConfig instead of having separate callbacks for each of them.
This fixes the callback for InitCustomPaths not being removed on
shutdown; the callback for the lambda (previously for RefreshConfig) is
already removed in Shutdown().
2025-04-25 16:00:43 -07:00
8724daf44e
Settings: Remove ConfigChangedCallback on shutdown
2025-04-25 16:00:19 -07:00
9c40a7976b
AchievementManager: Remove ConfigChangedCallback on shutdown
...
Prevent SetHardcoreMode from being called after m_client is set to
nullptr. rc_client_set_hardcore_enabled() checks for nullptr so this
didn't cause any problems, but better not to rely on that.
Also prevents multiple SetHardcoreMode callbacks from piling up when
repeatedly toggling Config::RA_ENABLED.
2025-04-25 15:29:29 -07:00
e37a195192
MainWindow: Fix use-after-free during shutdown
...
Remove ConfigChangedCallback in MainWindow's destructor to prevent the
callback from accessing the destroyed MainWindow afterward.
After MainWindow is destroyed UICommon::Shutdown calls
LogManager::Shutdown which ultimately triggers any remaining callbacks.
This resulted in calling MainWindow::OnHardcoreChanged, which crashed in
debug builds and didn't have any obvious effect in release builds.
2025-04-25 15:29:29 -07:00
9868138c22
UCodes: Remove redundant qualifiers
2025-04-25 13:18:56 +02:00
805307f432
Merge pull request #13451 from vyuuui/numeric_labels
...
Add numeric label support to assembler
2025-04-25 01:56:43 +01:00
fe307a06c6
Merge pull request #13476 from jordan-woyak/sdl-header
...
InputCommon: Move SDL Device class into its own cpp/h files.
2025-04-25 01:49:52 +01:00
a95779add0
Merge pull request #13506 from JosJuice/android-time-played
...
Android: Show time played in game details
2025-04-25 01:43:53 +01:00
5523b9a01b
Merge pull request #13487 from Dentomologist/performancemetrics_fix_window_arrangement
...
PerformanceMetrics: Fix window arrangement
2025-04-25 01:40:58 +01:00
50026ab795
Merge pull request #13497 from hoogmin/modernize_fs_path
...
Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.
2025-04-25 01:38:35 +01:00
908094714b
Translation resources sync with Transifex
2025-04-24 23:38:09 +02:00
8fa725d5e4
Merge pull request #13573 from tygyh/DolphinTool-Make-parameter-constant
...
DolphinTool: Make parameter constant
2025-04-24 00:49:10 -04:00
fc0aafca3b
Merge pull request #13577 from tygyh/UCodes-Make-functions-static
...
UCodes: Make functions static
2025-04-24 00:48:46 -04:00
f675048768
Merge pull request #13578 from tygyh/Core/HW-Remove-redundant-empty-lambda-parameter-lists
...
Core/HW: Remove redundant empty lambda parameter lists
2025-04-24 00:48:28 -04:00
1cea31c75a
Merge pull request #13580 from LillyJadeKatrin/retroachievements-de-bug-debug
...
Fix debugger disabled bug
2025-04-23 23:28:19 -05:00
