Commit Graph

41154 Commits

Author SHA1 Message Date
3ee44bc565 Merge pull request #12416 from lioncash/expr
Externals/expr: Resolve -Wshadow warning
2023-12-16 05:10:06 +01:00
1daaaf8c26 Merge pull request #12425 from Naim2000/no-install-wad
Disable installing WADs and importing/exporting Wii saves while emulation is running
2023-12-16 05:09:26 +01:00
8f9102f5e5 Disable importing/exporting Wii saves while emulation is running 2023-12-15 19:48:06 -05:00
c159e4fb7a Merge pull request #12420 from OatmealDome/mtl-oob
MTLStateTracker: Increase fragment buffer array size to 3
2023-12-15 17:12:31 -05:00
efd0c5b07e Disable "Install WAD" while emulation is running
The "(Un)install to/from the NAND" options in the context menu for WAD files has always been disabled, don't know what happened to this one
2023-12-15 10:14:44 -05:00
370474a7cb Merge pull request #12422 from lioncash/global
WiiNetConfig: Eliminate usages of the global system accessor
2023-12-14 23:27:10 +01:00
f777a584c1 Merge pull request #12423 from lioncash/mios
IOS/MIOS: Eliminate global system accessors
2023-12-14 22:19:11 +00:00
e8f8cf0740 Merge pull request #12424 from lioncash/cpumanager
HW/CPU: Remove remaining global system accessors
2023-12-14 22:18:06 +00:00
27806d8d7b WiiNetConfig: Eliminate usages of the global system accessor
We can pass in the existing memory manager instance into the functions
instead of using the global accessor to access it.
2023-12-14 16:46:52 -05:00
1573b50bb3 HW/CPU: Remove remaining global system accessors
We can just pass in the m_system member instead.
2023-12-14 16:14:59 -05:00
5e9763c0fa IOS/MIOS: Eliminate global system accessors
We can pass the system instance through the EmulationKernel instance.
2023-12-14 16:05:59 -05:00
84ac561e46 Merge pull request #12421 from lioncash/fwd
WC24PatchEngine: Move IniFile header dependency into the cpp file
2023-12-14 21:21:59 +01:00
e34bfe0f72 Merge pull request #12419 from lioncash/conf
SysConf: std::move fs pointer in constructor
2023-12-14 20:47:27 +01:00
88431cfbca WC24PatchEngine: Make GetNetworkPatch() take a std::string_view
Makes it consistent with GetNetworkPatchByPayload()
2023-12-14 14:24:49 -05:00
fa70a8fd01 WC24PatchEngine: Make a few functions internally linked
These are only used within this translation unit, so we can remove the
IniFile dependency from the header.
2023-12-14 14:23:41 -05:00
438c48912b MTLStateTracker: Increase fragment buffer array size to 3 2023-12-14 14:17:07 -05:00
14abdab314 SysConf: std::move fs pointer in constructor
Just gets rid of a trivial atomic reference count increment and
decrement. Not a super heavyweight thing, but it is essentially "free"
to get rid of.
2023-12-14 14:01:17 -05:00
38752c91af Merge pull request #12418 from lioncash/fifo
DolphinQt/Host: Convert inclusion of Fifo.cpp to Fifo.h
2023-12-14 19:56:32 +01:00
15a37edfdb Merge pull request #12417 from lioncash/fallthrough
GameListModel: Remove fallthrough in data()
2023-12-14 19:55:53 +01:00
a20b4b5669 DolphinQt/Host: Convert inclusion of Fifo.cpp to Fifo.h
Quite a bizarre include.

Also resolves an indirect include (lol), since this TU was
including the system header that way.
2023-12-14 05:24:51 -05:00
6bbdf36a7b GameListModel: Remove fallthrough in data()
A harmless case of it, but this can still cause warnings.
2023-12-14 04:25:40 -05:00
5450b64951 Externals/expr: Resolve -Wshadow warning
We already made changes to this library, so we can also resolve the lone
shadowing warning within it.
2023-12-13 15:29:31 -05:00
fe014dac06 Merge pull request #12369 from t895/coil-cache
Android: Allow Coil image cache to use more memory
2023-12-13 21:11:59 +01:00
cdf4193e67 Merge pull request #12410 from lioncash/ignored
Common/Crypto: Resolve -Wignored-attributes warnings
2023-12-13 18:39:22 +00:00
dbc792a3ec Common/Crypto/SHA1: Resolve -Wignored-attributes warnings
See commit 417d1310d22b11d5d724625721b5fec09eda099a for an explanation
on why we do this.
2023-12-13 13:04:53 -05:00
bced5fac18 Common/Crypto/AES: Resolve -Wignored-attributes warnings
The alias for __m128i is typically something like:

typedef long long __m128i __attribute__((__vector_size__(16), __may_alias__));

and the part that ends up not getting preserved is the __may_alias__
attribute specifier.

So, in order to preserve that, we can just use a wrapper struct, so the
data type itself isn't being passed through the template.
2023-12-13 13:02:51 -05:00
b5d8498346 Merge pull request #12415 from lioncash/buffer
GBAWidget: Use std::span with SetVideoBuffer()
2023-12-13 15:57:40 +00:00
2e558d87ef Merge pull request #12413 from lioncash/doc
Externals/mbedtls: Disable -Wdocumentation related warnings
2023-12-13 15:54:36 +00:00
df922afdbb Merge pull request #12412 from lioncash/maybe
DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]]
2023-12-13 15:52:32 +00:00
52a144745d Merge pull request #12408 from lioncash/enums
General: Resolve -Wswitch warnings
2023-12-13 15:48:12 +00:00
dfb2783c25 GBAWidget: Add missing override specifiers 2023-12-13 10:12:18 -05:00
67a06d17b1 GBAWidget: Use std::span with SetVideoBuffer()
Previously we were always taking the buffer by value, even if it wasn't
being stored anywhere and only read from.

We can use a std::span for the same thing.
2023-12-13 10:11:52 -05:00
e27a4b5d72 Externals/mbedtls: Disable -Wdocumentation related warnings
It's actually kind of wild that these flags are enabled by default.
They produce an incredible amount of console output spam.

Let's remove them, especially since we've made other changes to this
CMakeLists.txt
2023-12-12 21:56:27 -05:00
3f06d32dcd Merge pull request #12411 from lioncash/build
Software/SWGfx: Default destructor in cpp file
2023-12-13 03:14:41 +01:00
ecd7fa4380 DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]]
This function is used in debug asserts, so in release builds this will
go unused and otherwise generate a warning
2023-12-12 21:02:15 -05:00
e06480a8ab Software/SWGfx: Default destructor in cpp file
Fixes a build failure with clang 17.

The destructor needs to be in the cpp file, since we have a forward
declared std::unique_ptr type as part of the class. So technically the
default inline destructor could invoke without seeing the full data type
definition.
2023-12-12 20:33:43 -05:00
7b57a4a37d Merge pull request #12407 from lioncash/unused2
CPUThreadConfigCallback: Mark static ID as [[maybe_unused]]
2023-12-12 23:38:47 +00:00
Mai
ea3033731d Merge pull request #12240 from iwubcode/material_asset_additional_properties
VideoCommon: add additional data types to material asset
2023-12-12 18:38:20 -05:00
Mai
022b0a00a2 Merge pull request #12406 from Tilka/xf_assert_msg
VideoCommon: add message to XF load assert
2023-12-12 18:36:28 -05:00
91f691296c IOS/Crypto/Sha: Handle ShaCommandUnknown in IOCtlV
Resolves a -Wswitch warning.
2023-12-12 17:42:36 -05:00
5b4b8dba61 VideoCommon: add message to XF load assert 2023-12-12 22:35:02 +00:00
c14b3539c9 CPUThreadConfigCallback: Mark static ID as [[maybe_unused]]
This isn't used, but is likely kept around so the one-timed execution of
a magic static is taken advantage of.
2023-12-12 17:30:37 -05:00
53a51a6f1b Merge pull request #12405 from lioncash/shadow2
General: Resolve lingering -Wshadow warnings
2023-12-12 22:20:23 +00:00
8c99198251 Merge pull request #12404 from lioncash/guard
CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows()
2023-12-12 22:18:26 +00:00
e883bbc57a ConfigFloatSlider: Resolve -Wshadow warning
Fairly straightforward variable shadowing.
2023-12-12 17:07:37 -05:00
79c84c98ed WC24PatchEngine: Resolve -Wshadow warning
While not captured, we're definitely shadowing the result variable
outside the lambda.
2023-12-12 17:03:42 -05:00
81d5370141 HLE_OS: Resolve -Wshadow warnings
We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
2023-12-12 17:01:32 -05:00
a812a1f938 LightingShaderGen: Resolve -Wshadow warnings
Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
2023-12-12 16:55:06 -05:00
6184ec655e Merge pull request #12403 from lioncash/uninit
PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning
2023-12-12 21:49:01 +00:00
995eb779fa Merge pull request #12402 from lioncash/shadow
AchievementManager: Resolve -Wshadow warnings
2023-12-12 21:42:21 +00:00