4885130799
Merge pull request #8194 from lioncash/common-msg
...
Common/MsgHandler: Tidy up interface and namespace code
2019-06-20 13:37:24 +02:00
baf02194c1
Merge pull request #8195 from lioncash/macro
...
VideoCommon/Statistics: Remove preprocessor macro
2019-06-20 13:29:27 +02:00
49adbcb9ce
Merge pull request #8206 from JosJuice/filesystem-include
...
Replace <experimental/filesystem> includes with <filesystem>
2019-06-20 12:20:03 +02:00
9c33f658a5
Simplify std::filesystem usage a little in Boot.cpp
...
If path_b is absolute, (path_a / path_b) will be the same as path_b.
2019-06-20 10:42:56 +02:00
fab15edb53
Replace <experimental/filesystem> includes with <filesystem>
...
https://bugs.dolphin-emu.org/issues/11770
2019-06-20 10:39:56 +02:00
4f1f55093f
Common/MsgHandler: Namespace code within the Common namespace
...
Closes another gap in the Common library where code isn't being
namespaced under it.
2019-06-19 16:03:55 -04:00
e7dd46a531
Common/MsgHandler: Brace if statement in MsgAlert
...
The condition travels more than one line, so the body should be braced.
While we're at it, make the comparison against nullptr explicit.
2019-06-19 16:03:33 -04:00
0eddf6dd8f
Common/MsgHandler: Use std::string's empty for emptiness checking in MsgAlert
...
Provides more straightforward code compared to negating a length check.
2019-06-19 16:00:16 -04:00
16afac9da9
Merge pull request #7927 from weihuoya/android-key-map
...
android: simplify config loading code
2019-06-19 11:51:00 +02:00
7dbfcb6870
Translation resources sync with Transifex
2019-06-18 15:13:50 +02:00
ff96dc0e6f
Merge pull request #8199 from lioncash/namespace
...
General: Use nested namespace specifiers where applicable
2019-06-18 11:33:08 +02:00
ac562279c3
Merge pull request #8201 from lioncash/guard
...
General: Add missing header guards
2019-06-18 07:29:08 +02:00
2714ba2b3d
UICommon: Add missing header guards
2019-06-17 18:39:44 -04:00
10f705f665
Core: Add missing header guards
2019-06-17 18:39:03 -04:00
c4def7c814
Common: Add missing header guards
2019-06-17 18:37:56 -04:00
72b04a353d
VideoBackends/Vulkan: Use nested namespace specifiers where applicable
2019-06-17 16:57:30 -04:00
ec60027f56
InputCommon: Use nested namespace specifiers where applicable
2019-06-17 16:51:41 -04:00
8e030a4a45
Common: Use nested namespace specifiers where applicable
2019-06-17 16:36:48 -04:00
32bacfa4bd
Core: Use nested namespace specifiers where applicable
...
Same thing, less visual noise.
2019-06-17 16:32:30 -04:00
5cafce3cc4
VideoCommon/Statistics: Amend imgui include
...
This is a library header, so it should be using '<' and '>' to delineate
that.
2019-06-17 02:37:02 -04:00
73710c0745
VideoCommon/Statistics: Remove unused header inclusions
...
These aren't used anywhere, so they can be removed.
2019-06-17 02:36:41 -04:00
6416fe336c
VideoCommon/Statistics: Replace memset with assignment in ResetFrame()
...
Same behavior, less code, and it doesn't require the type ThisFrame
itself to actually be a trivially-copyable type.
2019-06-17 02:27:36 -04:00
e981fa2073
VideoCommon/Statistics: Use ImGui::TextUnformatted() where applicable
...
ImGui::Text() assumes that the incoming text is intended to be
formatted, but we don't actually use it to format anything. We can be
explicit by using the relevant function.
This also has a plus of not needing to go through the formatter itself,
but the gains from that are probably minimal.
2019-06-17 02:27:26 -04:00
1c40fd8569
VideoCommon/Statistics: Replace DRAW_STAT macro with variadic lambda
...
We don't need to use the preprocessor here. We can just use a variadic
lambda function instead and forward the arguments to the formatting
function.
2019-06-17 02:26:25 -04:00
1968643297
Common/MsgHandler: Amend file-scope variable names
...
Makes them follow our coding style.
2019-06-16 23:37:03 -04:00
76b675e9f0
Common/MsgHandler: Make default message handler and translator's internally linked
...
Previously these functions were declared without the static specifier,
giving them external linkage, which isn't really ideal.
Instead, we can place these functions up by the relevant file-scope
variables and place them inside an anonymous namespace with said variables,
giving them internal linkage.
2019-06-16 23:37:03 -04:00
d1475f6d59
Common/MsgHandler: Convert type aliases over to using
...
Same thing, nicer to read.
2019-06-16 23:37:03 -04:00
027c17558f
Common/MsgHandler: Use fmt::print on non-Windows OSes
...
Provides the same behavior.
2019-06-16 23:37:00 -04:00
b3525ad774
Merge pull request #8186 from lioncash/view
...
{Common/SymbolDB, Core/HLE/HLE}: Make use of std::string_view where applicable
2019-06-16 16:20:02 +02:00
1550c098d3
Merge pull request #8187 from lioncash/disasm
...
GekkoDisassmbler: Amend erroneous formatting specifiers
2019-06-16 16:19:30 +02:00
2e3478a542
Merge pull request #8184 from Techjar/gameini-line-endings
...
GameSettings: Fix some line endings
2019-06-16 08:35:41 +02:00
9952dfe293
GekkoDisassmbler: Amend erroneous formatting specifiers
...
fmt diverges from printf in that '.' as a precision specifier may only
be used for floating-point values (makes sense, given it's indicating
precision after the decimal point).
2019-06-16 02:05:16 -04:00
a3046fe807
Core/HLE/HLE: Use std::string_view where applicable
...
Now that SymbolDB's querying functions accept std::string_view
instances, we can alter the Patch/UnPatch HLE functions to follow suit.
2019-06-16 01:20:12 -04:00
936aa5dbaa
Common/SymbolDB: Use std::string_view where applicable
...
These strings are only used for comparison against other strings, so a
string view can be used here.
2019-06-16 01:10:02 -04:00
8809087efd
GameSettings: Fix some line endings
2019-06-15 20:01:49 -04:00
9e1c38b6e1
Merge pull request #8182 from Techjar/imgui-reset-scissor
...
VideoCommon/RenderBase: Reset scissor rectangle after ImGui rendering
2019-06-15 21:29:07 +10:00
56c818b3d8
VideoCommon/RenderBase: Reset scissor rectangle after ImGui rendering
...
This fixes the problem where OBS game capture only grabs the region
inside an ImGui window whenever one is open, when using the OpenGL
backend. Shouldn't have any negative effects, as the scissor would've
been something completely arbitrary anyways.
This may affect other capture software that uses the same hooking
method, but I've only tested OBS.
2019-06-15 07:12:17 -04:00
c34388f75b
Merge pull request #8157 from JosJuice/rotational-latency
...
HW/DI: Emulate rotational latency
2019-06-14 12:36:36 -07:00
224f292224
Merge pull request #8130 from 8times9/more-text-fixes
...
Qt: Minor adjustments to graphics window descriptions
2019-06-14 12:30:27 -07:00
dd3b678451
Merge pull request #8178 from leoetlino/less-sleep
...
DiscordHandler: Don't delay shutdown by up to 2s
2019-06-14 12:28:13 -07:00
9cf6ba13df
Merge pull request #8177 from lioncash/fmt
...
Common: Use fmt where applicable
2019-06-14 12:22:16 -07:00
5b92d5076a
Common: Use fmt where applicable
...
Begins the transition to using fmt for string formatting where
applicable. Given fmt supports formatting std::string instances out of
the box, we can remove now-unnecessary calls to .c_str() and .data().
Note that this change does not touch the actual logging subsystem aside
from converting the final StringFromFormat call in the process over to
fmt::format. Given our logging system is heavily used throughout the
entire codebase, and converting that over will be quite a large change
by itself, this will be tackled near the end of the conversion process.
2019-06-14 15:04:09 -04:00
925afcae3b
VSProps: Add fmt directory to the list of additional includes
...
Allows fmt's headers to be visible to the Visual Studio projects.
2019-06-14 13:48:39 -04:00
f1dde9fee0
Qt: Minor adjustments to graphics window descriptions
2019-06-14 15:58:16 +02:00
59155b4d5e
Merge pull request #8150 from lioncash/kbd
...
IOS/USB_KBD: Minor cleanup
2019-06-14 15:25:10 +02:00
3b7a7ae2e7
Merge pull request #8155 from Techjar/dtm-get-origin
...
Core/Movie: Store PAD_GET_ORIGIN bit in ControllerState
2019-06-14 15:13:43 +02:00
e2d59abaa7
Merge pull request #8173 from lioncash/fmt
...
Externals: Add libfmt to externals
2019-06-14 14:47:22 +02:00
a6f4cb1647
DiscordHandler: Don't delay shutdown by up to 2s
...
Currently, it is possible for the DiscordHandler thread to be in the
middle of sleeping when Dolphin is closing. This results in a very
noticeable delay of up to 2 seconds that is unacceptable, especially
for people who don't use the Discord integration.
This fixes the issue by making the thread wait on an Event instead
and signalling it when shutting down.
2019-06-13 23:34:25 +02:00
79ea55c912
Merge pull request #8169 from lioncash/fallthrough
...
Core/GeckoCodeConfig: Use the [[fallthrough]] attribute in LoadCodes()
2019-06-13 13:36:32 +02:00
d52e69bab1
Common/CMakeLists: Link in fmt
...
While not currently used by common, this will become the case when the
logging system eventually transitions to it, among other things.
2019-06-10 15:26:46 -04:00
