b8695a57da
Fix incorrect clamping in SWRenderer.
...
A previous PR changed a whole lot of min/maxes to std::min/std::max
but made a mistake here and used a templated min which cast it's
arguments to unsigned instead of casting return value.
This resulted in glitchy artifacts in bright areas (See issue 7439)
I rewrote the code to use a proper clamping function so it's cleaner
to read.
2014-07-15 21:15:49 +12:00
3ac4e9f171
Merge pull request #608 from lioncash/compat
...
DolphinWX: Remove the use of some wx 1.0 compatibility function calls.
2014-07-14 01:56:09 -07:00
0c6eeaff05
Merge pull request #617 from Tilka/clang_bug
...
VideoCommon: fix clang version check
2014-07-14 01:55:31 -07:00
1464cfee13
Merge pull request #619 from lioncash/dpl2
...
Correct the function casing for DPL2Decoder
2014-07-14 10:21:20 +02:00
72b15be3be
Merge pull request #618 from lioncash/array-bounds
...
OGL: Correctly guard against array bounds of s_encodingPrograms
2014-07-14 10:20:28 +02:00
2c73472671
Correct the function casing for DPL2Decoder
...
Brings it more in-line with the rest of the codebase.
2014-07-14 03:34:40 -04:00
b66eb03b2f
OGL: Correctly guard against array bounds of s_encodingPrograms
...
s_encodingPrograms is defined as an array with a length of 64
NUM_ENCODING_PROGRAMS is also defined as 64.
However 64 is out of bounds, so we want to be comparing for "equal to or
greater than here"
2014-07-14 00:48:14 -04:00
d931637d63
DolphinWX: Remove two c_str calls in ISOProperties.cpp.
2014-07-13 23:43:41 -04:00
5c57a1ef4b
DolphinWX: Remove the use of some wx 1.0 compatibility functions.
...
Uses the recommended replacements.
2014-07-13 23:42:37 -04:00
dbc30c6c76
VideoCommon: make version check easier to read
2014-07-14 03:05:56 +02:00
dee6f226a3
Merge pull request #614 from Tilka/branch_prediction
...
[RFC] Common: add macros for assisting branch prediction
2014-07-14 03:00:08 +02:00
0be03252cc
VideoCommon: fix clang version check
...
That was... er... a typo!
2014-07-14 02:59:31 +02:00
3f67ec0d50
Merge pull request #611 from Tilka/clang_bug
...
VideoCommon: version-check clang for workaround
2014-07-13 17:52:54 -07:00
b6f3ae23bc
VideoCommon: version-check clang for workaround
...
The bug was fixed in clang 3.4.
2014-07-14 02:12:48 +02:00
5c701f6e82
Merge pull request #610 from lioncash/delete
...
DolphinWX: Remove the need for an explicit new/delete in ISOProperties
2014-07-14 01:55:11 +02:00
d398e9ef61
Common: add macros for assisting branch prediction
2014-07-14 01:52:14 +02:00
4d02675a8a
Merge pull request #616 from Armada651/shutdown
...
Shutdown the Core before other components.
2014-07-14 00:02:15 +02:00
aa2495205e
Shutdown the Core before other components.
...
Other components depend on the EmuThread being stopped.
2014-07-13 23:47:59 +02:00
0c95fcf918
Merge pull request #615 from delroth/libav-ubuntu
...
Change libav* autodetection to support framedumping on Ubuntu 14.04
2014-07-13 23:22:45 +02:00
8876ee120a
Change libav* autodetection to support framedumping on Ubuntu 14.04
...
Add an "ugly" workaround in the AVIDump code, but looking at other project this
seems to be the most common way to handle this API change.
2014-07-13 23:06:20 +02:00
3cabacde9d
Merge pull request #613 from lioncash/uninitialized
...
Core: Fix potential uninitialized var usage in WII_IPC_HLE_Device_usb
2014-07-13 14:03:02 -07:00
5e8ff31eac
Merge pull request #612 from lioncash/typedef
...
Core: Get rid of an unnecessary struct typedef in Boot.h.
2014-07-13 14:02:29 -07:00
fae0cf3698
Core: Fix potential uninitialized var usage in WII_IPC_HLE_Device_usb
...
If "if (ReadStoredLinkKey->read_all == 1)" is not true, then
num_keys_read would be used uninitialized.
2014-07-13 15:41:35 -04:00
9d3c0102fc
Core: Get rid of an unnecessary struct typedef in Boot.h.
2014-07-13 15:28:50 -04:00
5b649902dc
DolphinWX: Remove the need for an explicit new/delete in ISOProperties
...
Just use a normal constructor call and call Destroy to close the window.
2014-07-13 15:06:03 -04:00
16582a0459
Merge pull request #543 from RachelBryk/patches
...
Fix patches not being loaded when running real gc bios.
2014-07-13 06:25:39 +02:00
0563960dbc
Merge pull request #603 from lioncash/debugger-font
...
DolphinWX: Use non-deprecated flags for the monospace debugger font
2014-07-13 06:21:02 +02:00
12fa5ba8b4
Merge pull request #607 from Tilka/fix_warnings
...
Fix warnings unearthed by #579
2014-07-13 06:20:45 +02:00
0ccee6c87b
Fix warnings unearthed by #579
2014-07-13 02:16:51 +02:00
b2fa0ea3dc
Merge pull request #606 from Armada651/nogui
...
NoGUI: Add missing call to Core::Shutdown().
2014-07-13 01:12:24 +02:00
64801008a0
NoGUI: Add missing call to Core::Shutdown().
...
Fixes a crash when exiting the application.
2014-07-13 01:05:09 +02:00
99d4ab0b71
Merge pull request #602 from lioncash/lax-addr-box
...
DolphinWX: Allow short-hand searching in the code window
2014-07-12 00:47:16 +02:00
26f3867e20
DolphinWX: Allow short-hand searching in the code window
...
Lessens the restrictions on the searching in the code view.
Now typing out the full 8 digit hex number isn't needed. For example, you don't need to type 000000FF to go to FF, you just literally type FF.
Also makes JumpToAddress a boolean function to remain consistent with the DSP code view.
This will also change the address search box to have a red background if
either an invalid hex number is given, or if it's longer than 8 characters
2014-07-11 18:32:32 -04:00
dc526aa0a6
Merge pull request #600 from lioncash/enums
...
InputCommon: Use enums instead of defines within GCPadStatus.h
2014-07-11 18:20:52 -04:00
58c58d2f92
InputCommon: Use enums instead of defines within GCPadStatus.h
2014-07-11 17:18:11 -04:00
6885bac05f
DolphinWX: Use non-deprecated flags for the monospace debugger font
2014-07-11 13:11:11 -04:00
84bf097fb7
Merge pull request #579 from degasus/statics
...
Mark unexported global variables and functions as statics.
2014-07-11 16:37:42 +02:00
7e79806efc
remove unused globals
...
Also change globals into statics which are only used in one file
2014-07-11 16:10:20 +02:00
81ed17be53
avoid the extern keyword in .cpp files
2014-07-11 16:10:20 +02:00
6d3f249dcc
mark all local variables as static
2014-07-11 16:10:20 +02:00
9560ecdbec
CMake: warn on missing variable declarations
2014-07-11 16:07:23 +02:00
22e1aa5bb4
mark all local functions as static
2014-07-11 16:07:23 +02:00
3ff1c538ee
CMake: warn on missing declarations
2014-07-11 16:07:22 +02:00
326af097d9
Merge pull request #593 from neobrain/master
...
Use uniform capitalization in VideoConfigDiag
2014-07-11 13:26:23 +02:00
75c6575f37
Merge pull request #601 from lioncash/pad-struct
...
Change SPADStatus struct name to GCPadStatus
2014-07-11 06:20:33 +02:00
896d7e5685
Change SPADStatus struct name to GCPadStatus
...
Also get rid of the typedef, since this is unnecessary in C++
2014-07-10 22:02:38 -04:00
ef510a4f73
Merge pull request #594 from lioncash/another-clamp-removal
...
DolphinWX: Remove yet another clamp method
2014-07-11 02:48:27 +02:00
59a7939f18
Merge pull request #599 from lioncash/skips
...
DolphinWX: Remove unnecessary true within event Skip calls
2014-07-11 02:45:09 +02:00
6f9483d161
DolphinWX: Remove unnecessary true within event Skip calls
2014-07-10 20:39:26 -04:00
8059f80282
Merge pull request #598 from lioncash/casts
...
DolphinWX: Get rid of an unneccessary cast in CodeWindow
2014-07-11 02:32:40 +02:00