cb4ca7837a
TraversalClient: Prevent uninitialized values from occurring in MakeENetAddress
...
Previously, eaddr would only be partially initialized in the ipv6 case.
Even if there's no support for it, we may as well ensure that the
variable always has deterministic initialization.
While we're at it, we can make the parameter a const reference, given no
members are modified.
2021-01-20 12:24:05 -05:00
f0c6e696fd
TraversalProto: Convert typedefs into using aliases
...
Same behavior, more straightforward reading.
2021-01-20 12:24:05 -05:00
d48b5615ae
TraversalProto: Collapse version enum into a typed variable
...
Same behavior, less code.
2021-01-20 12:24:05 -05:00
d2ea94195c
TraversalProto: Convert TraversalPacketType into an enum class
...
Makes for strong typing and prevents namespace pollution.
2021-01-20 12:24:05 -05:00
2f0fb2056e
TraversalProto: Convert TraversalConnectFailedReason into an enum class
2021-01-20 12:24:05 -05:00
2021175809
TraversalClient: Convert state enum into an enum class
...
Prevents implicit conversions and prevents identifiers from polluting
the class scope.
2021-01-20 12:24:03 -05:00
ebf3b5faf4
Merge pull request #9451 from Sintendo/jit64boolxrw
...
Jit64: boolx - Eliminate read dependency
2021-01-19 15:40:43 +01:00
04ccd4cb80
Merge pull request #9446 from Dentomologist/convert_shifttype_to_enum_class
...
Arm64Emitter: Convert ShiftType to enum class
2021-01-18 05:26:22 -05:00
e3237661ec
Arm64Emitter: Convert ShiftType to enum class
2021-01-17 16:21:38 -08:00
8964612577
Jit64: boolx - Eliminate read dependency
...
For certain occurrences of nandx/norx, we declare a ReadWrite constraint
on the destination register, even though the value of the destination
register is irrelevant. This false dependency would force the RegCache
to generate a redundant MOV when the destination register wasn't already
assigned to a host register.
Example 1:
BF 00 00 00 00 mov edi,0
8B FE mov edi,esi
F7 D7 not edi
Example 2:
8B 7D 80 mov edi,dword ptr [rbp-80h]
8B FE mov edi,esi
F7 D7 not edi
2021-01-17 21:32:28 +01:00
e62fa1ea9f
Translation resources sync with Transifex
2021-01-17 18:55:27 +01:00
f383397c9c
Merge pull request #9447 from Dentomologist/convert_indextype_to_enum_class
...
Arm64Emitter: Convert IndexType to enum class
2021-01-17 12:23:53 +01:00
be74e35a0a
Merge pull request #9443 from Simonx22/update-gradle
...
Android: Update Gradle Plugin to 4.1.1
2021-01-16 06:55:10 -05:00
1476c10a87
Merge pull request #9445 from Simonx22/update-dependencies
...
Android: Update dependencies to the latest version
2021-01-16 06:54:45 -05:00
7d73da717c
Merge pull request #9444 from Simonx22/remove-duplicate-keys
...
gradle.properties: Remove duplicate property keys
2021-01-16 12:34:00 +01:00
70c54065ab
Arm64Emitter: Convert IndexType to enum class
2021-01-15 23:27:11 -08:00
5b98336e54
Android: Update dependencies to the latest version
2021-01-15 19:55:57 -05:00
8f2a2f3cda
Android: Update Gradle Plugin to 4.1.1
2021-01-15 19:53:08 -05:00
67bc2f9f76
gradle.properties: Remove duplicate property keys
2021-01-16 01:12:31 +01:00
aba179e4ba
Merge pull request #9385 from MerryMage/more-bmi2
...
Jit_Integer: Use SHLX, SHRX, SARX
2021-01-14 21:40:45 -05:00
0c2bc3582d
Merge pull request #9425 from Sintendo/jit64subfx
...
Jit64: subfx optimizations
2021-01-14 21:40:05 -05:00
8f67a1961f
Merge pull request #9442 from Stevoisiak/patch-1
...
Contributing.md: Code comment for do-while sample
2021-01-14 18:45:00 -05:00
c121dc3410
Contributing.md: Code comment for do-while sample
2021-01-14 13:58:55 -05:00
7fdd4afd9c
Merge pull request #9437 from Pokechu22/GX_CMD_UNKNOWN_METRICS
...
Use GX_CMD_UNKNOWN_METRICS instead of magic number 0x44
2021-01-12 04:09:54 -05:00
d55f9369c7
Use GX_CMD_UNKNOWN_METRICS instead of magic number 0x44
2021-01-11 12:41:04 -08:00
79a234eff7
Merge pull request #9435 from shuffle2/constexpr-error
...
BitUtils: cleanup constexpr usage for msvc clz
2021-01-10 14:58:20 -05:00
fc65f65891
BitUtils: cleanup constexpr usage for msvc clz
2021-01-10 10:06:30 -08:00
87debc6641
Merge pull request #9433 from shuffle2/constexpr-error
...
BitUtils: loosen clz to inline on msvc/arm64
2021-01-10 03:45:59 -05:00
65ecf1e43e
BitUtils: loosen clz to inline on msvc/arm64
2021-01-09 23:44:00 -08:00
a613c2a5e4
Merge pull request #9429 from Sintendo/jit64fixoverflow
...
Jit64: Fix FinalizeCarryOverflow XER[OV/SO]
2021-01-10 01:58:06 -05:00
59fa613020
Merge pull request #9431 from shuffle2/msvc-gdbstub
...
msbuild: enable USE_GDBSTUB
2021-01-10 01:56:46 -05:00
75e19a0c29
Merge pull request #9430 from shuffle2/vsupdate
...
Bump msvc version check and revert a msvc workaround
2021-01-10 01:46:28 -05:00
1f0e3371a3
Merge pull request #9432 from shuffle2/constexpr-error
...
BitUtils: initialize variables
2021-01-10 01:44:58 -05:00
f0a6244768
msbuild: enable USE_GDBSTUB
...
this does nothing about it actually being usable
2021-01-09 22:26:55 -08:00
1e5e5ea855
BitUtils: initialize variables
...
fixes C3615 on some msvc/cmake configs
2021-01-09 22:18:29 -08:00
cce275c16e
Revert "msvc: temporary workaround for C4789 false positive"
...
This reverts commit deb73d0167
2021-01-09 19:22:36 -08:00
c8316f70a4
msvc: bump _MSC_FULL_VER check to 192829335
2021-01-09 19:21:03 -08:00
305cd31bd9
Jit64: Fix FinalizeCarryOverflow XER[OV/SO]
...
FinalizeCarryOverflow didn't maintain XER[OV/SO] properly due to an
oversight. Here's the code it would generate:
0: 9c pushf
1: 80 65 3b fe and BYTE PTR [rbp+0x3b],0xfe
5: 71 04 jno b <jno>
7: c6 45 3b 03 mov BYTE PTR [rbp+0x3b],0x3
000000000000000b <jno>:
b: 9d popf
At first glance it seems reasonable. The host flags are carefully
preserved with PUSHF. The AND instruction clears XER[OV]. Next, an
conditional branch checks the host's overflow flag and, if needed, skips
over a MOV that sets XER[OV/SO]. Finally, host flags are restored with
POPF.
However, the AND instruction also clears the host's overflow flag. As a
result, the branch that follows it is always taken and the MOV is always
skipped. The end result is that XER[OV] is always cleared while XER[SO]
is left unchanged.
Putting POPF immediately after the AND would fix this, but we already
have GenerateOverflow doing it correctly (and without the PUSHF/POPF
shenanigans too). So let's just use that instead.
2021-01-09 22:52:18 +01:00
0776263c5e
Merge pull request #9428 from JosJuice/tv-folder-picker
...
Android: Use old folder picker on Android TV
2021-01-09 11:54:02 +01:00
116a5a79da
Android: Use old folder picker on Android TV
...
See the comment I added to the code. This is a rather serious
issue for Android TV users from what I've heard.
2021-01-08 16:27:33 +01:00
4cdcbb6ab2
Merge pull request #9308 from smurf3tte/re23_patch
...
Patches for Resident Evil 2/3 audio issues
2021-01-06 01:52:15 +01:00
0b1db65aa1
Merge pull request #9405 from Filoppi/patch-7
...
Rename "Use Fullscreen" setting to "Start in Fullscreen"
2021-01-06 01:44:46 +01:00
27013e8d18
Merge pull request #9300 from leoetlino/ncd-wd-fixes
...
IOS: WD and NCD fixes
2021-01-06 00:51:33 +01:00
df70077e6b
JitArm64: subfx - Special case a == b
2021-01-05 18:52:24 +01:00
eafb9de047
Merge pull request #9323 from waddlesplash/haiku
...
Rehabilitate Haiku support.
2021-01-05 16:09:43 +01:00
840ecfb32f
Merge pull request #9409 from AdmiralCurtiss/wii-save-import-tmd
...
Make WiiSave::Import() behave closer to the Wii System Menu's SD Card save copying.
2021-01-05 15:36:36 +01:00
e48377dfc6
Merge pull request #9404 from Filoppi/patch-5
...
Fix typos and code coding conventions
2021-01-05 15:33:43 +01:00
a5a6ef8512
Fix a couple of typos
...
[committer note: fixed commit message style]
2021-01-05 15:24:21 +01:00
0805b58302
DolphinQt: Remove some useless includes
...
[committer note: fixed commit message style]
2021-01-05 15:24:13 +01:00
3acd1726b9
Core: Fix variable naming conventions
...
[committer note: squashed two commits]
2021-01-05 15:23:40 +01:00
