piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 13:57:57 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
c85e0a2586
dolphin/Source/Core/VideoBackends/OGL
History
Lioncash c85e0a2586 FramebufferManagerBase: Return a std::pair from GetTargetSize 
Keeps associated data together. It also eliminates the possibility of out
parameters not being initialized properly. For example, consider the
following example:

-- some FramebufferManager implementation --

void FBMgrImpl::GetTargetSize(u32* width, u32* height) override
{
  // Do nothing
}

-- somewhere else where the function is used --

u32 width, height;
framebuffer_manager_instance->GetTargetSize(&width, &height);

if (texture_width != width) <-- Uninitialized variable usage
{
  ...
}

It makes it much more obvious to spot any initialization issues, because
it requires something to be returned, as opposed to allowing an
implementation to just not do anything.
2017-02-03 15:27:53 -05:00
..
BoundingBox.cpp DriverDetails: Make the bug identifiers humanly readable. 2016-10-31 15:02:08 +01:00
BoundingBox.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
CMakeLists.txt Move GL interface code out of the OpenGL video backend. 2015-09-22 00:36:45 +12:00
FramebufferManager.cpp FramebufferManagerBase: Return a std::pair from GetTargetSize 2017-02-03 15:27:53 -05:00
FramebufferManager.h FramebufferManagerBase: Return a std::pair from GetTargetSize 2017-02-03 15:27:53 -05:00
main.cpp OGL: Support full-resolution frame dumping 2016-11-28 21:54:56 +10:00
NativeVertexFormat.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
OGL.vcxproj VideoBackend: Get rid of a boolean global 2016-01-02 18:03:28 -05:00
OGL.vcxproj.filters VideoBackend: Get rid of a boolean global 2016-01-02 18:03:28 -05:00
PerfQuery.cpp Improve PerfQuery accuracy 2016-07-04 18:54:49 +10:00
PerfQuery.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
PostProcessing.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
PostProcessing.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
ProgramShaderCache.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
ProgramShaderCache.h VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
RasterFont.cpp Change RasterFont static const names 2016-12-24 11:58:07 -05:00
RasterFont.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Render.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
Render.h RenderBase: Forward declare EFBAccessType 2017-01-23 12:41:26 -05:00
SamplerCache.cpp Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
SamplerCache.h specify custom brace style to fix unions 2017-01-05 12:55:13 +01:00
StreamBuffer.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
StreamBuffer.h ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
TextureCache.cpp LightingShaderGen: Remove unnecessary includes 2017-02-01 01:06:00 -05:00
TextureCache.h ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
TextureConverter.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
TextureConverter.h LightingShaderGen: Remove unnecessary includes 2017-02-01 01:06:00 -05:00
VertexManager.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
VertexManager.h ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
VideoBackend.h VideoCommon: Drop GetConfigName. 2016-06-26 12:34:59 +02:00