piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 13:57:57 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
c85e0a2586
dolphin/Source/Core/VideoBackends/Vulkan
History
Lioncash c85e0a2586 FramebufferManagerBase: Return a std::pair from GetTargetSize 
Keeps associated data together. It also eliminates the possibility of out
parameters not being initialized properly. For example, consider the
following example:

-- some FramebufferManager implementation --

void FBMgrImpl::GetTargetSize(u32* width, u32* height) override
{
  // Do nothing
}

-- somewhere else where the function is used --

u32 width, height;
framebuffer_manager_instance->GetTargetSize(&width, &height);

if (texture_width != width) <-- Uninitialized variable usage
{
  ...
}

It makes it much more obvious to spot any initialization issues, because
it requires something to be returned, as opposed to allowing an
implementation to just not do anything.
2017-02-03 15:27:53 -05:00
..
BoundingBox.cpp Vulkan: Remove parameters/members of single-instance classes 2016-11-03 22:01:54 +10:00
BoundingBox.h Vulkan: Remove parameters/members of single-instance classes 2016-11-03 22:01:54 +10:00
CMakeLists.txt Vulkan: Combine PaletteTextureConverter and TextureEncoder classes 2016-12-04 20:10:13 +10:00
CommandBufferManager.cpp Vulkan: Use multiple command pools, one per frame 2016-11-15 00:40:15 +10:00
CommandBufferManager.h Vulkan: Use multiple command pools, one per frame 2016-11-15 00:40:15 +10:00
Constants.h specify custom brace style to fix unions 2017-01-05 12:55:13 +01:00
FramebufferManager.cpp FramebufferManagerBase: Return a std::pair from GetTargetSize 2017-02-03 15:27:53 -05:00
FramebufferManager.h FramebufferManagerBase: Return a std::pair from GetTargetSize 2017-02-03 15:27:53 -05:00
main.cpp LightingShaderGen: Remove unnecessary includes 2017-02-01 01:06:00 -05:00
ObjectCache.cpp LightingShaderGen: Remove unnecessary includes 2017-02-01 01:06:00 -05:00
ObjectCache.h Vulkan: Use an enumeration to index pipeline layouts 2016-12-04 20:10:13 +10:00
PerfQuery.cpp Vulkan: Remove parameters/members of single-instance classes 2016-11-03 22:01:54 +10:00
PerfQuery.h Vulkan: Remove parameters/members of single-instance classes 2016-11-03 22:01:54 +10:00
RasterFont.cpp Vulkan: Use an enumeration to index pipeline layouts 2016-12-04 20:10:13 +10:00
RasterFont.h
Renderer.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
Renderer.h VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
ShaderCompiler.cpp Vulkan: Support binding texel buffers in UtilityShaderDraw 2016-12-04 20:10:13 +10:00
ShaderCompiler.h Vulkan: Amend header includes 2016-09-30 23:26:03 -04:00
StagingBuffer.cpp Vulkan: Implement StagingTexture2D on top of StagingBuffer 2016-12-04 20:10:13 +10:00
StagingBuffer.h Vulkan: Implement StagingTexture2D on top of StagingBuffer 2016-12-04 20:10:13 +10:00
StagingTexture2D.cpp Vulkan: Implement StagingTexture2D on top of StagingBuffer 2016-12-04 20:10:13 +10:00
StagingTexture2D.h Vulkan: Implement StagingTexture2D on top of StagingBuffer 2016-12-04 20:10:13 +10:00
StateTracker.cpp VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
StateTracker.h LightingShaderGen: Remove unnecessary includes 2017-02-01 01:06:00 -05:00
StreamBuffer.cpp Vulkan: Fix incorrect handling of buffer wrap-around in StreamBuffer 2016-11-30 22:44:52 +10:00
StreamBuffer.h ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
SwapChain.cpp Merge pull request #4441 from stenzek/vulkan-max-image-count 2016-11-13 14:12:32 +01:00
SwapChain.h Vulkan: Fix vsync behavior when throttler is temp disabled 2016-10-03 19:11:48 +10:00
Texture2D.cpp Vulkan: Fix compilation on 32-bit targets 2016-10-03 19:11:47 +10:00
Texture2D.h Vulkan: Amend header includes 2016-09-30 23:26:03 -04:00
TextureCache.cpp TextureCache: Drop unused parameter in backend API. 2016-12-26 22:10:32 +01:00
TextureCache.h TextureCache: Drop unused parameter in backend API. 2016-12-26 22:10:32 +01:00
TextureConverter.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
TextureConverter.h ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
Util.cpp Common: Add alignment header 2016-12-06 20:33:53 +01:00
Util.h Common: Add alignment header 2016-12-06 20:33:53 +01:00
VertexFormat.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
VertexFormat.h Vulkan: Implement a pipeline UID cache 2016-11-28 21:21:53 +10:00
VertexManager.cpp ShaderGenCommon: Remove unnecessary includes 2017-02-01 12:19:55 -05:00
VertexManager.h VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
VideoBackend.h Vulkan: Refactor initialization to only use a single instance 2017-01-29 22:18:53 +10:00
Vulkan.vcxproj Vulkan: Combine PaletteTextureConverter and TextureEncoder classes 2016-12-04 20:10:13 +10:00
VulkanContext.cpp Vulkan: Refactor initialization to only use a single instance 2017-01-29 22:18:53 +10:00
VulkanContext.h Vulkan: Refactor initialization to only use a single instance 2017-01-29 22:18:53 +10:00
VulkanEntryPoints.inl
VulkanLoader.cpp
VulkanLoader.h