Merge pull request #11768 from Pokechu22/temporary-debug-command-line

Treat --debugger command line as a temporary setting
This commit is contained in:
Admiral H. Curtiss 2023-04-18 22:05:08 +02:00 committed by GitHub
commit a239af162d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions

View File

@ -257,8 +257,6 @@ int main(int argc, char* argv[])
MainWindow win{std::move(boot), static_cast<const char*>(options.get("movie"))};
Settings::Instance().SetCurrentUserStyle(Settings::Instance().GetCurrentUserStyle());
if (options.is_set("debugger"))
Settings::Instance().SetDebugModeEnabled(true);
win.Show();
#if defined(USE_ANALYTICS) && USE_ANALYTICS

View File

@ -465,9 +465,9 @@ void Settings::SetDebugModeEnabled(bool enabled)
{
Config::SetBaseOrCurrent(Config::MAIN_ENABLE_DEBUGGING, enabled);
emit DebugModeToggled(enabled);
if (enabled)
SetCodeVisible(true);
}
if (enabled)
SetCodeVisible(true);
}
bool Settings::IsDebugModeEnabled() const

View File

@ -22,7 +22,7 @@ class CommandLineConfigLayerLoader final : public Config::ConfigLayerLoader
{
public:
CommandLineConfigLayerLoader(const std::list<std::string>& args, const std::string& video_backend,
const std::string& audio_backend, bool batch)
const std::string& audio_backend, bool batch, bool debugger)
: ConfigLayerLoader(Config::LayerType::CommandLine)
{
if (!video_backend.empty())
@ -39,6 +39,9 @@ public:
if (batch)
m_values.emplace_back(Config::MAIN_RENDER_TO_MAIN.GetLocation(), ValueToString(false));
if (debugger)
m_values.emplace_back(Config::MAIN_ENABLE_DEBUGGING.GetLocation(), ValueToString(true));
// Arguments are in the format of <System>.<Section>.<Key>=Value
for (const auto& arg : args)
{
@ -134,7 +137,7 @@ static void AddConfigLayer(const optparse::Values& options)
Config::AddLayer(std::make_unique<CommandLineConfigLayerLoader>(
std::move(config_args), static_cast<const char*>(options.get("video_backend")),
static_cast<const char*>(options.get("audio_emulation")),
static_cast<bool>(options.get("batch"))));
static_cast<bool>(options.get("batch")), static_cast<bool>(options.get("debugger"))));
}
optparse::Values& ParseArguments(optparse::OptionParser* parser, int argc, char** argv)