6b52336bf7
AchievementManager: Fix unknown hash achievements deadlock
...
Within AchievementManager, CloseGame being called when LoadGame fails was causing m_queue.Cancel to be called within a lock when Cancel itself locks until it is empty, causing a deadlock. This is resolved by cancelling the queues outside of the lock when they are safe to wait for resolutions.
2025-05-03 22:51:07 -04:00
95ab6925b1
Merge pull request #13032 from parona-source/missing-cmake-include
...
Add missing cmake includes and remove unused cmake includes
2025-05-03 22:16:00 +02:00
a3c7423273
Remove unused cmake includes
...
Signed-off-by: Alfred Wingate <parona@protonmail.com >
2025-05-03 22:34:07 +03:00
e0d6ab73b8
Merge pull request #13508 from cristian64/non-autodismissable_menus
...
DolphinQt: Use non-autodismissable menus in menu bar.
2025-05-03 21:24:09 +02:00
2eeb2fd2b9
DolphinQt: Use non-autodismissable menus in menu bar.
...
A new class that derives from `QMenu` has been introduced. Menus of this
`NonAutodismissibleMenu` type will stay visible when a _checkable_
action is triggered.
This is convenient in menus that feature a series of check boxes that
toggle visibility of third components (e.g. the **List Columns** menu),
allowing the user to toggle several actions at once.
For now, the new type is used in the top menu bar.
2025-05-03 20:29:21 +02:00
db425ef3a1
Merge pull request #13445 from icup321/master
...
GameSettings: Various Nick games fixes
2025-05-03 20:16:13 +02:00
7774dccc9d
Merge pull request #13509 from Dentomologist/gamelist_fix_right_doubleclick_starting_games
...
GameList: Ignore non-left double-clicks
2025-05-03 20:15:11 +02:00
78465693ad
Merge pull request #13607 from LillyJadeKatrin/retroachievements-wiiware
...
RetroAchievements - Wii and WiiWare Support
2025-05-03 13:21:00 -04:00
c574b651aa
Merge pull request #13621 from JosJuice/android-remove-loaddefaultsettings
...
Android: Remove unused onSettingsFileNotFound and friends
2025-05-03 18:37:51 +02:00
dcc09906e5
Merge pull request #13622 from TryTwo/Settings_Bugfix
...
Settings: Bugfix. GFX settings getting set without user input
2025-05-03 18:36:36 +02:00
ffd78711be
Merge pull request #13618 from jordan-woyak/cubeb-logging
...
AudioCommon/CubebUtils: Fix logged file name.
2025-05-03 18:33:06 +02:00
a736d2ed5f
Merge pull request #13625 from Dentomologist/sdl_verify_touchpad_present_before_getting_input
...
SDL: Check if touchpad exists before getting input
2025-05-02 21:08:49 -05:00
c1d0a49f35
Settings: Bugfix. Fix some combo boxes setting a value without user input. Prevents initial Load from calling the connection to save value.
2025-05-02 18:21:45 -07:00
1aabae49ed
Settings: Bugfix. Remove Aspect Ratio combobox signal so it doesn't trigger a settings changed save.
2025-05-02 18:21:18 -07:00
77744169be
SDL: Check if touchpad exists before getting input
...
Verify a touchpad is present before polling it for input. Without this
check the Debug log is spammed with the message "error: Parameter
'touchpad' is invalid" if you have a controller without a touchpad.
One would think every touchpad supports at least 1 finger, but in case
there's some weird edge case check the finger count to be sure.
2025-05-02 17:21:42 -07:00
63572f15fc
Merge pull request #13620 from JosJuice/logmanager-cleanup
...
LogManager: Stop using manual memory management
2025-05-02 15:24:34 -05:00
c8be819711
LogManager: Stop using manual memory management
...
This fixes a memory leak that would occur when the Android frontend
calls LogManager::Init more than once in order to reload settings.
Note that the log window listener is now owned by LogManager instead of
by the frontend, making it consistent with the other log listeners.
2025-05-02 21:14:32 +02:00
6515807685
Merge pull request #13278 from JoshuaVandaele/saves-import
...
Implement importing multiple saves from an export folder
2025-05-02 15:40:27 +02:00
6129953666
Android: Remove unused onSettingsFileNotFound and friends
...
Old cruft from when the Android code was loading INI files manually.
We don't have any handling for failing to load settings anymore.
This change also updates related comments to reflect how things actually
work nowadays.
2025-05-02 14:25:01 +02:00
06826319c7
AudioCommon/CubebUtils: Fix logged file name.
2025-05-02 02:54:15 -05:00
b566e81644
Merge pull request #13596 from JosJuice/config-callback-locking
...
Config: Add locking for config changed callbacks
2025-05-02 08:49:22 +02:00
58d305f75c
Merge pull request #13616 from parona-source/musl-cstdint
...
UICommon: Include implicit header
2025-05-02 08:03:01 +02:00
0066119e41
Merge pull request #13617 from OatmealDome/coretiming-include
...
CoreTiming: Add missing SystemTimers.h include
2025-05-01 21:33:22 -04:00
fcb4b04168
Merge pull request #13613 from JosJuice/android-ldrtl-list-item-mapping-id
...
Android: Fix incorrect ID in layout-ldrtl/list_item_mapping.xml
2025-05-01 21:33:09 -04:00
da4f643b9f
Merge pull request #13611 from jordan-woyak/work-queue-thread-sp
...
Core and Vulkan: Change WorkQueueThread to WorkQueueThreadSP in a few places.
2025-05-01 21:32:16 -04:00
1963305bea
Merge pull request #13605 from JosJuice/android-cinit-native
...
Android: Don't call NativeLibrary methods during class init
2025-05-01 21:31:21 -04:00
757e6aba46
Merge pull request #13597 from JosJuice/hide-boot-bin
...
Hide DirectoryBlob boot.bin files from game list
2025-05-01 21:30:10 -04:00
42f656bf0f
Merge pull request #13595 from JosJuice/android-analytics-non-main
...
Android: Allow reporting start to analytics for non-main activity
2025-05-01 21:29:50 -04:00
2b568566ac
Merge pull request #13535 from m-brodschi/mihaib/fix-shutdown-crash
...
Core, VideoCommon: Fix crash at shutdown due to destructor order
2025-05-01 21:29:02 -04:00
539a3ed021
Merge pull request #13464 from jordan-woyak/dont-toggle-skip-frames
...
DolphinQt: Don't auto toggle GFX_HACK_SKIP_DUPLICATE_XFBS.
2025-05-01 21:28:13 -04:00
7222779e21
Merge pull request #13448 from Dentomologist/fix_unresponsive_hotkeys_when_moving_overlay_during_framestep
...
DolphinQt: Fix unresponsive hotkeys when clicking overlay during a framestep
2025-05-01 21:27:30 -04:00
1bd2570d97
Merge pull request #13239 from JosJuice/jitarm64-rlwimix-imm-mask
...
JitArm64: Use AArch64 imm masks in rlwimix slow case
2025-05-01 21:26:27 -04:00
0bd7cc64c9
CoreTiming: Add missing SystemTimers.h include
2025-05-01 19:13:02 -04:00
fbb54604b6
UICommon: Include implicit header
...
The header isn't implicitly included on musl.
Bug: https://bugs.gentoo.org/952952
Signed-off-by: Alfred Wingate <parona@protonmail.com >
2025-05-02 02:03:41 +03:00
e4525ca7ee
Merge pull request #13499 from jordan-woyak/frame-pacing-better-math
...
CoreTiming: Cleanups to avoid drift from cumulative rounding errors.
2025-05-01 15:58:33 -05:00
6c9138e5a6
Merge pull request #13592 from SuperSamus/kfp-single-core
...
GameINI: Enable Single Core for Kung Fu Panda and Shrek Forever After
2025-05-01 15:30:15 -04:00
5cfe3760a5
Include missing cmake includes
...
Otherwise it depends on other externals getting used and including them
before.
Signed-off-by: Alfred Wingate <parona@protonmail.com >
2025-05-01 19:52:53 +03:00
1633011d2a
Add achievement support for Wii and WiiWare
...
Add a method to detect console ID from an input file and instruct rcheevos to load as Gamecube or Wii accordingly. Also, hash .wads upon loading, to support achievements on WiiWare titles.
2025-05-01 07:54:12 -04:00
c796691d00
Remove filename option from achievement manager load
...
The only option that was currently using this was a pass-by-executable that wouldn't hash correctly anyways.
2025-05-01 07:54:12 -04:00
d64c20a67c
Android: Fix incorrect ID in layout-ldrtl/list_item_mapping.xml
...
Probably a copy-paste error from layout-ldrtl/list_item_setting.xml.
This error made it so a long setting name could overlap with the
checkbox next to it if Dolphin was running with right-to-left layout.
The incorrect ID was apparently also causing the app:lintVitalRelease
build task to fail. I guess we're not running that build task, because I
only heard of this from someone building Dolphin locally.
2025-05-01 11:57:07 +02:00
0ce929220d
Merge pull request #13553 from tygyh/Core/PowerPC/JitArm64-Replace-zeroes-in-boolean-context-with-false
...
JitArm64: Replace zeroes in boolean context with `false`
2025-05-01 10:11:44 +02:00
999c7aed98
Don't close achievements on games that don't hash
...
Minor bugfix necessary for future development; issue brought on by a conflict resolving wrong.
2025-05-01 00:17:20 -04:00
0987c03693
Merge pull request #13453 from tygyh/Use-underlying-method
...
DolphinQt/FIFO/FIFOAnalyzer: Use Common::ToUnderlying
2025-04-30 22:18:02 -05:00
e3f7486ca7
Merge pull request #13567 from tygyh/UnitTests-Rename-lambda-parameters-which-hide-previous-declarations
...
UnitTests: Rename lambda parameters which hide previous declarations
2025-04-30 22:07:35 -05:00
2e20e24136
Merge pull request #13587 from jordan-woyak/manual-value
...
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
2025-04-30 23:45:33 +02:00
cae82b62f8
Merge pull request #13610 from AdmiralCurtiss/zstd-asm-fix
...
Externals/zstd: Disable ASM for MSVC compiler in CMake
2025-04-30 23:31:55 +02:00
ec940e6a2e
VideoBackends/Vulkan: Use WorkQueueThreadSP for swap commands.
2025-04-30 16:29:35 -05:00
753fe5bed1
Core: Use WorkQueueThreadSP in NetKDRequestDevice.
2025-04-30 16:29:21 -05:00
c14101534f
Core: Use WorkQueueThreadSP in NetIPTopDevice.
2025-04-30 16:28:57 -05:00
bdb4fd8376
Core: Use WorkQueueThreadSP in DVDThread.
2025-04-30 16:17:21 -05:00
