piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 22:09:19 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
22,193 Commits 5 Branches 11 Tags 1.3 GiB
d4a529614a
Commit Graph

697 Commits

Author SHA1 Message Date
JosJuice
b1873264d7 WbfsBlob: Don't wrap file_entry in std::unique_ptr 
There doesn't seem to be any reason for doing it.
 2017-01-11 13:39:46 +01:00
JosJuice
0363be4320 WbfsBlob: Remove m_total_files 
std::vector already keeps track of this for us.
 2017-01-11 13:39:38 +01:00
JosJuice
5c02795af0 WbfsBlob: Only open each file once 
The first file used to be opened once by
CreateBlobReader and once inside WbfsFileReader.
 2017-01-11 13:33:27 +01:00
JosJuice
8d54bbc528 Don't create new IOFiles when creating a blob 
...except for WBFS, which is special because
it has the ability to open multiple files.
 2017-01-11 13:23:23 +01:00
JosJuice
d1ea00ed88 Only open file once when detecting blob type 2017-01-11 13:23:19 +01:00
Lioncash
a93861ab49 DiscScrubber: Don't take SFileInfo instances by value 
Avoids unnecessary copies.
 2017-01-04 20:12:49 -05:00
Lioncash
c52d1e735a DiscScrubber: Use an unsigned loop index in ParseDisc 
Prevents an implicit signed to unsigned conversion when assigning a
partition's group number.
 2017-01-04 20:03:12 -05:00
Lioncash
6ff21c48cb DiscScrubber: Correct printf specifiers 2017-01-04 19:56:39 -05:00
Lioncash
b1a2dec78a DiscScrubber: Convert a #define into a typed constant 2017-01-04 19:53:31 -05:00
Lioncash
5b1aae0cbf DiscScrubber: Make struct and variable names conformant to the coding style 2017-01-04 17:04:41 -05:00
Lioncash
4a9bc2340b DiscScrubber: Convert into a class 
Allows potential multiple scrubbers to run at once. Also gets rid of the
need to explicitly clean up resources.
 2017-01-04 16:06:21 -05:00
JosJuice
8e4a781974 VolumeDirectory: Modernize variable names 2016-12-26 11:45:22 +01:00
JosJuice
00aa2d37e9 VolumeDirectory: Don't use references inappropriately 
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
 2016-12-26 09:52:18 +01:00
Mat M
9c8e27e3bb Merge pull request #4558 from JosJuice/volumedirectory-fst-sort 
VolumeDirectory: Sort the FST
 2016-12-25 17:38:58 -05:00
JosJuice
3196f697bb VolumeDirectory: Use a range-based for loop in ComputeNameSize 2016-12-25 23:01:42 +01:00
JosJuice
f3987d13ea VolumeDirectory: Make m_totalNameSize a local variable 
After BuildFST finishes executing, it's never needed again.
 2016-12-25 22:57:14 +01:00
JosJuice
a502f069e8 VolumeDirectory: Sort the FST 
We can't rely on the OS returning files and directories
in a deterministic order, so we should sort them on our own
if we want VolumeDirectory to work for movies and netplay.
 2016-12-25 22:35:38 +01:00
JosJuice
9bd514ed1c Add TGC disc image compatibility 2016-12-18 18:57:36 +01:00
Léo Lam
31ccfffd38 Common: Add alignment header 
Gets rid of duplicated alignment code.
 2016-12-06 20:33:53 +01:00
Markus Wick
d5ca153c26 Merge pull request #4401 from JosJuice/rename-getuniqueid 
DiscIO/SConfig: Rename GetUniqueID to GetGameID
 2016-10-31 12:39:27 +01:00
JosJuice
1081497cad DiscIO/SConfig: Rename GetUniqueID to GetGameID 
We call this "game ID" everywhere else, and it's not
actually completely unique.
 2016-10-29 15:24:02 +02:00
JosJuice
d6731d34ef Remove VolumeCreator logs 
These logs are very rarely useful and cause the issue
https://bugs.dolphin-emu.org/issues/9767
 2016-10-29 13:08:24 +02:00
Lioncash
d9eb7c4e80 NANDContentLoader: Add IOFile forward declaration 
This would previously fail to compile when included in files that do not
include FileUtil.h due to lack of a type declaration.

This moves the constructor and destructor into the cpp file in order to
satisfy the requirements of unique_ptr construction and deletion. That is,
unique_ptr requires a concrete type at the point of construction and
destruction. If the constructor or destructor is left in the header, then
at the point of construction or destruction, IOFile will still be
considered an incomplete type, as unique_ptr's deleter will still only be
able to see the forward declaration, which it can't use.
 2016-10-14 20:27:22 -04:00
shuffle2
cc66f0336f Merge pull request #3963 from JosJuice/banner-loaded-failure 
VolumeGC: Set m_banner_loaded when banner loading fails
 2016-10-03 06:33:52 -07:00
Mat M
ccfc081697 Merge pull request #4245 from aldelaro5/logs-levels-changes 
Lots of Logs levels changes (also enable INFO level in every build)
 2016-10-02 16:51:44 -04:00
aldelaro5
f0aa9b3751 Reorganise a ton of logs level 
Most of this commits changes performance decreasing logs from info to debug and also cleans up innacurate levels.
 2016-10-01 15:50:28 -04:00
Lioncash
61b977c914 WiiWad: Make WiiWAD constructor explicit 2016-09-25 18:04:11 -04:00
Lioncash
7de0d51345 WiiWad: Move static implementation details to cpp file 
These functions don't actually depend on any state from the class
instance, so they don't really belong in the header, and are just
an implementation detail.
 2016-09-25 18:04:04 -04:00
Lioncash
144c23dead Filesystem: Return strings from GetFileName without the const qualifier 
This is mostly pointless and can inhibit move construction
 2016-09-18 12:56:25 -04:00
Lioncash
5aeedcd27c NANDContentLoader: Remove unnecessary trailing semicolons 2016-09-14 20:12:25 -04:00
Lioncash
b43a26b90c NANDContentLoader: Remove virtual specifier from CNANDContentLoader destructor 
This class is marked final, so there's no need to declare it as virtual.
 2016-09-14 19:45:52 -04:00
Lioncash
3196bf5392 NANDContentLoader: Specify constructors as explicit where applicable 
Prevents implicit conversion.
 2016-09-14 19:44:44 -04:00
Lioncash
89c65be703 NANDContentLoader: Delay vector construction until needed in Get() 
No need to construct the vector right off the bat.
 2016-09-14 19:41:41 -04:00
Lioncash
b1ffa74043 NANDContentLoader: Make CNANDContentData's Get function return by non-const value 
const specifiers like this are practically pointless and can inhibit move construction.
 2016-09-14 19:15:31 -04:00
EmptyChaos
eccec3c6d3 DiscIO: Fix NAND Memory Leak 
CNANDContentData is a base class with a non-virtual destructor so
derived classes don't get destroyed causing them to leak resources.
 2016-09-14 15:54:05 +10:00
Léo Lam
c1184957a5 Run clang-format on missed files 
`clang-format`s files that lint missed because of the bug. Fortunately,
not much.
 2016-08-11 21:14:39 +02:00
JosJuice
0a15aaaa12 Move DiscIO enums to a new file 
At first there weren't many enums in Volume.h, but the number has been
growing, and I'm planning to add one more for regions. To not make
Volume.h too large, and to avoid needing to include Volume.h in code
that doesn't use volume objects, I'm moving the enums to a new file.
I'm also turning them into enum classes while I'm at it.
 2016-07-13 17:29:27 +02:00
Pierre Bourdon
f4d2626d2b Merge pull request #4005 from EmptyChaos/blockcache-bug 
SectorReader: Minor cache bias bug
 2016-07-13 12:11:19 +02:00
JosJuice
53e7eed28d DiscScrubber: Fix issue 9356 2016-07-11 11:46:15 +02:00
EmptyChaos
9036b9d8e8 SectorReader: Fix cache line bias 
Minor bug where SectorReader::GetEmptyCacheLine was biased towards
the first hit.
 2016-07-09 02:27:35 +10:00
JosJuice
31226b8503 DiscScrubber: Replace unused blocks with 0x00 instead of 0xFF 2016-07-07 11:51:58 +02:00
JosJuice
202c9d58cd VolumeGC: Set m_banner_loaded when banner loading fails 
If banner loading fails once, it will very likely fail again.
Setting m_banner_loaded to true when banner loading fails
prevents LoadBannerFile from wasting time if it's called again.
Banner loading requires loading the file system, which takes a
noticeable amount of time, so this matters.
 2016-06-28 18:05:44 +02:00
JosJuice
1878605d77 Undo some comment formatting changes from b5104a7 2016-06-25 18:07:10 +02:00
Rukai
b5104a79f1 GCVolume: supports reading all opening.bnr information 
DQT2: Game properties dialog contains info tab giving information about the selected iso.
 2016-06-26 00:03:59 +10:00
Pierre Bourdon
3570c7f03a Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Pierre Bourdon
c4240692b6 SectorReader: Fix reading the last block of the disc. 
Regression from PR #3795.
 2016-05-29 18:26:04 +02:00
EmptyChaos
97d570f0c9 DriveReader: Fix View > Show Drives 
DriveReader::m_size was never initialized which was indirectly
causing CGameListCtrl to crash Dolphin when it tried to insert a
character at a negative index in a string.

Reading one sector at a time is very inefficient and appears to
be causing timing issues during boot so SectorReader has been
enhanced to support batching.

SectorReader has been given a working cache system.
 2016-04-26 21:24:08 +10:00
BhaaL
a449ef4e11 properly open/close the file to avoid rapid open/close cycles 
ES_OPENCONTENT and ES_CLOSECONTENT now call Open and Close respectively,
as the old code did.
 2016-03-20 13:10:51 +01:00
BhaaL
8a6d9e1e0b hide the distinction between WAD and File from ES 
instead, leave all the management with the NANDContentLoader.

for file data (directly on the NAND), this opens the file on-demand and
returns the requested chunk when asked for it.
for on-the-fly decrypted WAD data, we just keep the decoded buffer in
memory, like we've done before - except that we don't give away any objects
we don't want to.
 2016-03-20 13:10:50 +01:00
BhaaL
1e28d06f26 fix some style inconsistencies that drove me nuts 2016-03-20 13:10:47 +01:00