piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 13:57:57 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
8c82607c95
dolphin/Source/Core/VideoBackends/Software
History
Lioncash c85e0a2586 FramebufferManagerBase: Return a std::pair from GetTargetSize 
Keeps associated data together. It also eliminates the possibility of out
parameters not being initialized properly. For example, consider the
following example:

-- some FramebufferManager implementation --

void FBMgrImpl::GetTargetSize(u32* width, u32* height) override
{
  // Do nothing
}

-- somewhere else where the function is used --

u32 width, height;
framebuffer_manager_instance->GetTargetSize(&width, &height);

if (texture_width != width) <-- Uninitialized variable usage
{
  ...
}

It makes it much more obvious to spot any initialization issues, because
it requires something to be returned, as opposed to allowing an
implementation to just not do anything.
2017-02-03 15:27:53 -05:00
..
Clipper.cpp Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
Clipper.h Clipper: const correctness 2016-09-22 21:01:49 -04:00
CMakeLists.txt VideoSW: Use more VideoCommon 2016-01-06 22:10:29 +01:00
DebugUtil.cpp Remove Frameskip 2016-10-08 11:49:51 -05:00
DebugUtil.h DebugUtils: const correctness 2016-09-22 21:05:17 -04:00
EfbCopy.cpp Remove Frameskip 2016-10-08 11:49:51 -05:00
EfbCopy.h Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
EfbInterface.cpp Reorganise a ton of logs level 2016-10-01 15:50:28 -04:00
EfbInterface.h EfbInterface: Change out parameters on getters to return by value 2016-09-21 20:56:44 -04:00
NativeVertexFormat.h Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
Rasterizer.cpp Rasterizer: const correctness 2016-09-22 20:39:28 -04:00
Rasterizer.h Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
SetupUnit.cpp Fix building with PCH disabled. 2016-10-11 14:25:14 -05:00
SetupUnit.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Software.vcxproj VideoSW: Use more VideoCommon 2016-01-06 22:10:29 +01:00
SWmain.cpp FramebufferManagerBase: Return a std::pair from GetTargetSize 2017-02-03 15:27:53 -05:00
SWOGLWindow.cpp VideoSW: Fix GL ES shader. 2017-01-07 12:32:15 +01:00
SWOGLWindow.h SWOGLWindow: const correctness for ShowImage 2016-09-21 12:54:22 -04:00
SWRenderer.cpp RenderBase: Forward declare EFBAccessType 2017-01-23 12:41:26 -05:00
SWRenderer.h AVIDump: Move CoreTiming into caller. 2016-10-10 12:03:18 +02:00
SWVertexLoader.cpp VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
SWVertexLoader.h VideoCommon: Make dst_alpha state implicit. 2017-01-04 20:02:31 +01:00
Tev.cpp VideoSoftware: Fix unsigned overflow bug in fog 2016-09-02 10:12:44 +12:00
Tev.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
TextureEncoder.cpp VideoSoftware: Don't drop least significant bit of 5-bit blue channels 2016-12-14 23:56:06 +10:00
TextureEncoder.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
TextureSampler.cpp Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
TextureSampler.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
TransformUnit.cpp Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
TransformUnit.h Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Vec3.h Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00
VideoBackend.h Software: Clean out unnecessary includes/fwd decls 2016-09-24 05:28:00 -04:00