piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 05:47:56 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
28,775 Commits 5 Branches 11 Tags 1.3 GiB
059880bb16
Commit Graph

1235 Commits

Author SHA1 Message Date
spycrab
a19e5b3f7a Qt/InfoWidget: Don't show banner details if no data is present 2018-05-25 03:23:56 +02:00
spycrab
a0b2cdbffc Qt/GameList: Fix bold header when selecting a game 2018-05-24 13:48:14 +02:00
spycrab
a60bba37cd
Merge pull request #6953 from spycrab/qt_map_unresponsive 
Qt/MappingButton: Fix window becoming unresponsive after mapping
 2018-05-24 01:21:53 +02:00
spycrab
574c609709 Qt/Mapping: Add option to map all devices at once 2018-05-24 01:13:47 +02:00
spycrab
c39f00194d Qt/MappingButton: Fix window becoming unresponsive after mapping 2018-05-24 00:01:05 +02:00
Léo Lam
c99ac40700 Port FS, SD and dump path to onion config 
This ports the Wii filesystem root, Wii SD card path and dump path
settings to the new config system (OnionConfig).

My initial plan was to wait until DolphinWX was removed before porting
most of the Main (Core, DSP, General) settings to onion config, but
I've decided to submit a small part of those changes to fix
[issue 10566](https://bugs.dolphin-emu.org/issues/10566).

Removes the need to manually set the FileUtil path in the UI frontends
and gets rid of some more members that don't really belong in SConfig.

Also fixes a bug which would cause the dump path not to get created
after change.
 2018-05-23 16:07:18 +02:00
JosJuice
58743416bb Make the support for unencrypted Wii disc images less broken 
These disc images are only used on dev units and not retail units.
There are two important differences compared to normal Wii disc images:

- The data starts 0x8000 bytes into each partition instead of 0x20000
- The data of a partition is stored unencrypted and contains no hashes

Our old implementation was just guesswork and doesn't work at all.
According to testing by GerbilSoft, this commit's implementation
is able to read and extract files in the filesystem correctly,
but the tested game still isn't able to boot. (It's thanks to their
info about unencrypted disc images that I was able to make this commit.)
 2018-05-23 08:40:37 +02:00
spycrab
51410b7672
Merge pull request #6946 from spycrab/qt_rob 
Qt/RunOnObject: Fix no result being returned
 2018-05-23 01:15:59 +02:00
spycrab
1f3df1811b Qt/RunOnObject: Fix no result being returned 2018-05-23 01:07:08 +02:00
spycrab
94e97d47a0 Qt/FIFOPlayer: Implement Analyzer 2018-05-22 23:51:01 +02:00
Sepalani
8fa898fe9a DebugInterface: MemoryPatches methods added 
CodeView: Restore instruction added
 2018-05-22 10:31:31 +04:00
spycrab
6747543502 Qt: Fix crash on game start 2018-05-22 04:37:08 +02:00
spycrab
54f85c3320 Qt/FIFOPlayerWindow: Properly reset ranges 2018-05-22 01:32:26 +02:00
riking
268b424843 QtUtils/RunOnObject: Make safe under object destruction 
Co-Authored-By: cancel <cancel@cancel.fm>
 2018-05-21 15:49:19 -07:00
spycrab
f31f1a08fb
Merge pull request #6927 from spycrab/qt_mpwnd_size 
Qt/MappingWindow: Make sure widgets don't need scrolling by default
 2018-05-21 21:16:32 +02:00
flatulation
93e0a2e52a Qt: Implement post-processing shader configuration window 2018-05-21 16:09:04 +01:00
spycrab
9eb3bce520 Qt/MappingWindow: Make sure widgets don't need scrolling by default 2018-05-21 15:47:09 +02:00
Lioncash
437c954b60 DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype 
Tidies up the interface a little (and prevents a linker error from
occurring in the future, should it ever have been called).
 2018-05-20 16:42:13 -04:00
spycrab
8af8c58eb9
Merge pull request #6917 from spycrab/qt_mpbtn_size 
Qt/MappingButton: Enforce more consistent size
 2018-05-20 21:27:41 +02:00
spycrab
0e8aa213a3 Qt/MappingButton: Enforce more consistent size 2018-05-20 21:20:45 +02:00
spycrab
b4f1c489a3 Qt/MappingIndicator: Center trigger labels 2018-05-20 21:16:14 +02:00
spycrab
b0b14853c4 Qt/MappingIndicator: Improve render quality 2018-05-20 17:50:26 +02:00
Léo Lam
0706add584
Merge pull request #6699 from 404-Name-Not-Found/alphabetize-gecko-qt 
Adds a toggleable function for sorting the gecko codes alphabetically to the gecko code menu
 2018-05-20 11:13:38 +02:00
Justin Futrell
c7f0c7484d GeckoCodeWidget: Add a Sort button 2018-05-20 11:05:11 +02:00
Léo Lam
464bfb073e
Merge pull request #6912 from spycrab/qt_jit_widget 
Qt/JITWidget: Add object name
 2018-05-20 10:44:21 +02:00
spycrab
f7b188c7b4 Qt/JITWidget: Add object name 2018-05-20 03:58:54 +02:00
spycrab
ef803613d0 Qt/SoftwareRendererWidget: Fix backend info not getting updated properly 2018-05-19 23:28:23 +02:00
spycrab
49f8d5aefb Qt/AdvancedWidget: Save progressive scan when toggled 2018-05-19 20:59:30 +02:00
spycrab
bc504d9f84 Qt/GraphicsWindow: Show display name in title 2018-05-19 17:44:22 +02:00
spycrab
7a8b2da55e Qt/ToolBar: Fix checkbox not properly reflecting toolbar visibility 2018-05-19 15:50:21 +02:00
Léo Lam
d399b0f59e
Merge pull request #6900 from lioncash/buffer 
PPCAnalyst: Make CodeBuffer an alias for std::vector<CodeOp>
 2018-05-19 12:10:19 +02:00
spycrab
bf0fbdbc52
Merge pull request #6893 from spycrab/qt_gc_checkboxes 
Qt/GameConfigWidget: Fix checkboxes not being saved properly
 2018-05-19 03:34:24 +02:00
spycrab
adcaf3c581
Merge pull request #6887 from spycrab/qt_slider_accuracy 
Qt/HacksWidget: Fix slider not showing overridden settings
 2018-05-19 03:00:34 +02:00
Lioncash
3a8a67025e PPCAnalyst: Make CodeBuffer an alias for std::vector<CodeOp> 
This class effectively acted as a "discount vector", that would simply
allocate memory and then delete it in the destructor when it goes out of
scope.

We can just use a std::vector directly to reduce this boilerplate.
 2018-05-18 17:19:45 -04:00
spycrab
5e3d7dc162 Qt/HacksWidget: Fix slider not showing overridden settings 2018-05-18 20:19:21 +02:00
spycrab
707b966496 Qt/GameConfigWidget: Fix checkboxes not being saved properly 2018-05-18 20:15:14 +02:00
spycrab
57f9928c49
Merge pull request #6891 from spycrab/qt_fs_glitch 
Qt/HotkeyScheduler: Fix toggle fullscreen glitches
 2018-05-18 19:30:42 +02:00
Léo Lam
49c9c1ee40
Merge pull request #6853 from aldelaro5/qt-debugger-hotkey-fixes 
Qt debugger hotkey fixes
 2018-05-18 19:06:17 +02:00
spycrab
cc55817ec9 Qt/HotkeyScheduler: Fix toggle fullscreen glitches 2018-05-18 09:40:03 +02:00
spycrab
eef2092854 Qt/D3D: Fix render widget size not being restored properly 2018-05-18 09:27:56 +02:00
spycrab
9bdf7c4b5a
Merge pull request #6890 from aldelaro5/qt-fix-random-windows 
Qt/CheatWarningWidget: properly supply a parent for the widget
 2018-05-18 08:08:42 +02:00
aldelaro5
6dd5a3a866
Qt/CheatWarningWidget: properly supply a parent for the widget 
Because it wasn't parented properly, it would show briefly the widget in its own window when creating an ARCodeWidget or a GeckoCodeWidget which would occur when accessing the game properties page or when the state changes to pause/running.
 2018-05-18 01:31:43 -04:00
Tilka
bdce441bb9
Merge pull request #6889 from lioncash/mmu 
PowerPC: Move MMU-specifics from PowerPC.h to MMU.h
 2018-05-18 02:28:13 +01:00
Tilka
cbc85d928b
Merge pull request #6860 from Zexaron/qt_generalwidget_remove_wrong_description 
Qt/GeneralWidget remove unnecesary description wiring
 2018-05-18 02:24:08 +01:00
Lioncash
b9aad3310e PowerPC: Move MMU-specifics from PowerPC.h to MMU.h 
PowerPC.h at this point is pretty much a general glob of stuff, and it's
unfortunate, since it means pulling in a lot of unrelated header
dependencies and a bunch of other things that don't need to be seen by
things that just want to read memory.

Breaking this out into its own header keeps all the MMU-related stuff
together and also limits the amount of header dependencies being
included (the primary motivation for this being the former reason).
 2018-05-17 19:18:55 -04:00
Tilka
e67f2dcada
Merge pull request #6888 from lioncash/qt-override 
DolphinQt2: Minor changes
 2018-05-17 22:16:23 +01:00
Lioncash
c1f92d304f DolphinQt2/NetPlay/GameListDialog: Make GetSelectedUniqueID() const qualified 
Given this member function returns a const reference to a QString, it
can be made const qualified, since it doesn't modify internal state.
 2018-05-17 16:35:48 -04:00
Tilka
6ef7578321
Merge pull request #6886 from lioncash/dqt 
DolphinQt2/Settings: Remove unimplemented IsInDevelopmentWarningEnabled() prototype
 2018-05-17 21:33:37 +01:00
Lioncash
c98a8b59d5 DolphinQt2/NetPlay: Mark constructors explicit where applicable 2018-05-17 16:33:05 -04:00
Lioncash
dfa1126946 DolphinQt2: Add missing override specifiers 2018-05-17 16:28:35 -04:00
Lioncash
3d8cca2682 DolphinQt2/Settings: Remove unimplemented IsInDevelopmentWarningEnabled() prototype 
The "in development" dialog was removed quite a while ago, so this is
just a leftover remnant that must have been missed during said removal.
 2018-05-17 16:09:56 -04:00
spycrab
0b5d29a347
Merge pull request #6883 from spycrab/qt_fix_hk_state 
Qt/HotkeyScheduler: Fix state loading
 2018-05-17 22:08:57 +02:00
spycrab
72a66d3fbb
Merge pull request #6877 from aldelaro5/qt-debugger-load-symbols 
Qt/debugger: properly update when we load the symbols on boot
 2018-05-17 21:41:55 +02:00
aldelaro5
65d2a6c590
Qt/debugger: properly update when we load the symbols on boot 
This host event is still useful because the emu thread will load the symbols on boot if required.
 2018-05-17 15:33:47 -04:00
spycrab
f25213139d Qt/HotkeyScheduler: Fix state loading 2018-05-17 20:27:14 +02:00
aldelaro5
0a2357f044
Qt/hotkeys: do not show the debugging tab if the debugger is disabled 2018-05-17 07:22:34 -04:00
aldelaro5
3d9d516bd3
Qt: do not toggle the screensaver when pausing or playing 
This fixes 2 crashes with the pause function.  One is when spamming the pause hotkey and the other is to press pause and step hotkeys at the same time.  It does disable the screensaver getting disabled when the emulator is running, but paused, though, a better solution would have to be done without introducing these crashes.
 2018-05-17 07:14:44 -04:00
master0fdisaster
2a9283ee3d
Fix "Show Input Display" 2018-05-16 21:07:15 +02:00
spycrab
b203024a26
Merge pull request #6868 from aldelaro5/qt-debugger-fix-updatediasm 
Qt/Debugger: Use QApplication::instance() as the connection context in Host_UpdateDisasmDialog()
 2018-05-16 18:54:21 +02:00
Léo Lam
47fd8c6eff
Merge pull request #6855 from aldelaro5/qt-render-min-width 
Qt: allow to resize the render widget however wanted on render to main
 2018-05-16 14:11:51 +02:00
Léo Lam
4de2c5040d
Merge pull request #6867 from jackoalan/code-view-bg 
Qt/CodeViewWidget: Dynamic background dimming for dark themes
 2018-05-16 14:08:02 +02:00
Léo Lam
9335400f65
Merge pull request #6862 from aldelaro5/qt-unify-pause-play 
Qt: make the pause play button only one button
 2018-05-16 14:07:35 +02:00
Jack Andersen
d14f6e9ee6 Qt/CodeViewWidget: Dynamic background dimming for dark themes 2018-05-15 18:59:40 -10:00
aldelaro5
33ed5b2e99
Qt/Debugger: Use QApplication::instance() as the connection context in Host_UpdateDisasmDialog() 
Because running on the host instance doesn't actually allow to fire the event.  This fix a regression where stepping would not udpate the GUI at all.
 2018-05-16 00:42:35 -04:00
aldelaro5
bc43f45119
Qt: make the pause play button only one button 
This is to avoid several issue with using 2 actions and switching between them.  This commit will instead have one action get his property changed on pause and play.
 2018-05-15 23:37:50 -04:00
spycrab
6c09ce3d95 Qt: Use proper signals 2018-05-15 20:13:12 +02:00
spycrab
79533ef789 Qt/PathPane: Disable "Remove" button when not applicable 2018-05-15 20:13:12 +02:00
spycrab
40e6abad09 Qt/AudioPane: Improve layout 2018-05-15 20:13:12 +02:00
spycrab
54d81ed13a Qt/SettingsWindow: Wrap tabs in scrollareas 2018-05-15 20:13:12 +02:00
spycrab
b9bd4ecbcb Qt/Host: Fix random crashes when exiting fullscreen 2018-05-15 18:22:26 +02:00
spycrab
e922f91cc3 Qt/GeneralWidget: Restore the adapter properly 2018-05-14 21:16:20 +02:00
Léo Lam
159f6115e2
Merge pull request #6851 from lioncash/usage 
BreakpointWidget: Move variables closer to usage sites in OnLoad()
 2018-05-14 19:18:05 +02:00
Léo Lam
b5761f9dc7
Merge pull request #6852 from lioncash/code 
CodeViewWidget: Minor changes
 2018-05-14 19:17:35 +02:00
Léo Lam
5b15060127
Merge pull request #6857 from spycrab/qt_minor_win 
Qt: Minor window fixes
 2018-05-14 19:11:56 +02:00
Zexaron
ff971b1a6f Qt/GeneralWidget remove unnecesary description wiring 2018-05-14 18:18:18 +02:00
spycrab
ca5dc25694
Merge pull request #6858 from lioncash/capture 
DolphinQt2: Resolve unused lambda capture warnings
 2018-05-14 16:47:55 +02:00
spycrab
26b1048975
Merge pull request #6850 from lioncash/moc 
DolphinQt2: Add missing Q_OBJECT macro to all QObject-related classes missing it
 2018-05-14 16:29:53 +02:00
Lioncash
e2543ea801
DolphinQt2: Resolve unused lambda capture warnings 
Resolves -Wunused-lambda-capture warnings.
 2018-05-14 10:11:47 -04:00
spycrab
7e9bf12246 Qt: Minor window fixes 
* Remove some more "What's this?" buttons
* Add some missing titles
 2018-05-14 11:10:04 +02:00
aldelaro5
6f2d8fad8f
Qt: allow to resize the render widget however wanted on render to main 2018-05-14 00:43:31 -04:00
Lioncash
d7a3ce26de CodeViewWidget: Get rid of magic values in OnInsertBLR() and OnInsertNOP() 
A call like ReplaceAddress(address, 0) is pretty ambiguous; so is
ReplaceAddress(address, false), so use an enum class that tells people
straight-up what the replacer is.

This also gets rid of the really weird naming, where if 'blr' is true,
we'd be replacing the address with a NOP, rather than an actual BLR
instruction, so we invert that so it actually makes sense. There's no
actual bug fixed here though, considering the OnInsert functions
specified the correct values; it's literally just weird naming.
 2018-05-13 18:33:51 -04:00
Lioncash
bbc0aee5ea CodeViewWidget: Replaces usages of QString::fromStdString with QStringLiteral where applicable 
There's no need to construct a std::string here, when there's no dynamic
elements to the text.
 2018-05-13 18:11:09 -04:00
Lioncash
644bbb29f3 CodeViewWidget: Remove unnecessary includes 2018-05-13 18:06:37 -04:00
Lioncash
7032863569 CodeViewWidget: Remove unnecessary QColor constructions 
QBrush also accepts regular GlobalColor values as well.
 2018-05-13 18:01:10 -04:00
Lioncash
a0a0295f9d BreakpointWidget: Move variables closer to usage sites in OnLoad() 
In the early-out case, we now don't end up constructing two vectors
that aren't even used. It also keeps relevant code together.
 2018-05-13 17:56:03 -04:00
aldelaro5
2c861e75f5
Qt/debugger: only consider debugger hotkeys if debugging is enabled 2018-05-13 17:39:44 -04:00
Léo Lam
345838d517
Merge pull request #6842 from spycrab/qt_map_apply 
Qt/Mapping: Fix mapping changes not being applied instantly
 2018-05-13 23:34:18 +02:00
Lioncash
222fe58e25 DolphinQt2: Add missing Q_OBJECT macro to all QObject-related classes missing it 
Without this macro, if any signals or slots were attempted to be used,
they wouldn't work; neither would various other features of the Qt
meta-object system. This can also lead to weird behavior in other
circumstances. Qt's documentation specifically states:

"Therefore, we strongly recommend that all subclasses of QObject use the
Q_OBJECT macro regardless of whether or not they actually use signals,
slots, and properties."

on its page for "The Meta-Object System", which can be seen here:
https://doc.qt.io/qt-5/metaobjects.html

Let's opt for "always do the right thing", and keep the code extensible
for the future and not have random things blow up on us.
 2018-05-13 17:33:32 -04:00
spycrab
c7a0b6c9f8
Merge pull request #6831 from spycrab/qt_memcard_fixes 
Qt/GCMemcardManager: Fix multiple issues
 2018-05-13 23:14:46 +02:00
JosJuice
74d561085c
Merge pull request #6848 from lioncash/guard 
DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator
 2018-05-13 22:21:40 +02:00
Lioncash
b03c433543 DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator 
Prevents potential double inclusion issues from ever happening.
 2018-05-13 16:11:30 -04:00
Léo Lam
8f44423a5b
Merge pull request #6846 from spycrab/qt_native_sep 
Qt: Use native dir separators
 2018-05-13 22:10:10 +02:00
Léo Lam
6c38e4b47f
Merge pull request #6847 from lioncash/fs-include 
FilesystemWidget: Replace DiscIO includes with forward declarations
 2018-05-13 22:08:09 +02:00
Lioncash
d1d584d16b FilesystemWidget: Replace DiscIO includes with forward declarations 
Avoids the need to use an ugly ifdef around a header, and also resolves
an indirect inclusion in PropertiesDialog.
 2018-05-13 16:01:16 -04:00
Léo Lam
1fe92b8be7
Merge pull request #6845 from lioncash/patch-dlg 
NewPatchDialog/PatchesWidget: Use forward declarations where applicable
 2018-05-13 22:00:43 +02:00
Léo Lam
07b57c7ac6
Merge pull request #6843 from lioncash/patch 
PatchEngine: Minor changes
 2018-05-13 21:58:55 +02:00
spycrab
5673a64612 Qt: Use native dir separators 2018-05-13 21:51:38 +02:00
Lioncash
0995cfef6a PatchEngine: Make PatchType an enum class 
Makes the enum strongly typed. A function for retrieving the string
representation of the enum is also added, which allows hiding the array
that contains all of the strings from view (i.e. we operate on the API,
not the exposed internals). This also allows us to bounds check any
querying for the strings.
 2018-05-13 15:46:51 -04:00
Lioncash
799e4154be PatchesWidget: Convert Core and UICommon includes into forward declarations 
Avoids propagating inclusions through UI headers
 2018-05-13 15:38:58 -04:00
Lioncash
df3f9af6d7 NewPatchDialog: Convert PatchEngine include into a forward declaration 
Avoids needing to include Core headers in UI-related header files,
preventing unintentional propagation.
 2018-05-13 15:34:46 -04:00
spycrab
9e2f9db94c Qt/Mapping: Fix mapping changes not being applied instantly 2018-05-13 21:21:31 +02:00
spycrab
b9ae157835 Qt/RenderWidget: Fix render-to-main focus 2018-05-13 21:08:34 +02:00
Lioncash
a166cf2481 PatchEngine: Give Patch and PatchEntry default member initializers 
Avoids potentially using the values uninitialized. While we're at it,
also drop the prefixed underscores from one of the constructors.
 2018-05-13 15:08:32 -04:00
Lioncash
15a522fe9b DolphinQt2/NewPatchDialog: Remove unused <iostream> include 
Including <iostream> causes a static constructor to be injected into the
translation unit, even if the everything from the header itself is
unused.
 2018-05-13 14:04:22 -04:00
Léo Lam
9d1157f695
Merge pull request #6839 from spycrab/qt_start_top 
Qt: Fix render widget not being on top when using -n / -e
 2018-05-13 18:20:00 +02:00
Léo Lam
e828c243f3
Merge pull request #6836 from leoetlino/wii-save-cleanup 
WiiSave: (not so) Minor cleanup
 2018-05-13 18:19:22 +02:00
spycrab
17795a615b
Merge pull request #6838 from spycrab/qt_map_save 
Qt/ControllersWindow: Fix changing devices while emulation is running
 2018-05-13 18:17:13 +02:00
Léo Lam
80b3d7ccb8 WiiSave: Allow users to specify export directory 
Export and ExportAll now open a directory picker (that defaults to the
previous default directory, i.e. the Dolphin user dir).

Also removes the need to return the path in the export functions since
the user knows which path they chose.
 2018-05-13 17:42:56 +02:00
Léo Lam
a93d816c28 WiiSave: Move dialogs to UI code 
This moves the result dialogs to DolphinQt2, since WiiSave should not
really be responsible for interacting with the user as a simple
Wii save importing/exporting class.

This also fixes Wii save import/export showing result dialogs twice,
once from WiiSave, and another time from DolphinQt2.
 2018-05-13 17:42:55 +02:00
Léo Lam
41c4486c65 WiiSave: Clean up constructors 
Move the import/export operation into separate functions, as it doesn't
really make sense for the constructor to do *everything*, including
printing success/failure message boxes.

The existing constructor was split into two: one that takes a path,
and another taking a title ID. This makes it more obvious what is
actually done when a path/TID is passed and also clarifies what
parameters should be passed. (No more magic 0 or "" value.)
 2018-05-13 17:42:55 +02:00
Léo Lam
00bc1f28f2 Rename CWiiSaveCrypted to WiiSave 2018-05-13 17:42:55 +02:00
spycrab
fa77e09239 Qt: Fix render widget not being on top when using -n / -e 2018-05-13 17:32:29 +02:00
spycrab
2ca75ae05a Qt/ControllersWindow: Fix changing devices while emulation is running 2018-05-13 14:04:39 +02:00
Léo Lam
99dff10d43
Merge pull request #6837 from spycrab/qt_position 
Qt/RenderWidget: Save position and size using QSettings
 2018-05-13 11:47:04 +02:00
spycrab
760a0be28a Qt/RenderWidget: Save position and size using QSettings 2018-05-13 01:27:56 +02:00
Léo Lam
66c1b909c2
Merge pull request #6765 from aldelaro5/Qt-debugger-fixes 
Qt/debugger: fix a bunch of things
 2018-05-13 01:20:11 +02:00
Léo Lam
ad5a69be79
Merge pull request #6826 from spycrab/qt_netplay2 
Qt/NetPlayDialog: Improve player list
 2018-05-13 01:17:51 +02:00
aldelaro5
5c688b2d2b
Qt/debugger: Don't update the symbols list unnecessarily 
It only needs to be updated when we changes the symbols, not every time the code widget updates and it does take a while to update them so this fixes some delay when updating the code window.
 2018-05-12 19:15:26 -04:00
aldelaro5
be6b4edb0c
Qt/debugger: only resize the columns of the code view once per update 
Putting the columns to resizeToContents causes way too much resizes per updates which can cause severe lags and even crashes.  This only does one resize at the end of the columns.
 2018-05-12 19:15:26 -04:00
aldelaro5
daf8df951c
Qt/Debugger: Update the register view properly on pause and step 2018-05-12 19:15:24 -04:00
aldelaro5
7388774f10
Qt/debugger: fix some possible crashes and inconsistencies in the breakpoint widget 
One, which was also possible in Wx is to add an mbp after the core stopped which shouldn't be possible as it needs to add the memcheck on the core thread which wouldn't be running.  The other fix is Qt specific where it doesn't clear the breakpoints on stop.
 2018-05-12 19:06:18 -04:00
aldelaro5
09792fde70
Qt/debugger: recenter the code widget when selecting a breakpoint 2018-05-12 19:04:37 -04:00
aldelaro5
53803c1fca
Qt/debugger: fix minor issues in the breakpointWidget 
The items were editable while you cannot edit the breakpoints at the moment and the last breakpoint deleted would not cause the row count to change to 0.
 2018-05-12 19:04:37 -04:00
aldelaro5
238c801711
Qt/debugger: properly updates when we break 
The Host_UpdateDisasmDialog was unimplemented in Qt which is required to get updates when we break.  Additionally, this updates the debugger toolbar.
 2018-05-12 19:04:30 -04:00
Léo Lam
f91b729b61
Merge pull request #6825 from leoetlino/onion-types 
Config: Fix implicit conversions/enum config types
 2018-05-12 21:59:43 +02:00
aldelaro5
70ca98c8e7
Qt/debugger: change how the selected line in the code widget looks 
Not only it colors the entire row instead of just the address, but if the pc is the selected row, the pc color will overwrite the selection, this is done via a stylesheet.
 2018-05-12 15:47:16 -04:00
aldelaro5
9a2dd470a0
Qt/debugger: change some colors logic in the codeWidget 
This commit makes the colors hardcoded except when there is no symbols loaded, in which case, it uses the theme colors, except for the PC which is hardcoded to black on green.  This makes a compromise between making use of the corespoinding theme color and the text being nicely readable on all themes.
 2018-05-12 15:47:16 -04:00
aldelaro5
9bacb3cb26
Qt/RegisterView: fix minor aesthetic issues 
This aligns the values to the right since It looks odd to be aligned to the left with any format other than hexadecimal.  It also sets the font tot he debugger font and disallow selection as a previous commit made the selection pointless since it now relies on the current item.
 2018-05-12 15:47:16 -04:00
aldelaro5
8c23335be3
Qt/RegisterView: fix the context menu not working correctly 
It seemed impossible to SELECT an item, however, when right clicking, the CURRENT item is set to the appropriate cell, this commit makes the view use thta cell instead of the first selected one.
 2018-05-12 15:47:16 -04:00
aldelaro5
f9a6f97dca
Make the dock widgets (logger and debugger) be on the left by default 
Like they were in Wx.
 2018-05-12 15:47:16 -04:00
spycrab
229c92d0bf Qt/GCMemcardManager: Properly perform actions and do error checking 2018-05-12 21:38:30 +02:00
spycrab
8b3358e208 Qt/GCMemcardManager: Fix broken export message 2018-05-12 20:35:16 +02:00
spycrab
bf0ee9f702
Merge pull request #6822 from spycrab/qt_fix_defaults 
Qt: Fix mapping defaults
 2018-05-12 19:22:53 +02:00
spycrab
d8a95834f3 Qt/NetPlayDialog: Improve player list 2018-05-12 18:25:38 +02:00
Léo Lam
6763a3fce1 Config: Add support for enums 
This makes it possible to use enums as the config type.
Default values are now clearer and there's no need for casts
when calling Config::Get/Set anymore.

In order to add support for enums, the common code was updated to
handle enums by using the underlying type when loading/saving settings.

A copy constructor is also provided for conversions from
`ConfigInfo<Enum>` to `ConfigInfo<underlying_type<Enum>>`
so that enum settings can still easily work with code that doesn't care
about the actual enum values (like Graphics{Choice,Radio} in DolphinQt2
which only treat the setting as an integer).
 2018-05-12 18:10:26 +02:00
Léo Lam
7dca7c237e Config: Fix template deduction for implicit conversions 
This excludes the second argument from template deduction.

Otherwise, it is required to manually cast the second argument to
the ConfigInfo type (because implicit conversions won't work).

e.g. to set the value for a ConfigInfo<std::string> from a string
literal, you'd need a ugly `std::string("yourstring")`.
 2018-05-12 14:30:18 +02:00
Léo Lam
e78235943e
Merge pull request #6823 from spycrab/qt_reset_hotkey 
Qt: Implement "Reset" hotkey
 2018-05-12 13:12:24 +02:00
Léo Lam
a712cfe339
Merge pull request #6624 from spycrab/qt_dbg_jit 
Qt/Debugger: Implement "JIT" widget
 2018-05-12 13:02:47 +02:00
spycrab
226b6888d6 Qt: Implement "Reset" hotkey 2018-05-12 03:56:10 +02:00
spycrab
c118af73c2 Qt: Fix mapping defaults 2018-05-12 01:31:42 +02:00
spycrab
0abce1419b Qt/NetPlayDialog: Fix broken IP label 2018-05-11 21:22:57 +02:00
spycrab
76f6c7523f
Merge pull request #6810 from spycrab/qt_fix_hotkey_conf 
Qt/MappingButton: Fix occasionally broken indicator
 2018-05-11 21:05:43 +02:00
spycrab
49d2f6f15a Qt/HotkeyScheduler: Use onion config 2018-05-11 20:47:30 +02:00
spycrab
16e2ac9257 VideoCommon/RenderBase: Refactor OSD messages 2018-05-11 18:24:08 +02:00
spycrab
1dfcffcce2 Qt/Debugger: Implement "JIT" widget 2018-05-11 18:10:35 +02:00
spycrab
082573bd6b
Merge pull request #6808 from spycrab/qt_hotkey_osd 
Qt/HotkeyScheduler: Show OSD information
 2018-05-11 15:51:37 +02:00
spycrab
66190ae4d6 Qt/HotkeyScheduler: Show OSD information 2018-05-11 12:49:20 +02:00
spycrab
242fadc76f Qt/MappingButton: Fix occasionally broken indicator 2018-05-11 12:37:48 +02:00
Léo Lam
5071973a51
Merge pull request #6805 from spycrab/qt_netplay 
Qt/NetPlayDialog: Multiple improvements
 2018-05-11 10:39:53 +02:00
Lioncash
6d0cab3743 DolphinQt2/MemoryWidget: Use QString's toUtf8() where applicable instead of toStdString() 
Avoids needing to iterate and append the characters in one case. This also
alters the function to not need to construct a temporary std::string
(QString's toUtf8() is sufficient, as QByteArray exposes iterators).

toStdString() is equivalent to retrieving the QString's underlying
QByteArray via calling QString's .toUtf8 member function and then
calling .toStdString() on the result of it (discarding the QByteArray
afterwords), so this just trims off an unnecessary step in the process.

This is also somewhat more indicative of the conversions going on:
toStdString() converts the underlying character sequence of a
QString to UTF-8, not strict ASCII, so we're really using a superset of
ASCII.
 2018-05-10 22:10:45 -04:00
spycrab
3cca051850
Merge pull request #6806 from spycrab/qt_iowindow_crash 
Qt/IOWindow: Fix crash
 2018-05-10 21:18:48 +02:00
spycrab
146979f67e Qt/IOWindow: Fix crash 2018-05-10 21:12:19 +02:00
spycrab
09449e2bca Qt/NetPlayDialog: Use QToolButton instead of a QComboBox 2018-05-10 20:51:12 +02:00
spycrab
26bee93943 Qt/NetPlayDialog: Show more friendly interface names 2018-05-10 20:51:12 +02:00
spycrab
0141ce9305 Qt/NetPlayDialog: Restore window geometry 2018-05-10 20:51:12 +02:00
spycrab
0ee7bddd4f Qt/NetPlayDialog: Add splitter 2018-05-10 20:51:12 +02:00
spycrab
6ea2b2e7e5 Qt/NetPlayDialog: Fix duplicate messages 2018-05-10 20:51:12 +02:00
spycrab
7550389c72 Qt/NetPlayDialog: Escape HTML in chat 2018-05-10 19:19:09 +02:00
spycrab
893c5e694e Qt/NetPlayDialog: Use more readable colors 2018-05-10 19:14:19 +02:00
spycrab
6e9d0ff6de
Merge pull request #6802 from Neui/qt-remember-main-window-position-and-size 
Qt: Save and restore main window size and position
 2018-05-10 18:26:38 +02:00
Neui
f6d5896bc7 Qt: Save and restore main window size and position 2018-05-10 18:19:17 +02:00
spycrab
273579bc32 Qt/Win32: Fix font weight calculation 2018-05-10 14:01:55 +02:00
spycrab
fd1ea63383
Merge pull request #6788 from spycrab/qt_gconf_fixes 
Qt/GraphicsWindow: Fix multiple issues
 2018-05-10 12:16:19 +02:00
spycrab
be007b436c Qt/GraphicsWindow: Fix software renderer breaking layout 2018-05-10 12:08:23 +02:00
spycrab
074a17482b Qt/GraphicsWindow: Refresh settings on construction 2018-05-10 12:08:23 +02:00
spycrab
6a34f2b47c Qt/GeneralWidget: Fix "No" response to backend switch confirmation 2018-05-10 12:08:23 +02:00
spycrab
b7b6b5162c Qt/GeneralWidget: Refresh backend settings properly 2018-05-10 12:08:23 +02:00
spycrab
e380df2e59 Qt/MainWindow: Call Config::Save last before destruction 2018-05-10 12:05:58 +02:00
spycrab
18c7d295c9 Qt/FilesystemWidget: Fix moc compilation 2018-05-09 22:35:27 +02:00
spycrab
5cd02f0853
Merge pull request #6793 from spycrab/qt_hotkeys 
Qt: Implement missing hotkeys
 2018-05-09 13:28:53 +02:00
spycrab
ce32447726 Qt: Implement missing hotkeys 2018-05-09 08:27:04 +02:00
Starsam80
ebf6149ad4
Qt: Use addLayout instead of addItem when adding layouts 2018-05-08 17:54:47 -06:00
spycrab
2852959811 Qt: Restore render widget size and position 2018-05-08 16:03:13 +02:00
Léo Lam
a9987588eb
Merge pull request #6768 from spycrab/qt_stylesheet 
Qt: Allow custom stylesheets
 2018-05-08 15:20:19 +02:00
spycrab
0170052f5d Qt: Allow custom stylesheets 2018-05-08 15:07:50 +02:00
Anthony
1ec3a4db6c
Merge pull request #6763 from spycrab/qt_fix_prog 
Qt/AdvancedWidget: Fix "Enable Progressive Scan"
 2018-05-07 09:59:32 -07:00
Anthony
46236920ef
Merge pull request #6767 from spycrab/qt_whatsthis2 
Qt: Make dialogues more consistent
 2018-05-07 09:58:15 -07:00
Anthony
8212b6e9cf
Merge pull request #6769 from spycrab/qt_fix_netplay 
Qt/NetPlay: Fix crashes on start
 2018-05-07 09:57:02 -07:00
Anthony
ecd9b94415
Merge pull request #6779 from spycrab/qt_trans_fix 
Qt/WrapInScrollArea: Only use transparency on Windows
 2018-05-07 09:56:47 -07:00
Anthony
e62c26c34b
Merge pull request #6781 from spycrab/qt_rtm_addendum 
Qt/GeneralWidget: Various fixes
 2018-05-07 09:53:20 -07:00
spycrab
8f9bc2f3e4 Qt: Implement custom fullscreen resolution support 2018-05-07 18:38:59 +02:00
spycrab
a2448c5b66 Qt/GeneralWidget: Various fixes 2018-05-07 17:50:03 +02:00
Markus Wick
6f0ad84a5e
Merge pull request #6764 from spycrab/qt_fix_rtm 
Qt: Fix "Render To Main"
 2018-05-07 17:33:56 +02:00
spycrab
fc069f709e Qt/WrapInScrollArea: Only use transparency on Windows 2018-05-07 17:23:03 +02:00
Markus Wick
6ec1e742ae
Merge pull request #6773 from lioncash/fpscr 
PowerPC: Make the PowerPCState's fpscr member variable a UReg_FPSCR instance
 2018-05-07 08:47:14 +02:00
Lioncash
cb5926c1ca PowerPC: Make the PowerPCState's fpscr member variable a UReg_FPSCR instance 
Gets rid of the need to cast the actual member to access information without bit shifts and masking.
 2018-05-06 18:46:52 -04:00
Léo Lam
7dcab20bfa Qt: Disable 'uninstall' action if title is not installed 2018-05-06 21:01:44 +02:00
spycrab
e184dc55b2 Qt/NetPlay: Fix crashes on start 2018-05-06 19:00:17 +02:00
spycrab
7cd30810a3 Qt: Make dialogues more consistent 2018-05-06 18:05:56 +02:00
Léo Lam
26be225c92
Merge pull request #6761 from spycrab/qt_win_font 
Qt/Win32: Use better method to obtain the default font
 2018-05-06 16:15:11 +02:00
Léo Lam
76b031184c
Merge pull request #6341 from sepalani/debug-watches 
DebugInterface: Watches methods added
 2018-05-06 13:25:26 +02:00
Léo Lam
7a9e1a240e
Merge pull request #6757 from JosJuice/qt-filesystem-extraction 
DolphinQt2: Fix disc extraction inconsistencies with DolphinWX
 2018-05-06 13:24:06 +02:00
Léo Lam
3f087e2ed5
Merge pull request #6760 from lioncash/msr 
PowerPC: Make the PowerPCState's msr member variable a UReg_MSR instance
 2018-05-06 12:02:39 +02:00
Léo Lam
27f6274fc5
Merge pull request #6762 from lioncash/condition 
DolphinQt/MemoryWidget: Fix dead condition in FindValue()
 2018-05-06 12:01:24 +02:00
spycrab
6f65238efc Qt: Fix "Render To Main" 2018-05-06 04:51:13 +02:00
Anthony
2588b5e40e
Merge pull request #6750 from spycrab/qt_render_widget 
Qt: Fix multiple RenderWidget issues
 2018-05-05 18:39:40 -07:00
spycrab
6442b32aeb Qt/AdvancedWidget: Fix "Enable Progressive Scan" 2018-05-06 03:16:43 +02:00
Lioncash
31389bab0a DolphinQt/MemoryWidget: Fix dead condition in FindValue() 
This condition is already checked earlier in the function and exits out
if it's satisfied, meaning it'll never reach this check further down.
 2018-05-05 20:44:38 -04:00
spycrab
49a1b2e5df Qt/Win32: Use better method to obtain the default font 2018-05-06 02:37:52 +02:00
Lioncash
ffcf107dd2 PowerPC: Make the PowerPCState's msr member variable a UReg_MSR instance 
Gets rid of the need to construct UReg_MSR values around the the actual
member in order to query information from it (without using shifts and
masks). This makes it more concise in some areas, while helping with
readability in some other places (such as copying the ILE bit to the LE
bit in the exception checking functions).
 2018-05-05 17:59:30 -04:00
JosJuice
33211d8690 DolphinQt2: Don't show pop-ups in the middle of extracting a whole disc 2018-05-05 18:31:46 +02:00
JosJuice
f48fac5b55 DolphinQt2: Allow picking "Extract Files..." on disc/partition 
DolphinWX already does this.
 2018-05-05 18:31:44 +02:00
Léo Lam
58b96eeb9d
Merge pull request #6756 from spycrab/qt_segoe_ui 
Qt/Win32: Force Segoe UI
 2018-05-05 18:09:00 +02:00
spycrab
7d762fd632 Qt/RenderWidget: Restore size when exiting fullscreen 2018-05-05 17:05:32 +02:00
JosJuice
1a74de6462 DolphinQt2: Fix the file structure of extracted discs 
Now all the partitions won't be all jumbled up in one folder,
and the filesystem contents won't be mixed with system data.
 2018-05-05 17:00:27 +02:00
Léo Lam
975689e1f7
Merge pull request #6754 from spycrab/qt_no_whatsthis 
Qt: Remove "What's this" button
 2018-05-05 16:04:52 +02:00
spycrab
ad21282379 Qt/Win32: Force Segoe UI 2018-05-05 12:41:56 +02:00
Léo Lam
31efec623a
Merge pull request #6695 from Ebola16/UbershadersDecrip 
Update Ubershader descriptions
 2018-05-05 11:16:30 +02:00
Léo Lam
d848c7e027
Merge pull request #6716 from container1234/qt-cheats-manager 
Qt/CheatsManager: Fix updating search result takes a long time
 2018-05-05 10:42:09 +02:00
Léo Lam
bf8b9f4a34
Merge pull request #6739 from spycrab/qt_aesthetics 
Qt: Fix visual inconsistencies.
 2018-05-05 10:37:44 +02:00
Léo Lam
86f56b8047
Merge pull request #6747 from aldelaro5/qt-debugger-setting-ini 
INI: Create a new INI setting for toggling the debugger UI
 2018-05-05 10:33:04 +02:00
Léo Lam
6e6bf689e7
Merge pull request #6751 from spycrab/qt_show_disc 
Qt: Show disc number
 2018-05-05 10:28:40 +02:00
Pierre Bourdon
798639291f
Merge pull request #6749 from spycrab/qt_gcontrols_crash 
Qt/GraphicsControls: Fix more random crashes
 2018-05-05 03:02:43 +02:00
spycrab
69d6c0dccb Qt: Remove "What's this" button 2018-05-05 02:29:16 +02:00
aldelaro5
fee92cd4fc
INI: Create a new INI setting for toggling the debugger UI 
Qt introduced a checkbox to toggle the debugger UI, this makes it work into a setting stored in the INI, it also makes the -d argument only in effect when enabled, in such case, it will override the INI by overriding it.
 2018-05-04 19:23:03 -04:00
spycrab
db0e5108dc Win32/FileUtil: Fix IsDirectory() not working for certain directories 2018-05-04 23:53:41 +02:00
spycrab
67f874250a Qt: Show disc number 2018-05-04 22:38:27 +02:00
spycrab
e809eef11a Qt/AdvancedWidget: Fix progressive scan checkbox 2018-05-04 21:33:24 +02:00
spycrab
452cc6b69f Qt/RenderWidget: Show proper icon and title 2018-05-04 14:04:46 +02:00
spycrab
300c3970f3 Qt/GraphicsControls: Fix more random crashes 2018-05-04 13:51:55 +02:00
Stenzek
a5e410b7c9
Merge pull request #6744 from stenzek/ui-disable-vram-copies 
UI: Add Disable EFB Copies to VRAM to Advanced Options
 2018-05-04 12:01:29 +10:00
spycrab
96e488a181 Qt/PathPane: Add dots to buttons 2018-05-04 00:12:08 +02:00
spycrab
d97d916758 Qt/Settings: Restore padding 2018-05-04 00:12:08 +02:00
spycrab
b741ef81bd Qt/WrapInScrollArea: Make background color more consistent 2018-05-04 00:12:08 +02:00
Mat M
54a6b0f50a
Merge pull request #6726 from spycrab/qt_sort_alpha 
Qt/GameList: Always sort games alphabetically
 2018-05-03 13:13:09 -04:00
Mat M
348125eda4
Merge pull request #6738 from spycrab/qt_fix_empty_adapter 
Qt/GeneralWidget: Fix empty adapter option
 2018-05-03 13:11:00 -04:00
Mat M
689a70a7f1
Merge pull request #6736 from spycrab/qt_bad_range_clear 
Qt/MappingButton: Fix bad range default
 2018-05-03 13:09:26 -04:00
Mat M
cf40ebf16a
Merge pull request #6737 from JosJuice/qt-invalid-si-device 
DolphinQt2: Don't crash on invalid SI devices
 2018-05-03 13:07:23 -04:00
Stenzek
be32602769
Merge pull request #6745 from spycrab/qt_fullscreen 
Qt: Call Render::SetFullscreen
 2018-05-03 23:28:21 +10:00
spycrab
a61445919d Qt/GraphicsSlider: Fix random crashes 2018-05-03 15:22:40 +02:00
spycrab
68e2b46ba1 Qt: Call Render::SetFullscreen 2018-05-03 15:15:35 +02:00
Stenzek
d4f6c86eec UI: Add Disable EFB Copies to VRAM to Advanced Options 2018-05-03 14:31:04 +10:00
Stenzek
8a061d6fb4 Qt/AdvancedWidget: Fix borderless fullscreen option not showing 2018-05-03 14:13:35 +10:00
spycrab
6b5b51831a Qt/GameList: Always sort games alphabetically 2018-05-02 21:57:46 +02:00
spycrab
0595fd498f Qt/MappingButton: Fix bad range default 2018-05-02 21:50:50 +02:00
JosJuice
16b805410f DolphinQt2: Don't crash on invalid SI devices 
This is important if we ever add or delete SI devices.
 2018-05-02 21:50:28 +02:00
Mat M
ed6709ac8f
Merge pull request #6731 from spycrab/qt_cache_slider 
Qt/HacksWidget: Fix "Accuracy" slider
 2018-05-02 15:48:33 -04:00
spycrab
b99610f1a3 Qt/GeneralWidget: Fix empty adapter option 2018-05-02 19:20:45 +02:00
spycrab
e3cebebe51 Qt/MappingButton: Fix Clear not resetting ranges 2018-05-02 17:02:14 +02:00
spycrab
3d7b613be5 Qt/Mapping: Fix "Default" not working properly. 2018-05-02 16:55:42 +02:00
spycrab
ef3f660983 Qt/HacksWidget: Fix "Accuracy" slider 2018-05-02 16:36:15 +02:00
spycrab
0d5b34be34 Qt/MappingWindow: Fix saving to incomplete Profile directory 2018-05-02 06:45:11 +02:00
Ryan Meredith
05205ce3d7 Update Ubershader descriptions 2018-05-01 18:57:34 -04:00
Stenzek
6e62d1ab9f
Merge pull request #6722 from spycrab/qt_adapter 
Qt/GraphicsSettings: Save Adapter index
 2018-05-01 21:57:50 +10:00
spycrab
87d6bffcec Qt/GraphicsSettings: Fix various adapter issues 2018-05-01 13:54:01 +02:00
container1234
850afd8457 Qt/CheatsManager: Fix updating search result takes a long time 2018-05-01 18:58:58 +09:00
Léo Lam
78c9bad44f
Merge pull request #6688 from spycrab/qt_dedup 
Qt: Deduplicate settings
 2018-05-01 11:53:39 +02:00
Léo Lam
23f958d766
Merge pull request #6715 from spycrab/qt_path_fixes 
Qt/PathPane: Various fixes
 2018-05-01 11:40:21 +02:00
Stenzek
c46882142b
Merge pull request #6369 from stenzek/xfb-copy-filter 
Implement copy filter (deflickering/brightness) and XFB gamma
 2018-05-01 19:31:54 +10:00
Stenzek
42d73deaed
Merge pull request #6723 from spycrab/qt_fix_profile_save 
Qt/MappingWindow: Fix profile saving
 2018-05-01 19:26:22 +10:00