Commit Graph

35050 Commits

Author SHA1 Message Date
c89ae53677 msvc: remove warning disables which no longer fire 2021-07-17 18:24:36 -07:00
d7a5558dc5 Merge pull request #9905 from shuffle2/msvc-outdated-comment
remove an outdated comment
2021-07-18 02:20:56 +01:00
8feff42338 Merge pull request #9904 from shuffle2/msvc-volatile-ut
unittests: remove some msvc-specific casts
2021-07-18 02:20:31 +01:00
f5b05ae080 remove an outdated comment
seems to have been solved 5 years ago by
b707e199c2
2021-07-17 17:46:57 -07:00
1009825cb2 unittests: remove some msvc-specific casts
compiles on contemporary msvc
checked there is still a mul in release codegen
2021-07-17 17:41:41 -07:00
e9068e108a Merge pull request #9903 from shuffle2/msbuild-lang
msbuild: use Build dir for Languages
2021-07-18 01:07:30 +01:00
bc22c74cd9 msbuild: use Build dir for Languages 2021-07-17 16:41:43 -07:00
2adbd77a4c Merge pull request #9902 from shuffle2/msbuild-deprecated
msbuild: remove deprecated MinimalRebuild
2021-07-17 23:31:21 +01:00
7117bd5772 msbuild: remove deprecated MinimalRebuild
we were explicitly disabling it, which is
effectively the new behavior
2021-07-17 14:29:03 -07:00
0b18f8ae55 Merge pull request #9894 from AdmiralCurtiss/smooth-moves-tex-cache-ini
GameINI: Set safe texture cache in WarioWare: Smooth Moves for Writer's Block and Brain Age microgames.
2021-07-14 21:43:34 +02:00
cccb1eef84 Merge pull request #9897 from leoetlino/axe-faulty-ax-checks
DSPHLE: Minor AX fixes
2021-07-14 20:37:52 +02:00
5021a13aa9 DSPHLE: Fix running and is_stream checks in AX HLE
A voice is considered running if and only if `running` equals 1,
not if `running` is not equal to 0.

This fixes https://bugs.dolphin-emu.org/issues/12508 because for some
reason *The Sims 2 - Castaway* sets `running` to 8 when a stream
finishes playing; previously our AX HLE would just loop the voice
and eventually crash after accessing invalid memory addresses.

Thanks to JMC47 and delroth's help, I've verified that this is the
correct check for the following ucodes:

GC:
* 0x3ad3b7ac
* 0x3daf59b9
* 0x4e8a8b21
* 0x07f88145
* 0xe2136399
* 0x3389a79e

Wii:
* 0x347112ba
* 0xfa450138
* 0xadbc06bd

And while I was fixing the running check, I noticed that the is_stream
field was also being handled incorrectly, so I've fixed that as well.
2021-07-14 19:21:35 +02:00
887fcfc99a DSPHLE: Remove redundant accelerator end check for AX Wii 2021-07-14 19:20:25 +02:00
9b17805be9 Merge pull request #9881 from blaahaj/postprocessing-fix
PostProcessing: Fix OpenGL UBO linking with configuration options
2021-07-14 13:14:17 +10:00
fd7c4b2c00 Merge pull request #9891 from JMC47/jettsonic
Fix Motion Detection in Sonic and the Secret Rings and Jett Rocket
2021-07-13 21:06:04 +02:00
eedae929b7 GameINI: Set safe texture cache in WarioWare: Smooth Moves for Writer's Block and Brain Age microgames. 2021-07-13 20:38:56 +02:00
b944ffc109 Fix Motion Detection in Sonic and the Secret Rings and Jett Rocket 2021-07-13 03:37:09 -04:00
b0d2df727a Merge pull request #9686 from Dentomologist/convert_adapter_tooltip_to_balloontip
GeneralWidget: Convert Adapter tooltip to BalloonTip
2021-07-13 03:33:42 +02:00
de54856fbb Merge pull request #9846 from jordan-woyak/report-dup-setting
Config: Add an ini setting to control real Wii Remote report duplication.
2021-07-13 03:32:49 +02:00
162af2a7bb Merge pull request #9870 from OatmealDome/ui-thread
macOS: Move UI API calls to the main thread
2021-07-13 03:29:49 +02:00
b09347c160 Merge pull request #9877 from JosJuice/android-early-panic
Android: Avoid crash on early panic alert
2021-07-13 03:27:12 +02:00
8fcda4c315 Merge pull request #9889 from leoetlino/ax-symbols
DSPHLE: Prevent AX GC and AX Wii symbol mixups
2021-07-13 01:41:44 +01:00
edc4396603 Merge pull request #9888 from JosJuice/jitarm64-logicalimm-everywhere
JitArm64: Stop using hand-encoded logical immediates
2021-07-12 23:03:31 +02:00
3af21d3d22 JitArm64: Optimize FloatCompare's CR value emitting
Setting bit 32 is only needed in the case where EQ and GT are set
but SO and LT are not, which is not a possible outcome of a compare.
2021-07-12 22:54:37 +02:00
8af5095ff4 JitArm64: Stop using hand-encoded logical immediates 2021-07-12 22:25:49 +02:00
474adcc601 DSPHLE: Prevent AX GC and AX Wii symbol mixups
Putting AX functions from AXVoice.h in an anonymous namespace does
successfully prevent compilers from merging those functions and
allows us to avoid ODR violations.

However, tools such as gdb still mix up AX GC and AX Wii functions
and variables because those have the exact same symbol names.

This can be fixed by using inline namespaces which are transparent
at the source code level but forces AX GC and AX Wii symbols to be
different.
2021-07-12 16:30:15 +02:00
2b26e729c3 Merge pull request #9887 from CrystalGamma/fix-vertexloader-generic
VideoCommon: fix generic build
2021-07-12 09:05:46 +02:00
beb6ec0569 VideoCommon: fix generic build
On x86/ARM Common/Assert.h is included by way of
VideoCommon/VertexLoader{X64,ARM64}.h, on other platforms it is missing.
2021-07-12 04:30:43 +02:00
93626764d4 Merge pull request #9863 from Pokechu22/zora-eyes-v2
Ignore the top bit of the indirect texture matrix scale
2021-07-11 23:10:47 +01:00
b880be0aa5 Use separate fmt::formatters for each indirect matrix column
This also fixes a bug where the float version of row 1 actually showed row 0 again.
2021-07-11 15:01:42 -07:00
f467c02d1a Ignore the top bit of the indirect texture matrix scale
This fixes the Zora eye coloration in Twilight Princess.
2021-07-11 15:01:37 -07:00
20a8e9c872 Merge pull request #9876 from Pokechu22/skyward-sword-map
Fix indirect textures when format is not ITF_8
2021-07-11 22:59:23 +01:00
f9baff46a6 Merge pull request #9885 from Tilka/datel
GameFile: don't download covers for empty game IDs
2021-07-11 19:52:20 +01:00
bd5c604718 GameFile: don't download covers for empty game IDs 2021-07-11 17:14:43 +01:00
88fd9fd577 Merge pull request #9869 from JosJuice/jitarm64-constexpr-isimmlogical
JitArm64: Encode logical immediates at compile-time where possible
2021-07-11 12:55:48 +02:00
4157967f04 Merge pull request #9883 from JosJuice/jitarm64-fix-ps-cmpxx
JitArm64: Fix ps_cmpXX
2021-07-11 12:28:11 +02:00
f903853cf7 JitArm64: Fix ps_cmpXX
Passing a width of 64 and registers encoded as double to
DUP resulted in an invalid instruction. The registers should
be encoded as quads in this situation.

Fixes https://bugs.dolphin-emu.org/issues/12575.
2021-07-11 11:43:19 +02:00
0f3b9a8874 JitArm64: Minor mcrfs optimization 2021-07-10 20:44:22 +02:00
9e80db123f JitArm64: Encode logical immediates at compile-time where possible
Manually encoding and decoding logical immediates is error-prone.
Using ORRI2R and friends lets us avoid doing the work manually,
but in exchange, there is a runtime performance penalty. It's
probably rather small, but still, it would be nice if we could
let the compiler do the work at compile-time. And that's exactly
what this commit does, so now I have no excuse for trying to
manually write logical immediates anymore.
2021-07-10 20:43:59 +02:00
10861ed8ce JitArm64: Turn IsImmLogical into a constexpr constructor 2021-07-10 20:31:28 +02:00
ab024b218e JitArm64: Accept LogicalImm struct as bitwise inst parameter 2021-07-10 20:13:11 +02:00
f6ca70d094 Merge pull request #9822 from JosJuice/jitarm64-ps-cmpxx
JitArm64: Implement ps_cmpXX
2021-07-10 19:20:48 +02:00
adbf6d55da JitArm64: Implement ps_cmpXX 2021-07-10 19:08:55 +02:00
4ba4d7cc7d Merge pull request #9878 from JosJuice/jitarm64-addmex
JitArm64: Implement addmex/subfmex
2021-07-10 10:11:20 +02:00
59292a5c65 GeneralWidget: Convert Adapter tooltip to BalloonTip
Use a BalloonTip to inform the user when their selected backend (i.e.
OpenGL or NULL) doesn't support adapters, instead of using the default
tooltips.
2021-07-09 10:10:36 -07:00
afe9c6fb9a Merge pull request #9880 from OatmealDome/windows-updater
UpdaterCommon: Use File::Copy() on non-macOS platforms
2021-07-09 19:02:42 +02:00
a39b7a45c0 UpdaterCommon: Use File::Copy() on non-macOS platforms 2021-07-09 12:56:23 -04:00
fc60e62622 JitArm64: Implement addmex/subfmex 2021-07-09 16:44:33 +02:00
838434a9df Merge pull request #9879 from AdmiralCurtiss/host-is-instruction-ram-address-fix
Core/MMU: Fix inverted condition in HostIsInstructionRAMAddress().
2021-07-09 11:54:58 +02:00
c9e4489e17 Core/MMU: Fix inverted condition in HostIsInstructionRAMAddress(). 2021-07-09 05:48:17 +02:00