piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 13:57:57 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
37,388 Commits 5 Branches 11 Tags 1.3 GiB
8ad7fa0313
Commit Graph

2251 Commits

Author SHA1 Message Date
Patrick A. Ferry
f6a4368192 SW: Fix alignedWidth in TextureEncoder 
This was causing issues in Software Renderer. Look at bug 11487
 2021-04-19 02:06:52 +01:00
Connor McLaughlin
b24e3f2f1a Vulkan: Work around AMD exclusive fullscreen bug (21.3+) 2021-04-12 12:41:17 +10:00
Pokechu22
5b1c632862 Software: Invert backface test when viewport is positive 
Fixes Jimmie Johnson's Anything with an Engine.
 2021-03-06 22:00:16 -08:00
Pokechu22
058c7db80b Software: Fix out of bounds accesses in CopyRegion 
Fixes issue 11393.

The problem is that left and top make no sense for a width by height array; they only make sense in a larger array where from which a smaller part is extracted.  Thus, the overall size of the array is provided to CopyRegion in addition to the sub-region.  EncodeXFB already handles the extraction, so CopyRegion's only use there is to resize the image (and thus no sub-region is provided).
 2021-03-06 21:58:28 -08:00
Pokechu22
70f9fc4e75 Convert BPMemory to BitField and enum class 
Additional changes:
- For TevStageCombiner's ColorCombiner and AlphaCombiner, op/comparison and scale/compare_mode have been split as there are different meanings and enums if bias is set to compare.  (Shift has also been renamed to scale)
- In TexMode0, min_filter has been split into min_mip and min_filter.
- In TexImage1, image_type is now cache_manually_managed.
- The unused bit in GenMode is now exposed.
- LPSize's lineaspect is now named adjust_for_aspect_ratio.
 2021-03-06 19:27:19 -08:00
Pokechu22
aab81d5aa0 Convert XFMemory to BitField and enum class 
Additionally a new ClipDisable union has been added (though it is not currently used by Dolphin).
 2021-03-06 19:27:14 -08:00
Pokechu22
f749fcfa9f Convert CPMemory to BitField and enum class 
Additionally, VCacheEnhance has been added to UVAT_group1.  According to YAGCD, this field is always 1.

TVtxDesc also now has separate low and high fields whose hex values correspond with the proper registers, instead of having one 33-bit value.  This change was made in a way that should be backwards-compatible.
 2021-03-06 19:27:08 -08:00
Pokechu22
fcd3efa1ae Software: Implement points 2021-02-13 15:59:40 -08:00
Pokechu22
8e348b87e9 Software: Fix line-width effects 2021-02-13 15:59:39 -08:00
Pokechu22
7d5ae03219 Software: Always divide the texture coordinates by q. 
Equivalent to da43f9a15 for the software renderer.
 2021-02-12 16:37:47 -08:00
Léo Lam
a354814240
Merge pull request #9424 from Pokechu22/sw-no-special-case 
Software: Remove normalization special case
 2021-02-11 19:36:45 +01:00
Shawn Hoffman
500a694ca8 msbuild: bundle all dolphin "core" code into single library 2021-01-27 14:29:49 -08:00
Shawn Hoffman
5770ff01f3 rename D3DCommon/Common to D3DCommon/D3DCommon 2021-01-27 14:29:48 -08:00
Shawn Hoffman
527b5a9761 normalize common filenames in VideoBackends/D3D12 2021-01-27 14:29:48 -08:00
Shawn Hoffman
a0aeb5b0b9 normalize common filenames in VideoBackends/D3D 2021-01-27 14:29:48 -08:00
Shawn Hoffman
d7fd892fde normalize common filenames in VideoBackends/Vulkan 2021-01-27 14:29:48 -08:00
Shawn Hoffman
ef70fe05bf normalize common filenames in VideoBackends/Null 2021-01-27 14:29:48 -08:00
Shawn Hoffman
ff4f67492b normalize common filenames in VideoBackends/OGL 2021-01-27 14:29:48 -08:00
Pokechu22
e825af7b1b Software: Remove normalization special case 
The special case doesn't appear to make a significant difference in any games, and the current implementation has a (minor, fixable) issue that breaks Super Mario Sunshine (both with a failed assertion (https://bugs.dolphin-emu.org/issues/11742) and a rendering issue (https://bugs.dolphin-emu.org/issues/7476)).  Hardware testing wasn't able to reproduce the special case, either, so it may just not exist.

PR #9315 contains a fixed implementation of the special case on all video backends, and can serve as a basis for it being reintroduced if it is found to exist under more specific circumstances.  For now, I don't see a reason to keep it present.
 2021-01-03 23:22:48 -08:00
Léo Lam
0ad2f3da45
Core: Remove ImageWrite and get rid of -Wmissing-declarations warnings 2020-12-16 16:04:19 +01:00
Léo Lam
eafe005672
Fix -Wclass-memaccess warnings 
We want to clear/memset the padding bytes, not just each member,
so using assignment or {} initialization is not an option.

To silence the warnings, cast the object pointer to u8* (which is not
undefined behavior) to make it explicit to the compiler that we want
to fill the object representation.
 2020-12-16 15:37:43 +01:00
Lioncash
139d4fc76e General: Convert PanicAlerts over to fmt equivalent 
Converts lingering panic alert calls over to the fmt-capable ones.
 2020-12-02 13:38:33 -05:00
blåhaj
bf0fe0281a Fix bounding box incorrectly disabled on OpenGL ES 3.1, 3.2 2020-11-24 21:22:39 +01:00
Stenzek
d6ce8eef36 Software: Use same logic for colors as hardware backends 2020-11-20 15:54:06 -08:00
Jonathan Marek
a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case 
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:

Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets

Signed-off-by: Jonathan Marek <jonathan@marek.ca>

[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
 2020-11-20 12:23:34 +01:00
Lioncash
21dd7a8ebb Vulkan: Migrate logging over to fmt 
Migrates the vulkan backend over to the fmt-capable logger.
 2020-11-09 03:26:16 -05:00
Lioncash
23a8baa605 Software: Migrate logging over to fmt 
Migrates the software backend over to the fmt-capable logger.
 2020-11-09 03:14:01 -05:00
Lioncash
413d64e7fc OpenGL: Migrate logging over to fmt 
Migrates over to the fmt-capable logger.
 2020-11-09 03:09:09 -05:00
Lioncash
4d9a7c7a54 D3DCommon: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 03:03:26 -05:00
Lioncash
2345d5f98d D3D: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 03:02:00 -05:00
Lioncash
d7834bd6b4 D3D12: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 02:59:51 -05:00
JosJuice
28aa04312c Common/LinearDiskCache: Replace std::fstream with File::IOFile 
File::IOFile is better suited to this type of task.
Split out from a future PR.
 2020-11-05 00:31:17 +01:00
Jordan Woyak
d2f80a4595
Merge pull request #9138 from martymac/VK_NULL_HANDLE-fix 
Fix build on FreeBSD i386 - nullptr vs VK_NULL_HANDLE
 2020-11-03 08:28:11 -06:00
Ganael Laplanche
d456e2e391 Resolve VkDeviceMemory/nullptr type mismatch to fix build on FreeBSD i386 2020-11-03 07:47:43 +01:00
JMC47
6a3a71cfd7
Merge pull request #9141 from Techjar/but-for-how-long 
Re-enable GPU Texture Decoding under MoltenVK
 2020-10-29 01:22:13 -04:00
mazes-80
f375ee72a2
CMake: Add option to enable/disable Vulkan video backend 2020-10-23 20:14:46 +02:00
Techjar
0c01712d13 DriverDetails: Remove bug for broken GPU Texture Decoding 2020-10-08 10:13:40 -04:00
Stenzek
24bb947eff Vulkan: Use VK_LAYER_KHRONOS_validation for validation 
VK_LAYER_LUNARG_standard_validation is deprecated.
 2020-10-01 17:21:46 +10:00
Techjar
69358b2186 VideoBackends: Disable GPU Texture Decoding under MoltenVK 
It's broken and causes spectacular artifacts and crashes.
 2020-09-07 17:28:05 -04:00
JosJuice
6eefc3c524 Make default graphics backend not show up as empty 
Fixes https://bugs.dolphin-emu.org/issues/12245.

I considered making a change to DolphinQt instead of
the core, but then additional effort would've been
required to add the same fix to the Android GUI once
we start using the new config system there.
 2020-09-06 12:56:45 +02:00
Shawn Hoffman
969ea6e4f5 msvc: enable /Zc:preprocessor and make build compile cleanly 2020-08-27 21:58:48 -07:00
Shawn Hoffman
4db06bf85b ogl: init ProgramShaderCache::s_ubo_align to 1. 
silences a warning that it may cause div-by-zero.
 2020-08-27 15:15:52 -07:00
Shawn Hoffman
938fd4e438 use constexpr for some compile-time expressions 2020-08-23 13:57:05 -07:00
Shawn Hoffman
6ef9d70701 name some threads 2020-08-22 17:22:07 -07:00
LC
4a34b74e68
Merge pull request #9035 from shuffle2/vs-pretty 
misc vcxproj cleanup
 2020-08-22 20:13:25 -04:00
Shawn Hoffman
cff4806d8d windows: fix build if pch were to be disabled 2020-08-22 16:18:24 -07:00
Shawn Hoffman
2f47f486af msbuild: re-enable standalone vcxproj processing 2020-08-22 16:17:50 -07:00
Shawn Hoffman
94bf48b67c msbuild: refactor stuff out of project files (for dolphin) 2020-08-22 16:17:50 -07:00
Shawn Hoffman
3a0d8c0208 msbuild: enable D3DCommon to use pch 2020-08-22 16:17:50 -07:00
Shawn Hoffman
36ace8eb52 prettify some constructs in vcxproj files 2020-08-22 16:17:50 -07:00
LC
487cd7abd9
Merge pull request #8905 from JosJuice/jni-encoding 
Android: Use correct encoding when converting strings
 2020-07-18 22:13:14 -04:00
Filip Gawin
0ede5d1537 Use range loop (if possible) 2020-07-18 18:29:16 -05:00
JosJuice
15d9fab0bb Common: Rename UTF16ToUTF8 
This function does *not* always convert from UTF-16. It converts
from UTF-16 on Windows and UTF-32 on other operating systems.

Also renaming UTF8ToUTF16 for consistency, even though it
technically doesn't have the same problem since it only was
implemented on Windows.
 2020-07-08 14:51:35 +02:00
JosJuice
6f298378a1 Reword "Please avoid forcing Dolphin to use MSAA by the driver" message 
Some users who get this error don't seem to gain much understanding
of how to resolve the problem from reading the error message.
 2020-07-08 11:34:36 +02:00
orbea
ba2d04b793 Externals: Fix build failures with the newer glslang. 
v2: Don't include glslang project wide.
 2020-05-30 18:54:21 -07:00
Lioncash
86f8768268 VideoCommon/ShaderGenCommon: Make template functions regular functions 
These are only ever used with ShaderCode instances and nothing else.
Given that, we can convert these helper functions to expect that type of
object as an argument and remove the need for templates, improving
compiler throughput a marginal amount, as the template instantiation
process doesn't need to be performed.

We can also move the definitions of these functions into the cpp file,
which allows us to remove a few inclusions from the ShaderGenCommon
header. This uncovered a few instances of indirect inclusions being
relied upon in other source files.

One other benefit is this allows changes to be made to the definitions
of the functions without needing to recompile all translation units that
make use of these functions, making change testing a little quicker.

Moving the definitions into the cpp file also allows us to completely
hide DefineOutputMember() from external view, given it's only ever used
inside of GenerateVSOutputMembers().
 2020-05-25 21:12:29 -04:00
Stenzek
bf74553878 FramebufferManager: Copy to color format for depth readbacks on GLES 
glReadPixels() with depth formats is not supported.

Should fix broken EFB access on GLES.
 2020-05-24 16:11:11 +10:00
degasus
fc0df37d94 Fix windows build system. 2020-04-29 12:56:52 +02:00
Léo Lam
0fe4985f8d
Merge pull request #8689 from howard0su/cleanup_sign 
Remove warnings of -Wsign-compare
 2020-04-28 13:36:21 +02:00
Léo Lam
9d44af4c31
Merge pull request #8696 from howard0su/cleanup_shadow 
Cleanup warnings of -Wmissing-declarations
 2020-04-27 15:33:01 +02:00
Stenzek
a2f4fafe86 Vulkan: Switch from vkCreateMacOSSurfaceMVK() to vkCreateMetalSurfaceEXT() 
Since we are calling this off the UI thread, we can't use anything which
accesses the underlying NSView object. We create and set the Metal layer
on the UI thread before the video backend is initialized. This extension
is both compatible with MoltenVK and gfx-portability for accepting a
layer at surface creation.
 2020-04-07 18:56:55 +10:00
Jun Su
81f8099cc6 Remove warnings of -Wsign-compare 
Cast the variable to the coresponding type.
 2020-03-25 07:57:14 +08:00
Jun Su
b6ff15c130 Cleanup warnings of -Wmissing-declarations 
Add static to the functions which is not intentionally
export to big scope.
 2020-03-24 20:16:10 +08:00
Stenzek
fb947296b0 Vulkan: Pass CAMetalLayer to MoltenVK instead of NSView 
Gets rid of the warning for calling [NSView layer] off the main thread.
 2020-03-11 23:11:26 +10:00
Stenzek
a545344268 VideoBackends: Make it possible for PrepareWindow to change the surface 
Again, needed for MoltenVK.
 2020-03-11 23:10:30 +10:00
Stenzek
08cc73108a Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android 
Android 10 seems to expect a prerotated/transformed swap chain for optimal
presentation. For now, until we implement that, just ignore the hint.
 2020-01-31 19:16:06 +10:00
Stenzek
ead65b0d8c Vulkan: Log when a swap chain resize is occurring 
This may help us debug performance problems in the future.
 2020-01-31 19:11:43 +10:00
Ryan Meredith
e5f6d9320f Add Dolphin version and current video backend to shader compilation logs 2020-01-24 03:29:38 -05:00
David Korth
f5fe692842 Use pre-increment for iterators instead of post-increment. 
Pre-increment is more efficient, since it doesn't have to return the
old iterator.
 2019-12-29 23:45:02 -05:00
David Korth
05101b251c OGL/Render.cpp, InitDriverInfo(): Use std::string_view to eliminate string copies. 
Consolidate the NVIDIA Tegra and non-Tegra checks into one branch.
 2019-12-29 23:45:02 -05:00
Stenzek
6fcb1c6c46 Add an ARM64 target to Visual Studio projects 2019-12-28 19:20:41 +10:00
Casey Carter
222bc6a443 Include <memory> for std::unique_ptr in DXContext.h 2019-12-19 14:25:12 -08:00
Stenzek
e05bc33899 Vulkan: Call VertexManagerBase initialize 2019-12-09 19:16:15 +10:00
Stenzek
07c43b192f D3D12: Call VertexManagerBase initialize 2019-12-09 19:16:04 +10:00
Anthony
fdb78b64e1
Merge pull request #8513 from lioncash/bounding-box 
VideoCommon/BoundingBox: Make interface for querying bounding box data
 2019-12-07 18:40:02 -08:00
Lioncash
9bd533ebe4 VideoCommon/BoundingBox: Make interface for querying bounding box data 
Rather than expose the bounding box members directly, we can instead
provide an interface for code to use. This makes it nicer to transition
from global data, as the interface function names are already in
place.
 2019-12-05 11:48:42 -05:00
Lioncash
10f7674651 VideoCommon/IndexGenerator: Eliminate static state 
Now that we've extracted all of the stateless functions that can be
hidden, it's time to make the index generator a regular class with
active data members.

This can just be a member that sits within the vertex manager base
class. By deglobalizing the state of the index generator we also get rid
of the wonky dual-initializing that was going on within the OpenGL
backend.

Since the renderer is always initialized before the vertex manager, we
now only call Init() once throughout the execution lifecycle.
 2019-12-05 10:49:32 -05:00
Stenzek
dd23a1ee79 Update VS projects/solutions to VS2019 2019-11-30 13:42:52 +10:00
Lioncash
c792961000 Common: Unify logging namespace with Common 
Previously the logging was a in a little bit of a disarray. Some things
were in namespaces, and other things were not.

Given this code will feature a bit of restructuring during the
transition over to fmt, this is a good time to unify it under a single
namespace and also remove functions and types from the global namespace.

Now, all functions and types are under the Common::Log namespace. The
only outliers being, of course, the preprocessor macros.
 2019-11-28 05:13:21 -05:00
Silent
a68789a70c
D3DCommon: Remove unused GetDebugObjectName and tidy up SetDebugObjectName 2019-11-10 16:07:32 +01:00
Silent
8445644e05
D3DCommon: Migrate few remaining raw pointers to WRL::ComPtr 2019-11-10 16:07:32 +01:00
Connor McLaughlin
5440be96e7
Merge pull request #8378 from stenzek/quad-buffer-stereo 
Various quad-buffered ("HDMI 3D") stereo fixes
 2019-11-08 10:26:58 +10:00
Stenzek
16f103ab42 Vulkan: Exclusive fullscreen support via VK_EXT_full_screen_exclusive 2019-10-31 22:45:59 +10:00
Stenzek
6fc6444687 Vulkan: Explicitly enable VK_KHR_get_physical_device_properties2 
This was missing from the subgroup PR way back.
 2019-10-31 22:45:59 +10:00
Stenzek
230190fc36 Vulkan: Allow runtime querying of enabled extensions 2019-10-31 22:45:59 +10:00
Connor McLaughlin
d3ee0a4535
Merge pull request #8379 from stenzek/mali 
Vulkan: Optimizations for Mali with EFB2RAM on
 2019-10-31 22:44:19 +10:00
Stenzek
ae83d02e54 Drop 3D Vision Support 2019-10-04 13:40:21 +10:00
Stenzek
328d89db70 Vulkan: Add a DriverDetails bug for "slow cached readback memory" 
Using the cached memory type appears to be slower on Mali drivers, with
~10-15% CPU spent in the __pi___inval_cache_range kernel function.
 2019-10-02 21:34:58 +10:00
Stenzek
c557aa4a15 Vulkan: Add strict flag to memory type selection 2019-10-02 21:27:32 +10:00
Stenzek
e754c8ab26 D3D11: Initialize shader cache before renderer 
Otherwise the shaders we need for e.g. postprocessing are null.
 2019-10-02 11:50:10 +10:00
Connor McLaughlin
1092efa77a
Merge pull request #8276 from stenzek/adreno-efb-access 
Fix CPU EFB access on Adreno with Vulkan backend
 2019-08-08 12:23:27 +10:00
Stenzek
d78a9356d2 D3D11: Only use integer RTV when logic op is supported+enabled 2019-08-02 18:47:19 +10:00
Stenzek
2698e311aa Vulkan: Use correct aspect for D24S8 textures 2019-07-31 15:33:05 +10:00
Connor McLaughlin
dea2b9c509
Merge pull request #8258 from CookiePLMonster/dx11.1-detection-fixes 
D3D11 resources refactor and DX11.1 feature detection fixes
 2019-07-30 01:24:57 +10:00
Silent
baa9636d48
D3D11: Add extra logging to StateCache::Get 2019-07-29 16:48:24 +02:00
Silent
43bfb183c2
D3D11: Show a warning message about unsupported features when switching to D3D11 backend on Windows 7 2019-07-29 16:47:45 +02:00
Silent
ff00873610
D3D11: Query for output merger logic op support and use logic op code only if supported 
Previously code assumed that if DX11.1 runtime is supported, logic ops will,
but Windows 7 SP1 with a Platform Update supports DX11.1 runtime without logic ops.
This created pretty jarring visual artifacts, which now should be gone OR replaced
with much less jarring errors.
 2019-07-29 16:47:39 +02:00
Silent
a6b8e8b9c3
D3D11: Ownership fixes for objects in DXTexture 2019-07-29 16:43:02 +02:00
Silent
77425ef83b
D3D11: Ownership fixes for objects in D3DState 2019-07-29 16:39:21 +02:00
Silent
88db577c17
D3D11: Correctly poll ALL possible AA levels. 2019-07-29 16:39:06 +02:00
Connor McLaughlin
b0113b6c64
Merge pull request #8266 from lioncash/shadowing 
D3DCommon/Shader: Use std::optional where applicable
 2019-07-28 14:24:32 +10:00
Connor McLaughlin
5bad233b1a
Merge pull request #8265 from lioncash/view 
OGL/ProgramShaderCache: Use std::string_view where applicable
 2019-07-28 14:21:59 +10:00
Lioncash
6db305a4e8 VideoBackends/Null: Add missing override specifiers 
Applies a missing override specifier to VertexManager's destructor.
 2019-07-27 17:33:18 -04:00
Lioncash
23c5b362a5 VideoBackends/Null: Apply final to classes where applicable 
These aren't intended to be further specialized, so we can make this
obvious with final.
 2019-07-27 17:33:18 -04:00
Lioncash
86000fc6b4 VideoBackends/Null: Remove unnecessary constructors and destructors 
Removes constructors and destructors that don't actually provide any
behavior (i.e. doesn't constain generated code related to non-trivial
members in a cpp file, etc).

Lessens the amount of code present.
 2019-07-27 17:33:18 -04:00
Lioncash
bdcc5853d5 VideoBackends/Null: Remove unnecessary includes 2019-07-27 17:33:16 -04:00
Lioncash
aca02f9734 D3DCommon/Shader: Use std::optional with CompileShader() 
Allows removing the use of an out parameter, making it nicer to use.
 2019-07-26 20:06:14 -04:00
Lioncash
0ce6264f90 D3DCommon/Shader: Create vector via iterators in CreateByteCode() 
Same behavior, but without unnecessary zeroing of data contents.
Instead, we supply the dataset to use directly.
 2019-07-26 19:45:33 -04:00
Lioncash
287b446ef7 D3D/DXShader: Remove duplicate GetByteCode function 
This is already provided in the base class, which performs the same
exact behavior. Given the function in the base class isn't virtual, this
also essentially resolves an instance of shadowing.
 2019-07-26 19:45:23 -04:00
Lioncash
67bd2de73e OGL/ProgramShaderCache: Convert typedef over to a using alias 
Same thing, but nicer to read from left to right.
 2019-07-26 18:43:44 -04:00
Lioncash
d6617d399f OGL/ProgramShaderCache: Use std::lock_guard deduction guides where applicable 
Same thing, less reading.
 2019-07-26 18:22:55 -04:00
Lioncash
6e69e3cf26 OGL/ProgramShaderCache: Remove unused headers 
Removes a few inclusions that aren't necessary, reducing the number of
header dependencies.
 2019-07-26 18:09:44 -04:00
Lioncash
fb384dec55 OGL/ProgramShaderCache: Use std::string_view where applicable 2019-07-26 18:02:00 -04:00
Silent
890f781cd0
Factorize software renderer backend switching warning to be fetched from a new GetWarningMessage in video backend - will be needed for DX11.1 feature set warnings 2019-07-26 19:39:07 +02:00
Silent
799c52463e
Fixes for WRL usage - QueryInterface is explicitly mentioned as not to be used with WRL ComPtr 2019-07-26 19:38:58 +02:00
Connor McLaughlin
fc8859a414
Merge pull request #8249 from lioncash/rect 
VideoCommon: Remove unused MathUtil.h include from VideoCommon.h
 2019-07-19 16:32:30 +10:00
Stenzek
68bd4cd79a Vulkan: Use reversed depth range in viewport 
Also adds a DriverDetails bug to disable on drivers where this is still
broken.
 2019-07-18 23:43:12 +10:00
Lioncash
2b9389202e VideoCommon: Remove unused MathUtil.h include from VideoCommon.h 
This header doesn't actually make use of MathUtil.h within itself, so
this can be removed. Many other source files used VideoCommon.h as an
indirect include to include MathUtil.h, so these includes can also be
adjusted.

While we're at it, we can also migrate valid inclusions of VideoCommon.h
into cpp files where it can feasibly be done to minimize propagating it
via other headers.
 2019-07-16 20:54:34 -04:00
Lioncash
d4337eebde VideoCommon/Statistics: Rename stats global to g_stats 
Makes the global variable follow our convention of prefixing g_ on
global variables to make it obvious in surrounding code that it's not a
local variable.
 2019-07-10 23:34:54 -04:00
Lioncash
a99c7d01e1 VideoCommon/Statistics: Normalize statistic variable names 
Normalizes all variables related to statistics so that they follow our
coding style.

These are relatively low traffic areas, so this modification isn't too
noisy.
 2019-07-10 23:19:10 -04:00
Lioncash
04c06ec661 VideoCommon/Statistics: Use std::array for projection values 
Makes the members within the interface much nicer to look at, and also
makes copying them over much nicer too.
 2019-06-20 08:06:20 -04:00
Lioncash
72b04a353d VideoBackends/Vulkan: Use nested namespace specifiers where applicable 2019-06-17 16:57:30 -04:00
Connor McLaughlin
951b66e4ac
Merge pull request #8049 from stenzek/crop 
Renderer: Adjust source rectangle when crop would draw off screen
 2019-06-08 20:57:52 +10:00
Connor McLaughlin
5a4e2a6b2f
Merge pull request #7734 from stenzek/mojave-warning 
Vulkan: Display a warning when using MoltenVK on HS and earlier
 2019-06-08 20:41:39 +10:00
Stenzek
3f1586dbce Vulkan: Display a warning when using MoltenVK on HS and earlier 2019-06-08 20:16:24 +10:00
Stenzek
1028e2c1a6 D3D12: Remove unnecessary includes in DXContext.h 2019-06-08 20:12:15 +10:00
Stenzek
9316e25652 D3DCommon: Fallback to base CreateSwapChain on failure 
It appears that some older drivers do not support
CreateSwapChainForHwnd, resulting in DXGI_ERROR_INVALID_CALL. For these
cases, fall back to the base CreateSwapChain() from DXGI 1.0.

In theory this should also let us run on Win7 without the platform
update, but in reality we require the newer shader compiler so this
probably won't work regardless. Also any hardware of this vintage is
unlikely to run Dolphin well.
 2019-06-08 20:11:49 +10:00
Lioncash
a9663669dc Common/CommonFuncs: Remove now-unneccessary ArraySize function 
Since C++17, non-member std::size() is present in the standard library
which also operates on regular C arrays. Given that, we can just replace
usages of ArraySize with that where applicable.

In many cases, we can just change the actual C array ArraySize() was
called on into a std::array and just use its .size() member function
instead.

In some other cases, we can collapse the loops they were used in, into a
ranged-for loop, eliminating the need for en explicit bounds query.
 2019-06-01 10:07:57 -04:00
Lioncash
a41ba68c1e VideoVulkan/CMakeLists: Specify headers in target sources 2019-05-31 06:54:26 -04:00
Lioncash
cd9281772a VideoSoftware/CMakeLists: Specify headers in target sources 2019-05-31 06:54:26 -04:00
Lioncash
115e7992c5 VideoOGL/CMakeLists: Specify headers in target sources 2019-05-31 06:54:26 -04:00
Lioncash
968d379cc4 VideoNull/CMakeLists: Specify headers in target sources 2019-05-31 06:54:26 -04:00
Lioncash
1831dcbe6f VideoVulkan/ShaderCompiler: Use non-member std::size instead of ArraySize() 
Now that we're on C++17, we can use its non-member std::size function
instead of ours. This provides no functional change.
 2019-05-30 04:16:20 -04:00
Lioncash
d6a60050ff VideoVulkan/ShaderCompiler: Use a std::optional instead of bool+out variable 
Now that we utilize C++17, we can simply return an optional containing
the code instead of using an out variable and a boolean result,
essentially combining them into one.

This provides a much more straightforward interface.
 2019-05-30 04:16:17 -04:00
Lioncash
e60268bd42 VideoCommon/RenderBase: Use a std::string_view with CreateShaderFromSource() 
Greatly simplifies the overall interface when it comes to compiling
shaders. Also allows getting rid of a std::string overload of the same
name. Now std::string and const char* both go through the same function.
 2019-05-30 03:29:35 -04:00
Pokechu22
69d9d9f87a Also free when initialization fails, and move to end 2019-05-26 19:59:29 -07:00
Pokechu22
19fb3bb4fe DX11: Fix access violation on closing dolphin 2019-05-26 15:01:05 -07:00
spycrab
ec734065db
Merge pull request #8087 from spycrab/cmake_win2019 
Support CMake on Windows
 2019-05-14 21:07:26 +02:00
spycrab
6cef70c182 VideoBackends/D3D: Fix CMakeLists.txt 2019-05-12 00:05:09 +02:00
weihuoya
e98f43d2af bbox minor fx 2019-05-09 17:30:17 +08:00
spycrab
35f7abfe76 VideoBackends/D3DCommon: Fix linking against self 2019-05-08 20:59:15 +02:00
Techjar
ff972e3673 Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Léo Lam
ab9ece9bca Replace MathUtil::Clamp with std::clamp 2019-05-04 23:12:17 +02:00
Léo Lam
99a4ca8de7
Merge pull request #7839 from ShFil119/impr/redundant 
Remove redundant initialization
 2019-05-04 22:50:51 +02:00
Filip Gawin
c110ffcdaa Remove redundant initialization 2019-04-30 01:22:24 +02:00
Connor McLaughlin
1b1662773e
Merge pull request #8048 from stenzek/vulkan-negative-scissor-rect 
Vulkan: Don't set a negative offset in scissor rect
 2019-04-28 23:37:51 +10:00
Stenzek
32359bf2bb Renderer: Adjust target rectangle in the base class 2019-04-28 23:33:24 +10:00
Stenzek
3c64f0c616 Renderer: Adjust source rectangle when crop would draw off screen 
This prevents us from requiring an oversized and/or negative viewport by
shrinking the source rectangle instead.
 2019-04-28 23:31:57 +10:00
Connor McLaughlin
d2d8d7ce90
Merge pull request #8051 from JosJuice/efb-constexpr 
Turn EFB_WIDTH/EFB_HEIGHT into constexpr
 2019-04-28 20:37:25 +10:00
JosJuice
ced2306fc5 Turn EFB_WIDTH/EFB_HEIGHT into constexpr 
https://bugs.dolphin-emu.org/issues/11692#note-5

Also change const into constexpr while we're at it.
 2019-04-28 11:50:17 +02:00
Stenzek
5399995c61 Vulkan: Don't set a negative offset in scissor rect 
The spec/validation layers say this is invalid.
 2019-04-28 16:01:09 +10:00
Stenzek
025767c929 D3D: Set optional features after creating the device 
Fixes feature level 10.0 devices crashing during runtime.
 2019-04-28 15:26:49 +10:00
Stenzek
356ebdf509 OGL: Set shared context state up to match main context 
Has a better chance of avoiding recompiling if so.
 2019-04-21 14:28:14 +10:00
Stenzek
6553cf8bb1 OGL: Only set GL_PROGRAM_POINT_SIZE on desktop GL 
It is always enabled in GLES.
 2019-04-21 14:28:14 +10:00
Stenzek
f2a594fad5 OGL: Fix binding error on shutdown 
This was occurring if the imgui vertex format was bound on shutdown,
which is destroyed before the vertex buffers
 2019-04-21 14:28:14 +10:00
Stenzek
5c95dc61fc OGL: Store shader source in OGLShader 
So it can be dumped with info log when linking fails.
 2019-04-21 14:28:14 +10:00
Stenzek
bbd1ae16db OGL: Remove unused ProgramShaderCache::CompileShader() 2019-04-21 14:28:14 +10:00
Stenzek
f8c1ba409c Replace EFBRectangle/TargetRectangle with MathUtil::Rectangle 2019-04-21 14:28:14 +10:00
Stenzek
3791262d96 TextureCache: Use linear filtering on y-scaled and >1xIR VRAM copies 2019-04-21 12:41:15 +10:00
Stenzek
616ad378b7 OGL: Support returning pipeline cache data 2019-04-16 00:39:43 +10:00
Stenzek
5cef09e383 D3D12: Support returning pipeline cache data 2019-04-16 00:34:34 +10:00
Stenzek
61a656570e AbstractPipeline: Support returning "cache data" 
"Cache data" can be used to assist a driver with creating pipelines by
using previously-compiled shader ISA.
 2019-04-16 00:09:47 +10:00
Stenzek
474500f07e Vulkan: Prevent submission of command buffer with open queries 2019-04-01 20:49:42 +10:00
Stenzek
f2d8c8d2a8 D3D12: Fix rare case where command list was executed with open queries 2019-04-01 20:49:24 +10:00
Stenzek
92f1f553d1 D3D12: Fix case where perf queries weren't flushed 2019-04-01 20:13:39 +10:00
Stenzek
113bd60fe7 Implement D3D12 backend 2019-04-01 11:24:55 +10:00
Connor McLaughlin
39139a52e7
Merge pull request #7939 from Techjar/no-more-disabled-gfx-features 
Qt/HacksWidget: Fix backend feature support checks
 2019-03-31 11:59:34 +10:00
Stenzek
b685a66753 Vulkan: Fix crash when checking subgroup support on Mesa 2019-03-30 00:18:26 +10:00
Stenzek
a6bb06174f Vulkan: Fix library load failure on Android 2019-03-29 23:36:53 +10:00
Techjar
5d37b2b951 Qt/HacksWidget: Fix backend feature support checks 2019-03-29 08:45:21 -04:00
Stenzek
604ab67c7f Vulkan: Simplify perf queries using vkGetQueryPoolResults 2019-03-29 20:54:44 +10:00
Stenzek
6d40ea8553 Vulkan: Fix barrier validation layer errors for bounding box 2019-03-29 20:54:44 +10:00
Stenzek
23a655217c Vulkan: Fix validation layer error for unbound texture layouts 2019-03-29 20:54:44 +10:00
Stenzek
427dd45151 Vulkan: Simplify command buffer fence tracking 2019-03-29 20:54:44 +10:00
Connor McLaughlin
f3fadd7302
Merge pull request #7869 from stenzek/d3dcommon 
D3D: Move sharable D3D11/D3D12 code to common library
 2019-03-29 20:40:06 +10:00
Stenzek
6561850f2b Vulkan: Support subgroup reduction operations via GL_KHR_shader_subgroup 2019-03-29 20:06:56 +10:00
Stenzek
86da282570 OGL: Support subgroup reduction operations via GL_NV_shader_thread_shuffle 2019-03-29 20:06:56 +10:00
Stenzek
d0d010f854 D3D11: Make stateman a unique_ptr 2019-03-29 19:55:00 +10:00
Stenzek
3b86c93285 VertexManagerBase: Increase vertex/uniform buffer sizes 
ZTP was uploading 10MB+ of uniforms per frame, reducing paralellism by
forcing GPU waits.
 2019-03-29 19:52:38 +10:00
Stenzek
2a4bca8b4a VideoBackends: Verify validity before doing full renderer init 
Prevents attempting to create invalid MSAA configurations, for example.
 2019-03-29 19:52:38 +10:00
Stenzek
1151a1238f D3D11: Use ComPtr smart pointer where possible 2019-03-29 19:52:38 +10:00
Stenzek
3d8014beb5 D3D11: Use D3DCommon where appropriate 2019-03-29 19:52:38 +10:00
Stenzek
ea15080d8f Add D3DCommon (shared code between D3D11 and D3D12) 2019-03-29 19:52:38 +10:00
Stenzek
f6641b7e4f Vulkan: Use Common::DynamicLibrary 2019-03-29 19:52:38 +10:00
Stenzek
16294acd2a VideoBackends: Scale bounding box rectangle in the pixel shader 2019-03-25 18:47:58 +10:00
Dzmitry Malyshau
4173a8f545 Use proper view type of framebuffer images 2019-03-15 12:24:39 -04:00
Stenzek
a218a794cb FramebufferManager: Implement deferred EFB cache invalidation 2019-03-09 12:24:04 +10:00
Stenzek
65216c9e87 VideoConfig: Add SupportsPartialDepthCopies to backend info 
D3D11 doesn't support partial copies of depth buffers via
CopySubResource(), so we need to use a different path for the EFB cache.
 2019-03-09 12:19:53 +10:00
spycrab
f72652f690
Revert "Vulkan: Show backend as Vulkan (MoltenVK) on macOS" 2019-03-07 02:05:59 +01:00
spycrab
a5534ec950 Vulkan: Show backend as Vulkan (MoltenVK) on macOS 2019-03-06 15:25:54 +01:00
Stenzek
21d81f99ff VideoBackends: Fix GPU decoding of XFB buffers 
Was using UNORM instead of UINT, resulting in invalid values.
 2019-02-28 20:35:22 +10:00
Stenzek
f039149198 Move most backend functionality to VideoCommon 2019-02-19 16:57:54 +10:00
Stenzek
f9869cb216 Vulkan: Support runtime selection of WSI 2019-02-15 18:40:46 +10:00
Tilka
8d59d1bb11
Merge pull request #7798 from ShFil119/impr/empty 
Use empty instead of size
 2019-02-13 01:59:43 +00:00
Filip Gawin
49fe9f5db1 Use empty instead of size 2019-02-13 00:03:49 +01:00
Tilka
8aaebfa2b3
Merge pull request #7716 from stenzek/stereo 
Stereoscopy regression fixes
 2019-02-03 19:57:01 +00:00
Jordan Woyak
69b617ce76 WiimoteEmu: Remove redundant Matrix library and use the one in Common. 2019-02-03 12:02:02 -06:00
Tilka
2d75797c63
Merge pull request #7747 from stenzek/vulkan-shutdown 
Vulkan: Shutdown fixes and cleanup/refactoring
 2019-02-02 12:45:20 +00:00
Stenzek
3b033bf3f0 Vulkan: Move clear shader from Renderer to ShaderCache 2019-01-27 13:07:35 +10:00
Stenzek
e2cf238ec4 Vulkan: Move swapchain related members from Renderer to SwapChain 2019-01-27 12:59:57 +10:00